- Mar 24, 2024
-
-
Rob Swindell authored
-
Rob Swindell authored
-
Rob Swindell authored
Passing an unparseable integer to console.editfile() could leak heap memory
-
- Mar 23, 2024
-
-
Rob Swindell authored
A couple of error paths in expand_atcodes() method could leak heap memory.
-
Rob Swindell authored
This should resolve CID 487088: Unchecked return value from library as well as add some more instrumentation upon unexpected failures removing files. Consider: do some callers of this function need to know the success status (return bool)? That then starts to get into the some callers check and some don't situation (Coverity issue). For now, this is a void function. Also, all remove failures are logged as errors. Consider possibly passing a log level and calling lprintf() instead of errormsg(). errormsg() displays a notice to the user, which maybe we don't want.
-
Rob Swindell authored
Ideally, I'd use atomic_bool instead, but we're using an older WinSDK for Win7 compatibility and so... can't. Perhaps an xpdev 'protected_bool_t' should be created.
-
Rob Swindell authored
gmtime_r() can return NULL
-
Rob Swindell authored
Resoles (at least) CID 488305
-
Rob Swindell authored
... so use strncpy() and TERMINATE() here (instead of SAFECOPY) to resolve newly reported Coverity issues. There may be other places where we're using SAFECOPY() with an unterminated source string that would've been fine before we switched SAFECOPY from using strncpy to strlcpy. So we should reconsider that change.
-
Rob Swindell authored
-
Deucе authored
The ppm (image) of course is 24bpp, and the pbm (mask) is 1bpp, so the line lengths are different.
-
Rob Swindell authored
No functional change
-
Rob Swindell authored
-
Rob Swindell authored
-
Deucе authored
-
Rob Swindell authored
-
Deucе authored
Both sbbs-noskeeters and sbbs-build create sbbs-build.tgz Hopefully this fixes it and doesn't just break it worser.
-
Deucе authored
-
Deucе authored
Reverts gen_defs/genwrap craziness.
-
Deucе authored
This whole library is starting to get crufty and could use a room at a hackathon.
-
Deucе authored
This should hopefully surface whatever is corrupting the file.
-
Deucе authored
-
Rob Swindell authored
C++ <sigh> We don't need a .ini section separator anyway.
-
Deucе authored
This should help debug if multiple jobs are writing the same archives.
-
Rob Swindell authored
Just about everything in here has been implemented in v3.20 already
-
Rob Swindell authored
I suppose this should've been part of the previous commit. Again, this is almost verbatim what v4upgrade.c did (though never actually used).
-
Rob Swindell authored
This will allow us to change scfg_t.event[].last to a time_t value (from time32_t) whenever we abandon Borland C/C++ in the future. Now it's trival for sysops to view/edit when their timed events 'last run' values. And there's no more endianness concerns. Bad .dab files, bad, go away. After I wrote this change, I found the original conversion code in v4upgrade.c which is almost exactly the same (except I was going to write to different filename). Finally actually implemented this. Next up: qnet.dab
-
Rob Swindell authored
-
Rob Swindell authored
DDFileLister: (Hopefully) Fix for descLines being undefined in getFileInfoLineArrayForTraditionalUI() See merge request main/sbbs!428
-
Eric Oulashin authored
DDFileLister: (Hopefully) Fix for descLines being undefined in getFileInfoLineArrayForTraditionalUI()
-
- Mar 22, 2024
-
-
Rob Swindell authored
For Dumas Walker (CAPCITY2)
-
Deucе authored
-
Deucе authored
-
Deucе authored
-
Rob Swindell authored
-
Deucе authored
More compatible with C++ that way.
-
Deucе authored
Also, for DEBUG builds, add a static assertion that sizeof(dst) != sizeof(void*) to catch the most common breakage.
-
Deucе authored
-
Deucе authored
Need to update the parameter names as well.
-
Deucе authored
While we're here, Update strlcpy() to slightly more optimal FreeBSD-13.3 version.
-