Sometimes you want to see "1.5 minutes" (or "1.5M") intead of "90 seconds"
(or "90S")

I noticed some left over questionable use of ulong here in byte_count related
functions, so fixed that.

The number of failed login attempts. It's something.

Update wording and add more help text.

Now a sysop can "perm block" a client (IP address) for a limited amount of
time rather than always forever.

Add more displays of the ip.can details when actively blocking a client.

Moved twit/trash functions from userdat.c to trash.c

For symmetry

I wanted a couple of features for filters (e.g. blocked IP addreses):
- expiration date, optionally (only block for a limited time)
- display details of reason for filter in log messages (at time of block)

I've been thinking for some time that these files should be converted to .ini,
but then it occurred to me that I could do a sort of hybrid where the metadata
was key/value pairs tab-delimited from the search-pattern (first text on the
line). This is backward comaptible, relatively easy to view/edit by hand, and
extensible (easy to add/remove metadata fields in the future). So they'll
remain as text/*.can files.

The maximum line length for findstr/trashcan parsed files extended from 255 to
1000 characters.

Moved all trashcan-related functions from scfglib1.c to (new file) trash.c.

For the first time, I actually tested a build on WSL *before* committing to
Git. So, this *should* pass CI the first time. :-O

The output of this function was not ISO-8601 complaint (blush) and was not
parsable by isoDateTimeStr_parse() (returned -1).

e.g. "20231217T011437-480" rather than "20231217T135222-0800" (in PST)

Positive UTC offset (eastern) zones would be even worse (the + separator
would be missing).

SlyEdit: Now using msg_area.sub[code].settings to check for posting with real...

See merge request !377

So move to nopen.h

Move the nopen-specific constants from sbbsdefs.h to nopen.c

This helps svdmodem to use findstr->nopen without more sbbs/smblib deps

... especially around incoming connection acceptance, blocked-IPs/hostnames

DDMsgReader: New configurable colors in the theme file for the indexed newscan menu header text: indexMenuHeader, indexMenuNewIndicator, and indexMenuNewIndicatorHighlight

See merge request !376

Eric Oulashin authored 1 year ago and Rob Swindell committed 1 year ago

DDMsgReader: New configurable colors in the theme file for the indexed newscan menu header text: indexMenuHeader, indexMenuNewIndicator, and indexMenuNewIndicatorHighlight

Many searches are done (e.g. in the mail server, QWK import) for either of 2
strings in single file or list, so let's optimize that to a single iteration
through the file/list. This should reduce some redundant file I/O.

I do find this API a little confusing with the filename or list at the end
of the argument list, but kept it consistent with the existing single string
findstr functions (which are now just wrappers for the new 2-string flavors).

I noticed during this update that findstr() did not share the same behavior
as findstr_in_list() (feature added in commit f08f2137) whereby if all the
patterns were negative searches (beginning with '!'), then *all* the
negative matches would have to be successful (not just the first) for the
function to return true. So now findstr() behaves like findstr_in_list()
in this regard.

I also added some optimizations to findstr_in_string().

Fix grid layout

See merge request !375

Using "Warning" log levels more for things that the sysop might be able to do
something about. If it's just an input data validation (from a random TCP/IP
client), use "Notice" log level instead.

The terminal server log output is still the odd ball.

The time span over which consecutive failed logins are attempted is important