Throttle bogus command sending clients (one second per bogus command, accumulating).

 term 0087 TLS ERROR 'Unexpected <Unknown type> (24) packet, expected application_data (23)' (-1) popping data
 message repeated 492 times: [ term 0087 TLS ERROR 'Unexpected <Unknown type> (24) packet, expected application_data (23)' (-1) popping data]

When using TLS with a JS Socket object, if there was any kind of data error,
the recvline() method would return a blank string rather than null/undefined.
nntpservice.js just loops when it receives a blank string, so this caused an
infinite loop (with disk-filling error log messages).

First change: if no data has been received (i == 0) and there's any kind of
receive error or timeout or disconnection, just return null. And not undefined,
but null (!) like in v3.15 (before the great JS engine update of 2000-mumble).
Also, there appeared to be a JS_RESUMEREQUEST call missing in the TLS error
return case - so that's another bug fixed.
Commented on the magic return values for js_sock_read_check()
and js_socket_recv().
Simplified js_sock_read_check() return value a tad: let the caller decide if
they want to do something special based on the value of 'i'.
Added some comments to make this code more readable.

We are now no longer treating the different error return values (0 and -1) from
js_socket_recv() special in this function, but we dont' treat them special in
any of the other calls in this file/object either, so that seems to be the
norm.

Deuce really wanted to pass 1000 as a value here (use 1 instead). I don't
know if this was an observable problem or not, but it certainly *looks*
like a bug.

This may resolve Dumas Walker's issue with cross-domain TIC forwarding.
This should really use the value from BinkpSourceAddress, but that would
mean renaming that key and including it in the TicITCfg object, or
creating a new SBBSEchoCfg object method or something, and I don't want
to mess with the sbbsecho.ini format.

first white-space character encountered.

'content-disposition' filename parameter is not terminated with a double-
quote or semi-colon character.

Added version for Bill McGarrity: for each linked-node, a preferred
local address (AKA) can be specified to be used as the source address
when creating packets destined for that linked-node. If no local address
is specified, the previous (best match) logic is used: find an AKA that
has the same zone and net as the destination address, if none found, use
the first address with the same zone.

of the user record is going to fail anyway. *this* explains a lot of
instances of the user.dat file being open concurrently, at least one per
active thread with a JS context.

user data is thusly cached - set the 'cached' property member to TRUE. This
prevents an unnecessary re-read of the user file and the leaving the user file
(user.dat) open, at least for JS contexts that contain a "user" object. I don't
think this explains the "too many open files" errors, but it explains at least
*some* number of the user.dat open file descriptors.

to .msg file doesn't mean you should delete the file attachment! The .msg
file will still be pointing to that file and it needs to be there.
SBBSecho was silently failing to delete file attachments on my system, so
I didn't see this problem. Oops. Anyway, this explains Al's problem with
netmail attachments.

server log output/window.
Also added comment about an observed exception upon shutdown with regards to
the node_threads_running counter (protected int) being accessed after
destruction.

removed.

sbbs::lputs() will log the current user alias already, logline()->lputs() would
create log messages with the user alias twice.

attempted.

with email_sec.js:
line 65: TypeError: addr_list.indexOf is not a function

If yy <= current 2-digit year, yy is assumed to be from this century,
else it is assumed to refer to the previous century.

In the case of a two-digit year, run it through parseInt with radix 10.  On the off chance we look at a message area created from 2000-2009 this will help, I guess.
Go back to putting month and day through parseInt, but specify radix 10.  In some *cough* older JS interpreters, parseInt likes to treat any string beginning with 0 as octal.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseInt#Octal_interpretations_with_no_radix

Don't run month/day through parseInt.  On my system, parseInt('08') yields 0 while parseInt('8') yields 8.  Days/months < 10 end up being -1, which apparently doesn't bother the Date constructor.

by Ragnarok@DOCKSUD.

mail "To" and "From" header fields of the form: user name <user@addr> or
"user name" <user@addr> - the email.can filtering would not work

getsmsg() is now based on the current console column (!=0), not the current
node action.

hot key (Ctrl-P) handler.

Currently, it behaves nearly identically to the hard-coded C++ function,
but my plans are to intergrate the inter-BBS instant messaging functionality
in here to make it easier to send and reply to instant messages.

Install this module in SCFG->External Programs->Global Hot Key Events:
Global Hot Key             Ctrl-P
Command Line               ?privatemsg.js

console.getstr() so they can be recalled with the up/down arrow keys.

additional, optional, "history" argument - an array of strings that can
be recalled/scrolled using the up/down arrow keys. Currently, I just plan
to use this for netmail destination address recall, but it could be used
other places easily enough.

If the "GMT" zone is not specified by the client, presume the date/time
comparison values are in the server's local timezone. If the client and
server are not in the same timezone, this could lead to confusing behavior.

from a counter, which allowed 2 depths of nesting (any 2 hot key handlers)
to a bit-mask which disallows *any* hot key handler to be re-entrant, but
you can enter any of the *other* hot key handlers from any *other* hot
key handler.

Previously, for example, you could hit Ctrl-P to enter the private message
prompt and then Ctrl-P again to re-enter the private message prompt
(recusively) - confusingly, requiring 2 'Q'uits to get back to whatever
you were doing before you hit the first Ctrl-P. Been like this forever.
Now, while in the Ctrl-P (private message) handler, hitting Ctrl-P again
does nothing. But you can hit Ctrl-T, or Ctrl-K or any other global hot
key and it'll work but those in turn will also disallow recursion of their
own handlers.

the data dir here, we're using it to delete the data files! This explains
why sub data wasn't getting deleted when deleting a message group and
answering "Yes" to the "Delete All Data in Group" dialog.
Eliminated the "clearing ptrs" thing - not needed any more since the move
from ptrs/*.ixb to user/*.subs files.

- If an FTN Echo Tag is more than 25 chars, copy it to the newly created
  sub's "newsgroup" name
  (when exporting areas to echolists, use the newsgroup name for the FTN
  Area/Echo Tag field, if it's not blank)
- Copied the duplicate internal code logic from the importing file areas
  code - it works a lot better

With these changes I was able to successfully import 10247 areas from the
usenet group listing he sent me (with 10258 areas listed). The areas that
were over-written during import were due to the first 63 characters of the
newsgroup names being duplicated - sorry, that's the best I can do.