- Jan 14, 2025
-
-
Rob Swindell authored
uncrustify nl_split_if_one_liner setting
-
Rob Swindell authored
... using uncrustify mod_paren_on_return config
-
Rob Swindell authored
White-space changes only, exception being the rare insertion of NL before closing brace (couldn't find the option to disable that behavior). I excluded some header files (e.g. sbbs.h) since uncrustify seemed to be doing more harm than good there. I might just end up applying different set of rules to .h files.
-
- Jun 21, 2024
-
-
Rob Swindell authored
This is the proper way to manually-restore the most recently saved window (via the WIN_SAV mode flag to the list() method). I wanted something that was backward comaptible with earlier builds of SBBS, so just doing a magic thing when decrementing the save_num rather than adding a new method seemed the seamless way to do it.
-
- Jun 19, 2024
-
-
Rob Swindell authored
uifc option lists are always NULL-terminated string lists (not static arrays of char arrays, as is often used in other UIFC utils), so grow the ability to have blank options (list items). This was needed for fileman.js to accurately edit extended file descriptions that contain blank lines.
-
- Mar 05, 2024
-
-
Rob Swindell authored
This one has caught me up before, for the CTX constructors didn't actually accept any initial property values (as arguments). mlong even documented it this way at https://wiki.synchro.net/ref:uifc#javascript_interface And construted his input.CTXs this way (using all 0 values, which were ignored) in his xtrnmenucfg.js
-
- Feb 27, 2024
-
-
- Dec 31, 2023
-
-
Rob Swindell authored
Should calm the clang warnings reported by Deuce: e.g. passing 'char *[18]' to parameter of type 'const char **' discards qualifiers in nested pointer types
-
- Nov 07, 2023
-
-
Rob Swindell authored
Replaced _property_ver_list (array of numbers) with _property_ver_list (array of objects) with a "ver" and (optional) "desc" property. This solves the enumeration order problem with objects that have both manual and table-based properties. Object's property tables (arrays of jsSyncPropertySpec) can now (optionally) contain the property descriptions. For properties defined in this manner, there will never be another mismatch between ther name/type and description/version in the jsobjs.html (a problem has re-occurred several times through the years with nebulous work-arounds). We still use _property_desc_list arrays for additional (e.g. manually defined) properties in such objects or just objects that only use one method of property definition and are not subject to the enumeration order problem. Fixed numerous typos. Using more consistent terminology and HTML mark-up. Some beautification and enhancement of readability, but nothing too major.
-
- Oct 30, 2023
-
-
Rob Swindell authored
The CTX constructor arguments weren't documented Some blind beautification via HTML tags
-
- Oct 29, 2023
-
-
Rob Swindell authored
-
Rob Swindell authored
Also clarify (or try to clarify) that the maxlen argument is required if you want to specify any kmode flags.
-
- Mar 14, 2023
-
-
Rob Swindell authored
Mainly capitalization, but some typos and added details.
-
- Feb 20, 2023
-
-
Rob Swindell authored
Limited to 6 chars, yet some values are as long as 12 chars. Also, eliminates this warning from RELEASE builds (only) using gcc version 12.2.0 (Debian 12.2.0-14): js_uifc.c: In function ‘js_uifc_init’: sbbs.h:230:56: warning: writing 8 bytes into a region of size 7 [-Wstringop-overflow=] 230 | (ret)[JSSTSpos]=(char)JSSTSstrval[JSSTSpos]; \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ sbbs.h:242:9: note: in expansion of macro ‘JSSTRING_TO_ASTRING’ 242 | JSSTRING_TO_ASTRING((cx), JSVTSstr, (ret), (maxsize), (lenptr)); \ | ^~~~~~~~~~~~~~~~~~~ js_uifc.c:609:17: note: in expansion of macro ‘JSVALUE_TO_ASTRING’ 609 | JSVALUE_TO_ASTRING(cx, argv[1], mode, 7, NULL); | ^~~~~~~~~~~~~~~~~~ In file included from sbbs.h:255: /home/rswindell/sbbs/src/sbbs3/../xpdev/genwrap.h:77:20: note: destination object of size 7 allocated by ‘__builtin_alloca’ 77 | #define alloca(sz) __builtin_alloca(sz) | ^~~~~~~~~~~~~~~~~~~~ sbbs.h:228:43: note: in expansion of macro ‘alloca’ 228 | if(((ret)=(char *)alloca((*JSSTSlenptr)+1))) { \ | ^~~~~~ sbbs.h:242:9: note: in expansion of macro ‘JSSTRING_TO_ASTRING’ 242 | JSSTRING_TO_ASTRING((cx), JSVTSstr, (ret), (maxsize), (lenptr)); \ | ^~~~~~~~~~~~~~~~~~~ js_uifc.c:609:17: note: in expansion of macro ‘JSVALUE_TO_ASTRING’ 609 | JSVALUE_TO_ASTRING(cx, argv[1], mode, 7, NULL); | ^~~~~~~~~~~~~~~~~~
-
- Apr 04, 2021
-
-
Rob Swindell authored
PROP_CHANGES already handled in if() condition CID 33176
-
- Apr 01, 2021
-
-
Deucе authored
ARE YOU HAPPY NOW CYAN?!?!
-
- Mar 31, 2021
- Feb 16, 2021
-
-
Rob Swindell authored
-
Rob Swindell authored
-
- Feb 15, 2021
-
-
Rob Swindell authored
Reverted the SAFECOPY() NULL source-pointer magic "(null)" string thing as that caused a different Coverity issue. Explicitly check for NULL at the call-sites instead.
-
Rob Swindell authored
Reverted the SAFECOPY() NULL source-pointer magic "(null)" string thing as that caused a different Coverity issue. Explicitly check for NULL at the call-sites instead.
-
Rob Swindell authored
Hopefully not introducing any bugs in the process.
-
Rob Swindell authored
Hopefully not introducing any bugs in the process.
-
- Jan 30, 2021
-
-
Rob Swindell authored
Stop lying. Programming is hard enough already.
-
- Jan 29, 2021
-
-
Deucе authored
Now the default bar is INT_MAX, so it always gets corrected when left as default. This is good.
-
Deucе authored
So here's what we're doing now... we set bar so that the first item shown in the menu is the lowest index possible that still shows cur. bar is therefore calculated as the displayed item count minus the distance from cur to the end of the list. Yeah, that's the easiest way to explain it.
-
Deucе authored
-
Deucе authored
-
Deucе authored
scrn, showbuf, timedisplay, bottomline, getstrxy
-
- Nov 28, 2020
-
-
- Oct 15, 2020
-
-
Rob Swindell authored
-
- Sep 13, 2020
-
-
Rob Swindell authored
bool (JSVAL_FALSE), not number (JS_FALSE).
-
- Aug 16, 2020
-
-
Rob Swindell authored
-
- Apr 12, 2020
-
-
rswindell authored
-
- Apr 01, 2020
-
-
deuce authored
-
- Feb 20, 2018
-
-
rswindell authored
-
rswindell authored
-
rswindell authored
valid lvalue. In all the use-cases, the variable is a stack variable going out of scope anyway, so don't bother with nullification.
-
rswindell authored
HANDLE_PENDING() contains a return, so it's theoretically possible that the memory allocated by the previous JSVALUE/STRING_TO_... allocation could be leaked. So now we pass an optional pointer to HANDLE_PENDING() which will call free() on it if it's not NULL, and then sets it to NULL for good measure.
-