Made a fix for the refactored theme config reading code in much of the Digital Distortion tools

See merge request !294

There's no good argument for this aside from "it feels more right".

It's gotten too crashy lately.

Properly initialize sixel mask width/height.
Free sx_mask->bits when finished.

These were broken by the PPM feature commit 4975b416

As Deon pointed out:

I saw that smbactive was removed recently (96a92435), but a quick search of
code, sees reminants in GNUmakefile and other files, which I'm wondering is a
cause of the problem...?

This mirrors commit 0748cc1e about a year ago that optimized window
dragging, and performs basically the same check (removed a week ago
with commit b4ce023c)

Now that bitmap_drv_request_some_pixels() just calls
bitmap_drv_request_pixels(), there's no point in calling expose_rect()
when ev->xexpose.count isn't zero.

- Only call cb_flush() if a new rect was queued.
- Ensure bitmap_drv_request_some_pixels() is only called once in
  response to an expose request.

This should fix issue #565.

Also, do not try to display frames where the scaled height or width
is less than the frame bitmap height or width.

sdl_getscaling() does not require vstatlock.  Move it out.

DD area choosers: Refactored/simplified the code for reading the configuration file

See merge request main/sbbs!292

DDFileLister: Theme configuration files can now just have the attribute characters without the control code. Refactored the code that reads the configuration.

See merge request main/sbbs!293

Eric Oulashin authored 1 year ago and Rob Swindell committed 1 year ago

DDFileLister: Theme configuration files can now just have the attribute characters without the control code. Refactored the code that reads the configuration.

SlyVote: Fix for error when quitting/aborting out of choosing a different sub-board. Refactored ReadConfigFile().

See merge request main/sbbs!291

DDMsgReader: Settings for being able to read deleted messages now apply to personal email (not just sub-boards), and not just appearing in the message list. (SCFG > Message Options > Users Can View Deleted Messages)

See merge request main/sbbs!290

Eric Oulashin authored 1 year ago and Rob Swindell committed 1 year ago

DDMsgReader: Settings for being able to read deleted messages now apply to personal email (not just sub-boards), and not just appearing in the message list. (SCFG > Message Options > Users Can View Deleted Messages)

SlyVote: Fix for error when quitting/aborting out of choosing a different sub-board. Refactored ReadConfigFile().

Currently useful only in GDI and SDL modes.  The external scaling
method is likely lower CPU utilization and may or may not look
better.

All bitmap drivers now support arbitrary scaling, and the scaling
factor is a double, allowing arbitrary window scaling in all bitmap
modes (making nelgin happy).

While we're here, fix bugs in horizontal interpolation and X window
resizeing.

Not at all approaching functional yet.

No functional change.

The first commit of this feature would leave the base corrupted for a couple
of reasons (.sha file wasn't opened, using modified header when re-writing the
old header to set the DELETED attribute). Both fixed.

... rather than just failing silently with a special return value
(e.g. false).

When sending a user-to-user file transfer, SBBS (since v3.19) will check that
the file recipient will be able to download it (e.g. doesn't have restrictions
preventing it) and this was failing for most (non-sysop) recipient users since
they wouldn't normally meet the "access restrictions" of the user directory
(by design).

The old "illegal header length increase" error goes away and now
smb_putmsghdr() will re-allocate a header if needs to be moved to accommodate
new header fields or header fields with increase data lengths.

We can consider getting rid of the MsgBase "expand_fields" concept now.

This fixes issue #404

So use js_argc() to report an error if there's fewer than 1 argument, but
don't just fail silently when 2 arguments are provided.

Avoids crash when adding a msg to a non-sub-board msgbase.

It's possible to use savemsg() (from JS MsgBase.save_msg()) to add a message
to a message base that's not a sub-board (not configured in SCFG->Message
Areas and not the "mail" base), but in that case, savemsg() would dereference
an invalid sub in the scfg->sub array and crash. So use is_valid_subum()
to insure the subnum is a valid sub before using as an index.

Nonrelocatable const data goes in __TEXT,__const apparently.
I could put it in __DATA,__const and get an entry in the GOT, by
why bother?

If/when anyone wants this functionality again, write a short JS util.
For reference:
https://synchro.net/docs/utility_reference.html#SMBACTIV

This fixes issue #384.

This should fix issue #559, for example:
  Content-Type: multipart/alternative;
    boundary=mk3-ebfa33c1cd454cc2b1c618f5d74b41af; charset=UTF-8

We were assuming all boundary parameter values are quoted (apparently not
true, see https://www.rfc-editor.org/rfc/rfc2046#section-5.1.1) - so support
non-quoted boundary values which also may have a semicolon delimiter.

Also, truncate any white-space from a boundary value (shouldn't be there per
RFC2046).