We were just trusting that the error strings would be shorter than 256 (usually), but since we're including paths and strerror() results, we really have no control over the length of the error strings. So enforce some healthy boundaries. This could explain the crashes that Divarin of Mutiny is seeing with SCFG on WinXP or maybe it was the truncsp(strerror()) stuff that was just removed as well. We'll see...

Its a terrible idea to modify the return value of strerror() on any platform. strerror() can (and often does) return immutable string constants - don't try to modify that string even if it does end in trailing white-space (find another solution to that). This change only affects non-*nix builds since we were already doing the right thing for *nix.

Some old/unsupported FidoNet software (NetMgr? Squish?) reportedly parse addresses from MSGID control/kludge lines in NetMail messages to determine the source and/or destination address. This is clearly a bad idea for a lot of reasons, but to improve compatibility, let's not include the message number (or an '@') in the origaddr field for NetMail messages. This does slightly increase the chance of a duplicate MSGID being accidentally generated if the "mail" base is renumbered. No change for EchoMail MSGIDs (where dupe detection and threading still benefit from the additional entropy).
For Watchman.

<@Deuce> Just saying that if someone does the work of exit_code = {thing: function(x) { return secretsauce }); exit(); they should get away with it.

Don't use the "exit_code" property value as the return value of js.exec() unless it's a number. As reported by mlong (thanks).

Also, "exit_code" was being set to null (instead of void/undefined) in js_PrepareToExecute(). I think this was just an oversight or typo by Deuce from his commit of 5 years ago (f3256d81). Since we're comparing exit_code with JSVAL_VOID in other places to determine if it was actually set, this appears to be a long standing bug.

Update install-xtrn.js, make it apparent that debug mode does not install the...

See merge request !76

Update install-xtrn.js, make it apparent that debug mode does not install the door. Also do not recycle in debug mode (nothing was installed). 

This script had some funky work-arounds for the previous behavior, so adjust
them to recognize null input from the user. This fixes issue #201
reported by Ragnarok.

SBBSecho v3.12 exports the originating system's BBSID via a new
"BBSID" kludge and this allows avatar lookups (e.g. of FTN-posted
messages) using this solution.

Also, support MD5-obscured name (i.e. real name) avatar lookups.

This enables Avatar displays on real-name-only networks without leaking
real names into the SYNCDATA sub.

If the -realnames option is used, the unobscured full real names are
exported (as before).

If the (new) -aliasonly option is used, even the MD5 digest of users'
real names is left out.

Update overkill.ini - add ver 1.10 and 1.11

See merge request !73

M: and P: lines cannot include an address to bind to with ircd.js.

Needed for CIOLIB builds.

3rd party install files for operation: overkill ii

See merge request !72

dpoker needs a little work first (can't find SDL.h).

This was initially just done for lfexpand(), but then I realized there were a
lot of these string processing functions that just checked for VOID
(undefined) argumnet value, but not null.

When a user logins to the FTP server concurrently, this creates a
race condition with an/the other FTP session that may be creating/
downloading a QWK packet. On Vertrauen, this results in the
occasional error removing the file since it was removed unexpectedly:
!ERROR 2 (No such file or directory) in main.cpp line 2747 (event_thread) removing "/sbbs/data/pack1111.now" access=0

xtrn install lore

See merge request !70

Reported by Night Stalker (INTERNAL)
Most likely some unexpected content in sbbsecho.ini.

At the request of WitNik (BGGRSCYN)

For deon's use with Docker:
When creating new nodes (after node 1), derive the new node directory from node 1's configured directory if possible (e.g. it has a '1' in it). So if Node 1's directory is /blah/bbsdir1, then node 2's directory will default to /blah/bbsdir2. When creating node 1 (the first node), it still defaults to "../node1".

(e.g. when run as a timed event) - this bug was introduced in the "Fix sub[] property setter" crash bug fix 2 commits ago.
This fixes the "TypeError: sub.code is undefined" error.