DDMsgReader: Deleted messages can now be un-marked for deletion from the message list with the U key (if the user has delete permissions). Also, the reader now honors the system setting for whether users can view deleted messages.

Eric Oulashin authored 2 years ago and Rob Swindell committed 2 years ago

DDMsgReader: Mouse click support for the bottom help lines in scrollable mode (thanks to help from Nelgin)

Fixed a few errors (a couple related to "use strct", and a couple new errors related to deleting a message, upvoting, and viewing tallies).

DD file area chooser: Lightbar mode fix for not actually moving to the user's selected directory when directly choosing a directory in their library

Eric Oulashin authored 2 years ago and Rob Swindell committed 2 years ago

DDMsgReader: Fix for undefined bottomMsgIndex when going to a message in the lightbar list, and strict mode fixes

Graphic is now only used when using the scrollable interface. Also, when creating the Graphic, now subtracting 1 from the reading area height to avoid making the Graphic one line too tall to avoid unnecessary scrolling.
When saving messages with ANSI codes, Graphic is only used if the message has any ASCII drawing characters. (not sure if this really matters much though).
Also, applied "use strict" and made some changes as necessary.

Synchronet uses "extended normal" mouse reporting for mouse support
(e.g. menu/display file clickable "hot spots"). Many of the JS scripts
that predated Synchronet's own internal mouse support would send their
own mouse-reporting enablement and disablement ANSI sequences and the
terminal could become out of sync with the expectations of the script
(i.e. it would not necessarily disable the mouse modes that had been
set by SBBS before enabling its own preferred mode).

And some scripts (e.g. Synchronet Minesweeper) use a mixture of Synchronet
hotspot support and direct mouse click coordinate reporting, so it was a
mess going between different mouse reporting modes at different times in the
same script.

This all came to light as a result of the fix for issue #412: using mouse
button releases rather than presses to trigger a hotspot.

So mouse_getkey() now has as a separate "release" property it sets in the
return value. Right now its always the opposite of "press", but I can imagine
some mouse tracking modes where movement might be reported with neither a
button press nor release event.

Anyway, Nelgin, give this a try and see if it resolves the issues you were
reporting in IRC with avatar chooser mouse support.

DD file area chooser fix: Listing libraries without first listing directories within the user's current library (with directory collapsing) works again

DDMsgReader: When doing a text search, it now ignores the user scan configuration for sub-boards, to ensure it will show any results of the text search.

DDMsgReader Version 1.49 - Refactor: Simplified saving a message to BBS machine for sysop (as-is, less processing); removed attachment stuff for pre-Synchronet 3.17; moved hasSyncAttrCodes() to attr_conv.js because that's where it needs to be.

allowing the user to choose the file directory within their file library.

DD message area chooser: Updated to try to prevent the error "this.subBoardListPrintfInfo[pGrpIdx] is undefined" when only choosing a sub-board within the user's current message group.

Some antivirus scanners (such as ClamAV) need a command line parameter to pass the file permissions descriptor to the scanner.

DD message area chooser: Updated to try to prevent the error "this.subBoardListPrintfInfo[pGrpIdx] is undefined"

Eric Oulashin authored 2 years ago and Rob Swindell committed 2 years ago

Updated Digital Distortion Upload Processor so that the scanning works properly in Linux (directory permissions)

Some shells log every character the user types (e.g. 'X' for external programs)
so we need a newline before the logged DOORSCAN line to be parsed correctly.
From Apam (POSITRON)

The extra strength bug fix needs a new version number.

You get str_gained, not str. :(

When extended file descriptions are enabled, the file date is now shown
with the file description on the last line.

A user disconnecting while running tw2 would just result in an infinite loop
checking node status and waiting for the user's allowed time to run out (which
may never happen) or for the server to be locally terminated.

This has been happening for years on Vertrauen. Finally now I see why.

Now calls bbs.edit_msg() to edit an existing message (if that function exists - It
was added in Synchronet 3.18).

DD area choosers: For message sub-board/file directory collapsing, if there's only one sub-group/sub-library, then it won't be collapsed
DD area choosers v1.23: For message sub-board/file directory collapsing, if there's only one
sub-group/sub-library, then it won't be collapsed, as that wouldn't be very useful.

Added back a few functions that were accidentally removed (which weren't moved to attr_conv.js)

Fixed broken code when taunting opponent
Fixed broken code when aborting after waiting a long time for opponent
to respond.

ddfilelister version 2.05a: Fix for "fileDesc is not defined" error when displaying the file
description on the main screen.  Also made a small refactor to the main screen refresh function.