Skip to content
Snippets Groups Projects
  1. Sep 25, 2023
  2. Sep 24, 2023
  3. Sep 23, 2023
  4. Sep 22, 2023
    • Rob Swindell's avatar
      Fix "error 13 opening" files when using init-fidonet.js · 2dc35092
      Rob Swindell authored
      I finally reproduced this issue myself on a fresh install on Windows.
      
      We needed explicit file closing here as going out of scope doesn't immediately
      finalize (and close) a File object. That may not happen until garbage
      collection and thus prevent subsequent re-opens of the same files, so always
      close() your files.
      
      init-fidonet.js calls install-binkit.js which uses cfglib.js, so that was
      a source of these errors too.
      2dc35092
  5. Sep 21, 2023
  6. Sep 20, 2023
    • Rob Swindell's avatar
      Log a critical error message if a node is WFC, but its socket is still in use · 97e74166
      Rob Swindell authored
      This should avoid/work-around issue #630
      
      Nelgin's terminal server log indicated that the node's configuration was being
      reloaded for a new client connection (which doesn't normally/always happen,
      only when there's been a config file change or a node "rerun" requested),
      while there was still a user online using that node. This would explain the
      segfault (configuration fields being freed and reallocated).
      
      The node_socket[] array indicates when a node thread is actively servicing
      a client, so it should contain INVALID_SOCKET for the any node's that WFC.
      If it doesn't, that means something/someone changed the node's status value
      to 0 (WFC) in the node.dab file while the node was still in-use. Let's not
      crash in this case and rather just log the message and give the client the
      next available node (if any).
      97e74166
  7. Sep 18, 2023
    • Rob Swindell's avatar
      Add more detail (e.g. line number) to various "error opening" log msgs · c6f4a39c
      Rob Swindell authored
      Some of the errors could be pretty vague since they looked the same and
      we were depending on the path/file attempted to be opened in the log msg
      to clue us into what exactly was being attempted. But some of these file
      paths are sysop-configurable, and they can put unexpected things in there
      that make it difficult to determine exactly what file was trying to be
      opened and for what purpose. This should help a little bit.
      c6f4a39c
Loading