DDFileLister: On start, if console.aborted is true (due to the user pressing Ctrl-C, etc.), then return -1 to stop a file scan in progress.

See merge request !362

Eric Oulashin authored 1 year ago and Rob Swindell committed 1 year ago

DDFileLister: On start, if console.aborted is true (due to the user pressing Ctrl-C, etc.), then return -1 to stop a file scan in progress.

js_init() failures are now logged with a critical error level (instead of just
"error").

js_execxtrn() now returns -1 if a JS context can't be created. This eliminates
redundant error messages from calling js_execfile with a NULL context.

These functions were causing enumeration issues with JSDOC builds (before the
recent refactor that fixes that enumertion order problem), but
really these calls should've been conditional anyway.

Just a blank string instead.

Ctrl-A? is a conditional new-line sequence (often used in prompts).

This was a feature in yesnobar/noyesbar.bin and missing in this new JS
port. Oops.

DDMsgReader: Indexed mode: Added 'mark all read' for a sub-board with the R key. Fixed message list colors for messages to the user in the message lists. Fix for continuous newscan. Fix for DDLIghtbarMenu numbered mode item text in traditional UI.

See merge request !361

Eric Oulashin authored 1 year ago and Rob Swindell committed 1 year ago

DDMsgReader: Indexed mode: Added 'mark all read' for a sub-board with the R key. Fixed message list colors for messages to the user in the message lists. Fix for continuous newscan. Fix for DDLIghtbarMenu numbered mode item text in traditional UI.

Replaced _property_ver_list (array of numbers) with _property_ver_list (array
of objects) with a "ver" and (optional) "desc" property. This solves the
enumeration order problem with objects that have both manual and table-based
properties. Object's property tables (arrays of jsSyncPropertySpec) can now
(optionally) contain the property descriptions. For properties defined in this
manner, there will never be another mismatch between ther name/type and
description/version in the jsobjs.html (a problem has re-occurred several
times through the years with nebulous work-arounds).

We still use _property_desc_list arrays for additional (e.g. manually defined)
properties in such objects or just objects that only use one method of
property definition and are not subject to the enumeration order problem.

Fixed numerous typos.

Using more consistent terminology and HTML mark-up.

Some beautification and enhancement of readability, but nothing too major.

We don't need the carriage returns and they cause Git warnings:
warning: in the working copy of 'src/sbbs3/text.h', CRLF will be replaced by LF the next time Git touches it

DD Message Area Chooser: Fix for a copy & paste error - Added the canViewDeletedMsgs() function

See merge request !360

New: ddmr_cfg.js is a menu-based configurator for Digital Distortion Message Reader. Also, refactored slyedcfg.js a bit to make it a little simpler.

See merge request !359

New: ddmr_cfg.js is a menu-based configurator for Digital Distortion Message Reader. Also, refactored slyedcfg.js a bit to make it a little simpler.

This is a menu-driven configuration program/script for SlyEdit.

See merge request !358

DD Msg Reader: Mark personal email as read if the user is just reading personal email

See merge request !357

Fixes issue #670

The get_lang_count(), get_lang_list(), and get_lang_desc_list() functions are
more or less ported from load_cfg.c. If we ever need these in any other JS
files, they should be moved to a load-lib.

Re-synchronized this code with sbbs_t::maindflts():
- Don't accept keys for settings we didn't display
- Remove support for Auto-Login by IP address (chopping block feature)
- This is even a tad better as a translated (to another language)
  UserDefaultsHdr string (if/when there is one) would be displayed
  immediately upon a new language file being selected

Fixed a bug where the user online's command shell was used as the default
rather than the selected user's command shell (thisuser).

Fixed a bug where 'None' was hard-coded rather than use the text.dat string.

No longer needs/loads text.js (use the hard-coded string IDs in sbbs v3.20)
for a little speed boost.

New method: bbs.load_user_text() to load/reload user's language file. The
user's select language file (if there is one) is automatically loaded upon
logon to the terminal server, but if the user changes their language
(e.g. via user_settings.js), we needed a way to force re-load of the language
text. This is the way.

bbs.text() now accepts an optional second (bool) argument that if true, will
return a string from the default language strings (in text.dat), and not a
string from any alternate language files (ctrl/text.*.ini) that might've been
loaded. This allows user_settings.js to always get the name of the default
language string (LANG), e.g. "English".