Wrong arguments passed to loadfiles() caused only index to be read.

As reported by plt via irc:
ERROR (smb_putmsghdr illegal header length increase: 70 (1 blocks, 0 hfields, 0 dfields) vs 0 (0 blocks)) removing file from database

Also, replace old CVS rev with Git branch and hash.

And for everyone: use delfiles.js instead (e.g. with jsexec).

Or detail level is MAX.

Sorry for the impending imminent merge hassle Deuce!

Do this in JS and use JSON for format instead of .ini.

The old "content" array property goes away.

<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> append key into keybuf: 4E (N)
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> Executing external: /sbbs/exec/sexyz 14 -Telnet sz /mnt/disk1/dl/COCO/AGI/agi-xmas.zip
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> sexyz: Synchronet External X/Y/ZMODEM  v3.0  master/62b59062  Copyright Rob Swindell
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> sexyz: !File skipped by receiver
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> sexyz: !File Skipped
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> sexyz: !0 Aborting Transfer (Sending ZABORT)
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 !ERROR 11 receiving from socket 14
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 input thread terminated (received 365 bytes in 35 blocks)

Not sure why this isn't happening for other sysops - perhaps plt was spying on the node?

This was really slowing down the upgrade_to_v319 and there's no current consumer of the data.

Consider adding back in JSON format later or just leave it to JS things to use for JSON-formatted metadata.

Don't use iniSet* since we know we're not updating existing ini entries. Use strListAppendFormat() instead.

The fread() usage here did not need "addressing" (Commit 27fb52a1).

This caused messages posted via smbutil to be short (e.g. 0 or 1 bytes
in length). Reported by Accession via Idle Relay Chat.

Also, don't call strlen() on msgtxt which could be NULL, causing segfault
in final printf() callin in postmsg().

This should address issue # 261.
Before April 19, 2016, area-linked nodes were required to be listed as nodes in sbbsecho.ini:
http://cvs.synchro.net/cgi-bin/viewcvs.cgi/src/sbbs3/sbbsecho.c?revision=3.6&view=markup
I'm not sure why the change was made to only require that there be a wildmatch for each area-linked node. So just make it a configuration option. <shrug>

Also removed the trailing "..." for every top level menu item in echocfg.

It's very tricky to defeat the auto-pause to have your own custom prompt at  rows-1. So going back to having  a blank line before the batch prompt.

If a sysop wants a *blank* line before the batch flag prompt, they can put that (or a conditional blank line, even better) in their text.dat (BatchFlagPrompt). For now, I'm thinking no blank line before the prompt is better use of the screen.

as get_ini_globals() will de-ref the 'interfaces' element. CID 331352

Some archives contain exactly the same files as others, but in a different order. Believe it or not.

More support for moving backwards through file searches/listing types.

e.g. when using the JS FileBase.update() method

This will cause archive file contents to be re-captured/added

Finally document the file-meta-object properties now that things are solidifying.

This will allow fast/easy display of archive contents without actually reading the archive files.

Introduces some new functions:
- list_archive_contents()
- smb_adddfile_withlist()

A new SMB convenience variable ("tail", aliased as "content" for a file).
A new file detail level ("file_detail_content", exposed in JS as FileBase.DETAIL.CONTENTS) which adds a "content" array property to file metadata objects for JS FileBase.get().

Files already added to the new filebases won't have this archive content automatically - I'm looking into that now (likely a new or updated JS script to run).

According to  Lupine Furmen (FURFOL):
It says in the help that the field is used for both the Newsgroup name AND the
Fido Echo-tag.

These really should be 2 different fields.

Now, the echo/area tag is usually configured in the area file (areas.bbs) and so does not need to match *any* string configured in SCFG. But since an area file *can* be generated from SCFG (Export Areas option) and its possible to use SBBSecho withOUT an area file at all, then it's possible someone would like to have their FidoNet-style area tags configured different from any other strings related to a sub-board (e.g. newsgroup name) - why? I'm not clear, but there it is: another string that  a sysop can set (or not).

Since I'd recently added an area tag field per directory for use by hatchit.js, this does create some logical symmetry. And there were enough free bytes per-sub in the msgs.cnf, so why not.

Especially now that now all files even have descriptions (e.g. when super long filenames suffice).

Save the user's "misc" flags to the userbase when they use the 'T' command from the batch flagging prompt. Without this change, the option would automatically revert if/when the user record was re-read (which can happen at any time).

e.g. file.cpp line 239 (removefile) removing "filename.zip" access=-203 info=smb_freemsgdat reading allocation record at offset 1108

Also, if there is an error removing the original file from the filebase, don't proceed to move the actual file (and log a successful move).

Display the batch flag letter with the same color as the filename, but inverted intensity. The batch flag shouldn't stand-out (be bright) anyway, but the main reason is because I'm changing the default file description attribute to be lightgray instead of dark green.

CID 33567

CID 33320 and 333321

This looks like a 20-year-old copy/paste bug. CID 33168.

Fixes CID 33724.

Fixes CID 33498

This is pretty convenient and handy (rather than having to use &E or the equivalent command from the file xfer menu and then re-list files).

Fixes the link failure when sauce.o didn't need to be rebuilt.