Skip to content
Snippets Groups Projects
  1. Jan 11, 2021
  2. Nov 22, 2020
  3. Nov 17, 2020
  4. Oct 22, 2020
    • Rob Swindell's avatar
      We must explicitly set _FILE_OFFSET_BITS=64 to use Linux OFD locks · caec4ea8
      Rob Swindell authored
      The Linux lock() implementation in xpdev/filewrap.c requires that
      _FILE_OFFSET_BITS is set to 64 or else OFD (sane) locks are not
      used on Linux, defaulting back to the crazy per-process file region
      locking of Linux of old. This was done in this commit:
      http://cvs.synchro.net/commitlog.ssjs?99999#39639
      because:
      https://patchwork.kernel.org/patch/9289177/
      
      but on 64-bit Linux, large file support is assumed and you don't
      actually need to define _FILE_OFFFSET_BITS, we're peforming this
      check for 32-bit Linuxes. Perhaps a check to see if sizeof(off_t)
      == 8 would have been better. However, this change enables OFD
      Locks for *all* flavors of Linux (not just 64-bit) - so that's
      better.
      
      Why do we care? Because using region locks on the same file in
      a multi-threaded program doesn't really work right on Linux without
      using OFD Locks. I saw this problem with receiving multiple
      simultaneous emails in the mailserver and getting smb_locksmbhdr()
      errors/failures when trying to save the message data or headers
      of the one or more messages every time GitLab would send email
      out to those whoe have opted-in to received email notifications
      upon gitlab.synchro.net activity.
      caec4ea8
  5. Aug 16, 2020
  6. May 02, 2020
  7. Apr 30, 2020
    • deuce's avatar
      Completely disentangle xpdev/xpbeep.c from conio/sdlfuncs.c · d3d10271
      deuce authored
      SDL audio should work from any thread, and on the platforms that care,
      SDL video is coddled appropriately.
      The only question is around SDL_Quit() in an audio-only build, but we
      can punt on that since the default builds will never do that... the only
      thing I'm aware of that could be broken that way is tone, which nobody
      likes anyway.
      d3d10271
  8. Apr 25, 2020
  9. Mar 20, 2020
  10. Aug 12, 2019
  11. Jun 28, 2019
  12. May 30, 2019
  13. Mar 09, 2018
  14. Feb 09, 2018
  15. Feb 03, 2018
  16. Dec 13, 2017
  17. Jan 13, 2017
  18. Sep 02, 2015
  19. Aug 22, 2015
  20. May 12, 2015
  21. Apr 18, 2015
  22. Feb 07, 2015
  23. Feb 06, 2015
  24. Oct 06, 2014
  25. Apr 28, 2014
  26. Apr 04, 2014
  27. Apr 03, 2014
  28. Mar 28, 2014
  29. Feb 14, 2014
  30. Feb 13, 2014
Loading