"I can't think of a reason I'd want scfg and echocfg to remain windows (gui) programs"
                                              -- Digital Man

While I'm here, hack up some SyncTERM vcxproj stuff (which almost
certainly doesn't work, but since I can actually test it now, I
may as well try)

... or else any pending published messages aren't sent.

Some shell pwd implementations default to the "Logical" PWD, which
can contain symlinks.  The POSIX standard for /bin/pwd is to return
the "Physical" PWD with all symlinks resolved.  Some shells don't
support the -P option the the built-in pwd, so we don't want to
reply on that.

For some reason, we're redefining the PWD env variable which should
by the phyical path, but I'm not really interested in tracking down
all the windy history for this.

Basically, this bit me once, and now it's fixed.

It's unclear whether trailing whitespace is supposed to be significant or not
(FidoNet specs don't say), but I don't see any reason why "John Doe" and
"John Doe " should be considered unique senders or recipients. Remove any
trailing whitespace from message subjects too.

This change makes the trailing whitespace truncation in SMB hash functions
unnecessary (at least for SBBSecho-imported messages), but most (all?) other
message transports don't allow for this nonsense in the first place.

Log a warning message when either the "local" or "in-transit" flag has been
stripped from ("Sanitized") imported packed-messages.

Keyop reported a chksmb warning on a FidoNet message that contained the
'in-transit' attribute:
<Keyop> Message flagged as 'In Transit'     (?): 1
<Keyop> fidonet_fidosoft Message Base has Errors!

The message in question appears just to be a corrupted echomail msg coming
from HPT:
Sender           '56:43 '
To               Tommi Koivula
Subject          test
X-FTN-AREA       FIDOSOFT.HUSKY
X-FTN-TID        hpt/os2-wc 1.9.0-cur 2021-03-14

SBBSecho didn't use to convert/import the "in-transit" flag on imported
netmail or echomail messages, ... until commit 446ab0ef, which
was needed to support the TickFix robot. So now, let's just sanitize the
packed-message attributes a little sooner in the import process and log a
warning when such sanitization has taken place.

The notification of offline users was removed from the mail server 13 years
ago (commit 729eb16b) without a lot of fanfare or explanation. Add an
option for notification of offline users (in addition to online users) for
those sysops that want that behavior.

Use the userdat is_user_online() function in place of the getnodedat() loop,
which also wasn't considering nodes in "logon" status as having a user online.

Contrary to https://mosquitto.org/api/files/mosquitto-h.html#mosquitto_loop_stop, passing force=true is not enough for the mosquitto network thread to end, mosquitto_disconnect() must be called.

JSDOC fix-ups.

Mostly just bitfield->bit-flags.

A little more visiblity into the MQTT library (version, function return values)

Recently started truncating trailing whitespace from sender/recipient names
before calculating the CRC value (similar to what we do for message subjects
as of a year ago). To suppress errors when evaluating messages (with trailing
whitespace in sender or recipient namems) created or imported before this
change, use this new -N option.

And don't offset long(er) windows from edges to allow more options to be
on screen at once.

Tested with 50 column mode.

Fixes Windows build.

Right now, only supports publish, subscribe to come next.

Only included with the mosquitto lib support is enabled in the build.

No functional change, just a little clean-up.

ftouch(), semfile_signal(), and JS file_utime() would fail to update a file's access/mod times with errno=EPERM if not run as the file's owner. From "man utime":

EPERM times is not NULL, the caller's effective UID does not match the owner of the file, and the caller is not privileged (Linux: does not have the CAP_FOWNER capability).

So use a NULL times parameter value when updating to a file's time stamp(s) to the current time.

One of the benefits of the new .ini format config files. :-)

This increase introduced a few potential buffer overrun warnings (all writes
to smb_t.file ?)

... using snprintf() instead of sprintf()

Since we are now free()ing the opt[] items in bail(), I've seen heap
corruption core dumps after navigating the SCFG menus with some long
configuration items (e.g. timed events with max-length command-lines).
This heap corruption has been present for a long, long time, but not
detected since we weren't free()ing these heap-allocated items.
Increasing MAX_OPLN would have been a mitigation for this issue, but
using snprintf(opt[n],MAX_OPLN,...) is the better fix.

Copy/pasted (with little modification) from
https://synchro.net/docs/file_section.html#AdvancedOptions -> "Short Name:"

Some short names have specially predefined meaning and it's important to
include that detail here.

Unlike strip_ctrl(), does not remove any other control characters from string.

the Subject CRC calculation was changed in May of 2022 (trailing whitespace is
removed prior to calculation), so messages imported before this date/revision
of sbbs might be detected as having an invalid/mismatch Subject CRC. This -S
option can be used to suppress such errors (for Keyop).

Don't support /option syntax any longer in non-*nix builds (just -options).
Options are now case-sensitive (i.e. -S and -s are different options).
Bump version to 3.20.

As Deon pointed out:

I saw that smbactive was removed recently (719b7523), but a quick search of
code, sees reminants in GNUmakefile and other files, which I'm wondering is a
cause of the problem...?

... rather than just failing silently with a special return value
(e.g. false).

When sending a user-to-user file transfer, SBBS (since v3.19) will check that
the file recipient will be able to download it (e.g. doesn't have restrictions
preventing it) and this was failing for most (non-sysop) recipient users since
they wouldn't normally meet the "access restrictions" of the user directory
(by design).

So use js_argc() to report an error if there's fewer than 1 argument, but
don't just fail silently when 2 arguments are provided.

Avoids crash when adding a msg to a non-sub-board msgbase.

It's possible to use savemsg() (from JS MsgBase.save_msg()) to add a message
to a message base that's not a sub-board (not configured in SCFG->Message
Areas and not the "mail" base), but in that case, savemsg() would dereference
an invalid sub in the scfg->sub array and crash. So use is_valid_subum()
to insure the subnum is a valid sub before using as an index.

If/when anyone wants this functionality again, write a short JS util.
For reference:
https://synchro.net/docs/utility_reference.html#SMBACTIV

This fixes issue #384.

This should resolve CID 453850

My first idea was to have a per-external-program setting to enable input
translation, but Deuce suggested it would be better done in input_thread() and
after some thought, I agree. Translations are not done in data/file transfer
mode, so use the CON_RAW_IN console flag to indicate this condition. So even
JS console.getbyte() will return a translated char unless the console is set
raw input mode (this could be surprising behavior for some!).

I considered saving/restoring the console mode when performing a file transfer
but will leave that to a time when obviously needed.

This fixes issue #497 in automatic way (no option needed).