The /vfiles root uses the configured virtual paths as in the FTP
and web servers.  These paths should be shorter than the ones used
in /files, and also have the benefit of translating slashes so
users will not need to type a Big Solidus if they're trying to
type long lib or dir names.

This should speed up directory listings over higher latency links
by approximately 25×.

You're welcome nelgin.

This should fix the sftp hangs...
While FreeBSD will return EDEADLOCK when a mutex would deadlock,
Linux will do what I ask and deadlock.

Since we're not checking the return value of pthread_mutex_lock(),
this would go completely unnoticed on FreeBSD, resulting in the
mutex being unlocked early and all sorts of unprotected accesses
would happen, potentially doing crazy things.  On Linux it just
deadlocks, and taking a peek at the thread backtraces makes the
problem obvious.

So, point to Linux for making life more correct for people who
do incorrect things (locking without checking the return value).

I'd also like to thank nelgin, for sticking with me on this issue
and being my gdb puppet.

And really, this commit should be shared by all the contributors
who... 𝆺𝅥𝅮𝆺𝅥𝅮𝆹𝅥𝅯𝆹𝅥𝅯

This prevents the case where input_thread() accepts the sftp
connection and calls init_sftp(), then answer() does the same thing,
clobbering the previous state.

DDLightbarMenu: Fix for text & text column alighment issues with UTF-8 text

See merge request !417

DD File Lister: Fix for possibly no file description when adding to the batch DL queue. Also, fix for file description screen refresh (off by one column) for extended descriptions.

See merge request !418

DD File Lister: Fix for possibly no file description when adding to the batch DL queue. Also, fix for file description screen refresh (off by one column) for extended descriptions.

but does not yet have a session type.

Also, fix what appears to be a fairly blatant memory leak.

If there's an error setting the channel or getting the channel
type, give up on the session immediately.

In this case, just accept whatever we get info on as the "first" one.

Likely fixes #728

The search seems to be backward by default (at least when listing a
sub-board), so should look into that. But at least now you can find
replies that include a "re:" prefix easily.

Searching by thread should be added too.

If the SSH_ANYAUTH option is set, the server will accept the "none"
authentication method, and not even suggest the client send a
password or public key.

The client must still send a user ID, but we just ignore it
completely and don't even log it.

This blindly accepts whatever authentication the remote offers, but
does not log into the BBS, dropping the user at the login prompt
instead.

Closes #726

You're welcome Keyop.

The other 500 times are implied.

The reason the comparison was changed to <= 0 is to do an explcit
check that eliminates negative numbers rather than the implicit ones
with the greater-than checks.

It seems that GCC is concerned that we can't create a sftp_dirdescriptor_t
or sftp_filedescriptor_t?

Add initial support for SFTP

See merge request !415

SlyEdit DCT: Fix so that the quote window bottom border is drawn the full width, not 2 characters short (not sure why this started happening)

See merge request !416

SlyEdit DCT: Fix so that the quote window bottom border is drawn the full width, not 2 characters short (not sure why this started happening)

If user is being kicked off for being on "More than one node at a time", then
don't send a message to other any other nodes that the user logged-on
successfully (they haven't). Previosuly, it'd send messages to all the
lower-numbered nodes that were in-use (but not by the same user).

Reported by Nelgin.

User disconnection will trigger auto-terminate (eventually) as well. But only
in the terminal server.

JS console.inkey() and friends use this as the underlying function to get
input from the TCP socket.

This might address issue #725

Hoping Nelgin will let us know.

For some reason, I committed test code that commented-out the actual call
to js_IsTerminated() which avoided the unnecessary error log message. I guess
I was testing to confirm the change actually worked. <shrug>

Address this problem report:
<nelgin> Right but I'm getting a lot of "logged off" without ever having a "logged on"
<nelgin> Node 3: Keyop logged off 02/26/24 18:35:45
<nelgin> Node 5: Keyop logged off 02/26/24 18:36:39
<nelgin> There was never a login, so there can't be a logoff.
<nelgin> That would break the time-warp continium.
<nelgin> time-space whatever :)

This could happen when non-G-exempt user was kicked before logon completed due
to already being logged onto another node. This change should fix that.

(just a cosmetic change)

... when run from the BBS (terminal server)

If errno is 0, it's definitely no proividing anything of value here. Of
course, sometimes errno might be non-zero and still be unrelated to the error
message. <shrug>

For Nelgin:
!ERROR 0 (Success) in exec.cpp line 644 (js_execfile) compiling "something.js" access=0
<nelgin> I don't quite get why a successful execution is logged as an error

Resolve build warning about unused var

Also, resove a new gcc warning about signed/unsigned compares.