- Apr 24, 2018
-
-
deuce authored
-
rswindell authored
(e.g. warnings and errors). Also, stripped trailing white-space from many lines (editor setting).
-
rswindell authored
Terminal Server SSH ERROR 'Bad argument, parameter 1' (-1) ... from output_thread Don't set ssh_mode=true until the ssh_session has been created successfully. Also added some more debug output with regards to Cryptlib session number.
-
rswindell authored
parameter 1' (-1) ... from output_thread
-
- Apr 20, 2018
-
-
rswindell authored
Terminal Server SSH ERROR 'Bad argument, parameter 1' (-1) ... from output_thread The bbs_thread() sets the global/server sbbs ssh_mode to false and ssh_session to 0 (the "parameter 1" value used in the cryptlib function calls in output_thread) but was doing this without owning the ssh_mutex, so the output_thread had a race condition where it would check ssh_mode=true and then use grab the ssh_mutex and use ssh_session in a few cryptlib function calls. The fix for the bbs_thread() to grab the ssh_mutex before setting ssh_mode to false and ssh_session to 0 and have the output_thread() re-check the ssh_mode after grabbing the ssh_mutex and not call any cryptlib functions if ssh_mode was set to false while waiting for the mutex. The cause would have been more obvious if the various cryptlib error/log messages contained the cryptlib session ID value (which was 0 in this case).
-
- Apr 19, 2018
-
-
rswindell authored
WARNING. Also fixed a couple of typos in strings.
-
- Apr 18, 2018
-
-
deuce authored
switch to CP437 before any uifc stuff and everythings going to be happy.
-
rswindell authored
missing, but also now logging when renaming (or failing to rename) bad received .REP packet files.
-
deuce authored
-
rswindell authored
packet errors, no need to save such REP packets as .bad files.
-
deuce authored
-
deuce authored
This should fix the issue with non-CP437 fonts reported by Kirkman.
-
rswindell authored
error messages (in the POP3 server) as the msg.hdr.number is zeroed by smb_getmsghdr() and potentially invalid when returning an error.
-
rswindell authored
error log message as the header is zeroed in this function and thus the message number previously read from the index, lost (zeroed) and useless.
-
deuce authored
screen of rows.
-
rswindell authored
*nix-builds (for stdio WWIV doors).
-
- Apr 17, 2018
-
-
rswindell authored
Use drive mappings (e.g. D:, F:, G:, H:) rathe than absolute paths to node_dir, ctrl_dir, data_dir, and exec_dir in drop files. Also: fixed what appears to have been a copy/paste error in the node_dir and ctrl_dir mapping to Win32-shortnames for non-native doors on Windows.
-
rswindell authored
attachment is attempted but unsupported.
-
rswindell authored
- writes outbound netmail to SMB rather than FTS-1 Stored Messages (*.msg) this means you must have SBBSecho v2.30 or later in order to export FTN netmail (for file attachments, you'll need SBBSecho v3.04 rev 3.78 or later) - removed support for the now deprecated "default address" feature (nowadays, people are much more likely to gate FidoNet over Internet rather than the reverse!) The QWK-to-NetMail function still needs a similar overhaul.
-
rswindell authored
(e.g. "C:"), skip it on *nix and if the path contains backslashes, convert to forward-slashes (for all OSes). This resolves an issue of sending a netmail file-attachment that was created on a Windows/MS-DOS type system and then scanned/exported on a *nix system. The FTN "stored message" convention is to have the full path of the attached file in the message subject. Hopefully nobody wants to use outbound directory names beginning with "x:" on *nix. :-)
-
rswindell authored
included an "old-style" (not MIME-encoded) file attachment (where the file path is in the subject and the FILEATTACH aux-attribute flag is set), the corresponding netmail attribute flag would not be set in the stored msg (*.msg) file. Also simplified the create_netmail() function prototype/usage, removing the "file_attached" argument (use the hdr.auxattr instead).
-
- Apr 16, 2018
-
-
rswindell authored
-
rswindell authored
1: Wrap SSH cryptDestroySession() calls in a wrapper that tracks the number of open sessions and logs errors upon failure (and remaining session count). This is how I found the SSH session leak in sbbs_t::hangup(). Also found multiple cals to SSH_END() which were invalid (no session to destroy) and removed them. 2: If errors are detected when unpacking a REP packet, save the .rep file (in data/file/<filename.rep>.<timestamp>.bad) for later inspection. Also added some VOTING.DAT debug output (to be removed later). Trying to the get to the bottom of the "smb_addvote thread_back field missing" errors.
-
rswindell authored
pause and CLS after.
-
- Apr 13, 2018
-
-
rswindell authored
REP unpacking).
-
rswindell authored
'Resource/space exhausted' errors in TLS and SSH: The wrong ssh_session is being passed to cryptDestroySession() in sbbs_t::hangup() (introduced in rev 1.615), this call to cryptDestorySession() fails (returns -1, bad param) thus leaving the actual ssh_session never destroyed (leaked).
-
- Apr 09, 2018
-
-
rswindell authored
you can't print and free it again after calling that macro.
-
- Apr 07, 2018
-
-
rswindell authored
cast from pointer to integer of different size
-
rswindell authored
format not a string literal and no format arguments [-Wformat-security]
-
rswindell authored
emusetup.bat). It was generating an (easy to fix) GCC 5.4.0 warning: format not a string literal and no format arguments [-Wformat-security] But the line was not needed, so just removed it.
-
rswindell authored
format not a string literal and no format arguments [-Wformat-security]
-
- Apr 06, 2018
-
-
rswindell authored
warning: format not a string literal and no format arguments [-Wformat-security]
-
rswindell authored
warning: format not a string literal and no format arguments [-Wformat-security] sockprintf(sock,sess,(char*)resp); sockprintf(socket,session,sys_error);
-
rswindell authored
-
rswindell authored
of lprintf() misuse.
-
rswindell authored
unused variable 'p' comparison between signed and unsigned integer expressions
-
rswindell authored
in expansion of macro 'JS_ARGS_OFFSET': unsigned long is the same size as a pointer (rather than unsigned int) on the supported target platforms/tool-chains.
-
rswindell authored
::lprintf() usage.
-
rswindell authored
fix the resulting warnings.
-
rswindell authored
and resolve the resulting warnings.
-