Skip to content
Snippets Groups Projects
  1. Apr 08, 2020
  2. Apr 07, 2020
  3. Apr 06, 2020
    • rswindell's avatar
      Fix bug introduced in rev 1.142 with the additional/optional arguments to the · f1dfe106
      rswindell authored
      yesno() and noyes() methods:
      We need to check the argument count before using the second (optional)
      argument or else it has some garbage/left-over value from some previous JS
      function call. And no, just increasing the argument count in the method table
      isn't enough. :-(
      Reported by echicken and DaiTengu, thanks!
      f1dfe106
    • rswindell's avatar
      Don't try to convert null or undefined arguments to integers. · 1f97b69a
      rswindell authored
      Moved some dbprintf() lines around a bit.
      1f97b69a
    • rswindell's avatar
      MsgBase.open() would not, could not, actually create a message base. · 5da26eca
      rswindell authored
      It would create 3 0-byte files (*.shd, *.sdt, *.sid), but more is actually
      needed for a message base to be "created" (i.e. a call to smb_create()).
      So, MsgBase.open() now uses smb_open_sub() rather than smb_open() to initialize
      theSMB  status fields with the proper default values (based on the sysop
      configuration) and calls smb_crate() if the header file is empty.
      Yes, normally, SCFG creates message bases, but it shouldn't have to
      (e.g. a fresh install on *nix, doesn't actually start with any files in
      data/subs) and now that we have JavaScript-based message lister/readers, we
      really needed this support.
      5da26eca
    • rswindell's avatar
    • rswindell's avatar
      The hack for Nelgin created back in rev 1.35 (Aug-15-2018) was: · 3e9a11fb
      rswindell authored
      - incomplete, it didn't account for the CLEAR @-code which is only handled here
      - caused side-effects in that any Baja PRINT function call with a single line
        that contained any  ^A or @-codes would reset the console abort indication
        flag (SS_ABORT).
        Observed: hitting Ctrl-C at while executing the yesnobar.bin or noyesbar.bin
        would leave "Yes Yes No" on the console, for example.
        Solution: use the tos (top-of-screen) state before/after the call to ctrl_a()
        or show_atcode() to determine if the reset-abort hack should be applied.
      3e9a11fb
    • rswindell's avatar
      Clear the current attributes (back to lightgray) after printing the "Yes" or · c392797a
      rswindell authored
      "No" in yesno() and noyes(), unless the P_SAVEATR mode flag was specified
      (which may be used for the old behavior).
      c392797a
  4. Apr 05, 2020
  5. Apr 04, 2020
    • rswindell's avatar
      Bug: a get_mg_header() followed by a put_msg_header() would add a header field · 562f5e6d
      rswindell authored
      (SMTPREVERSEPATH a.k.a. "reverse_path") if it didn't already have one.
      That's because smb_getmsghdr() will point the msg.reverse_path convenience
      pointer to the from_net_addr if there was no explicit reverse-path (e.g. RFC822's
      "return-path" header field). This could manifest itself in *any* change to a
      message header via JS failing with an "illegal header length increase" error if
      the added header field just happen to put the total header length over the
      allocation threshold of the pre-existing msg header.
      
      Fix: only model a msg header "reverse_path" property if the header field
      actually existed (not based on the SMBLIB convenience pointer).
      When the expand_fields option is used, the old behavior remains but expanded
      headers cannot be written back to the base, so no harm there.
      
      Reported by Coz in #synchronet from failed runs of scrubmsgs.js. Thanks!
      562f5e6d
    • rswindell's avatar
      Increase the "invalid length" of a hashed data record from 1MB to 1GB. · f3e461bc
      rswindell authored
      Apparently some USENET articles are >= 1MB these days. Thanks Coz.
      f3e461bc
    • rswindell's avatar
      Strip Ctrl-A codes from body text before printing. · fff5db77
      rswindell authored
      Treat \n the same as \r (next msg cmd)when reading msgs.
      fff5db77
  6. Apr 03, 2020
Loading