Skip to content
Snippets Groups Projects
  1. Jul 01, 2021
    • Rob Swindell's avatar
      Fix NULL pointer dereference in read_post_data() · 7a132bca
      Rob Swindell authored
      What took down cvs/sbbs yesterday:
      Program terminated with signal SIGSEGV, Segmentation fault.
      6203                    session->req.post_data[session->req.post_len]=0;
      [Current thread is 1 (Thread 0x7f2b989ff700 (LWP 17031))]
      (gdb) print post_len
      No symbol "post_len" in current context.
      (gdb) print session->req.post_len
      $1 = 0
      (gdb) print session->req.post_data
      $2 = 0x0
      7a132bca
  2. Jun 29, 2021
  3. Jun 18, 2021
  4. Jun 16, 2021
  5. Jun 15, 2021
  6. Jun 12, 2021
  7. Jun 11, 2021
  8. Jun 10, 2021
    • Rob Swindell's avatar
      Standardize on "metadata" as the description of a file's "tail" dfield · 1993a13c
      Rob Swindell authored
      It's anticipated that this will be used for JS-populated file metadata in JSON format in the future (and not just "archive contents" in .ini format).
      
      Also, fix the double-free issue that was occurring when moving files with extended file descriptions (sbbs_t::movefile()). This was actually the primary problem I was fixing here, but noticed the metadata issue: metadata would not have been moved along with the other file info between bases.
      1993a13c
    • Rob Swindell's avatar
      mv() simplified for the non-copy case · 2bab4339
      Rob Swindell authored
      Constified function arguments. Source path is still case-insensitive, but destination is case-sensitive (hopefully that's not an issue).
      
      When a "move" (!copy) is requested, a rename() is always attempted first and if successful, job done. Otherwise, we continue on with the file-copy (and then remove).
      
      This should resolve CID 332219 (DEADCODE).
      2bab4339
    • Rob Swindell's avatar
      Call smb_freefilemem() instead of smb_msgmem() for files · dc028bf2
      Rob Swindell authored
      Not that it really matters, but perhaps it'll matter in the future. And the code reads better.
      dc028bf2
  9. Jun 09, 2021
  10. Jun 08, 2021
Loading