Skip to content
Snippets Groups Projects
  1. Feb 19, 2021
    • Rob Swindell's avatar
      Automatically route in-transit mail to points to boss nodes · 7bd42e56
      Rob Swindell authored
      If the destination point node is not a linked node (does not exist in sbbsecho.ini), but the boss node is linked, automatically route to the boss node. The log entries look like this when this happens:
      "Routing packet (%s) to boss-node %s"
      "Routing NetMail (%s) to boss-node %s"
      
      For poindexter FORTRAN (REALITY) - test results appreciated.
      
      Incremented SBBSecho version to 3.13.
      7bd42e56
    • Rob Swindell's avatar
      Recognize DNB blacklist exempted email addresses in From fields · fda59d76
      Rob Swindell authored
      Previously, any DNS blacklist-exempt email addresses (in ctrl/dnsbl_exempt.cfg) had to be used in the mail-envelope (the "MAIL FROM:" address) - that doesn't work for all senders that use re-mailers or whatever where you end-up with some *bounce* address as the envelope-sender.
      
      So now, clear the DNSBL results when the From header field is parsed and the sender was in fact an exempt sender. Note: the Subject line will still contain the SPAM tag if the subject was parsed first (came earlier in the message header). May need to address this limitation in the future if it turns out to be a problem (!).
      
      Lowercase the [smtp|smtps]spy.txt log file.
      fda59d76
  2. Feb 18, 2021
  3. Feb 17, 2021
  4. Feb 16, 2021
  5. Feb 15, 2021
    • Rob Swindell's avatar
      Disable FTP Bounce (FXP) support by default · f803b7bc
      Rob Swindell authored
      The Synchronet FTP server has (since 2001) disallowed PORT/EPRT/LPRT commands with a "reserved" port number (i.e. < 1024) as recommended by RFC2577 and when attempted, would log a "SUSPECTED FTP BOUNCE HACK ATTEMPT" in the data/hack.log file.
      
      However, as Karloch (HISPAMSX) pointed out recently, an FTP Bounce Attack to other TCP ports was still possible (and detected/reported by some security scans as a potential vulnerability).
      
      So, reject all PORT/EPRT/LPRT commands that specify an IP address other than that used for the control TCP connection unless the sysop specifically enables the new "ALLOW_BOUNCE" option flag (in the [ftp] section of sbbs.ini) and the user is an authenticated non-guest/anonymous user. And as before, log the attempt as a suspected hack attempt.
      
      This change also removes the "Directory File Access" checkbox from the Synchronet Control Panel for Windows as that feature is "going away" soon (or at least, it won't be an FTP-specific option/feature if it remains).
      f803b7bc
    • Rob Swindell's avatar
      Disable FTP Bounce (FXP) support by default · 883ea5b8
      Rob Swindell authored
      The Synchronet FTP server has (since 2001) disallowed PORT/EPRT/LPRT commands with a "reserved" port number (i.e. < 1024) as recommended by RFC2577 and when attempted, would log a "SUSPECTED FTP BOUNCE HACK ATTEMPT" in the data/hack.log file.
      
      However, as Karloch (HISPAMSX) pointed out recently, an FTP Bounce Attack to other TCP ports was still possible (and detected/reported by some security scans as a potential vulnerability).
      
      So, reject all PORT/EPRT/LPRT commands that specify an IP address other than that used for the control TCP connection unless the sysop specifically enables the new "ALLOW_BOUNCE" option flag (in the [ftp] section of sbbs.ini) and the user is an authenticated non-guest/anonymous user. And as before, log the attempt as a suspected hack attempt.
      
      This change also removes the "Directory File Access" checkbox from the Synchronet Control Panel for Windows as that feature is "going away" soon (or at least, it won't be an FTP-specific option/feature if it remains).
      883ea5b8
    • Rob Swindell's avatar
      Address more Coverity issues · 141e01bf
      Rob Swindell authored
      Reverted the SAFECOPY() NULL source-pointer magic "(null)" string thing as that caused a different Coverity issue. Explicitly check for NULL at the call-sites instead.
      141e01bf
    • Rob Swindell's avatar
      Address more Coverity issues · dd000f6e
      Rob Swindell authored
      Reverted the SAFECOPY() NULL source-pointer magic "(null)" string thing as that caused a different Coverity issue. Explicitly check for NULL at the call-sites instead.
      dd000f6e
    • Rob Swindell's avatar
      glob() paranoia · 5bdf9d30
      Rob Swindell authored
      Make Coverity happy.
      5bdf9d30
    • Rob Swindell's avatar
      glob() paranoia · 006e0215
      Rob Swindell authored
      Make Coverity happy.
      006e0215
    • Rob Swindell's avatar
    • Rob Swindell's avatar
    • Rob Swindell's avatar
      8cb40880
    • Rob Swindell's avatar
      32c279de
    • Rob Swindell's avatar
      Address Coverity-reported issues · 13ab06ea
      Rob Swindell authored
      Hopefully not introducing any bugs in the process.
      13ab06ea
    • Rob Swindell's avatar
      Address Coverity-reported issues · d02fc1a2
      Rob Swindell authored
      Hopefully not introducing any bugs in the process.
      d02fc1a2
    • Rob Swindell's avatar
      Fix exception (crash) when sending file attachments · 6b9767d3
      Rob Swindell authored
      The new subject line parsing (with quoted-filename support) had a NULL-pointer deref built-in.
      
      Also fixed a few Coverity-reported issues.
      6b9767d3
    • Rob Swindell's avatar
      Update comment header block. · 00bb9dac
      Rob Swindell authored
      00bb9dac
Loading