selection menu. This allows the sysop to display additional download-file
specific instructions (e.g. http URL).

When using sendfile() to send a file *not* in a filebase, current_file will ==
nullptr and the download.* file won't be displayed.

notify() was creating wrongly-formated auto-generated Message-IDs:
e.g. Message-ID: <677B3F17.0.notices@vert.synchro.net>

fix for commit 6e69eec1

This can't actually happen.

Make js_socket_sendfilesocket() suck a lot less.
This commit brought to you with limited rants by Synchronet 3.20b

"Warning: Your BBS may become habit forming."

You could run Synchronet or you could settle for mediocrity.

Once in a great while, there comes BBS software that really makes waves.
Get out your surfboard.

The best BBS software is the most expensive BBS software.
NOT!

If you had three wishes, you could toss the other two.

They couldn't top Synchronet.  So we did.

Accept the inevitable, switch to Synchronet

Try untainting it in recv_hex... if that doesn't work, I'll just
have to ignore it I guess.

Rob Swindell authored 2 months ago and Deucе committed 2 months ago

launches 'jsexec fileman.js' (not in GDI mode)

Rob Swindell authored 2 months ago and Deucе committed 2 months ago

Fix off-by-one error in checking TimeZoneComboBox->ItemIndex again tz_val
array. When choosing the last (Other/Automatic) item, no change to the
sys_timezone should be made (was setting it to 0/UTC).

Rob Swindell authored 2 months ago and Deucе committed 2 months ago

This was evident by logging in with PETSCII/64col mode and the last ']' of the
"Loading message pointers..." progress indicator was left in the first right
column of the screen.

Rob Swindell authored 2 months ago and Deucе committed 2 months ago

This means that when writing user.birthdate (in JS) for example, we will
always save the field in the proper (YYYYMMDD) format. This fixes issue #855.

Remove use of SM_EURODATE from userdat.c.

This commit includes new @-code MINSPACE (minimum diskspace required to allow
uploads) too (unrelated change).

Rob Swindell authored 2 months ago and Deucе committed 2 months ago

To hopefully address:
!ERROR 2 (No such file or directory) renaming s:\sbbs\data\file/somenum.rep
 (-1 bytes) to s:\sbbs\data\file/somenum.rep.6777ed7c.bad

Clearly flength() is returning -1 (file doesn't exist) at this point, so
perhaps the call to fremove() just above updated a cached directory?

Have zmodem_recv_nibble() explicitly range-check all values, and
handle negative values.  If this remains an issue, it can be
untainted with range checks on each nibble, but let's not go there
to start with.

Rob Swindell authored 2 months ago and Deucе committed 2 months ago

This reverts commit 9b2c9c08.

Don't need this now that we use the property sheet method

Rob Swindell authored 2 months ago and Deucе committed 2 months ago

To get proper high DPI scaling and such

Rob Swindell authored 2 months ago and Deucе committed 2 months ago

This reverts commit cb710acf.

This is not the way.

Rob Swindell authored 2 months ago and Deucе committed 2 months ago

This isn't doing what I want, but maybe Deuce can help look at the artifact
from the build pipeline and offer suggestions.

Rob Swindell authored 2 months ago and Deucе committed 2 months ago

If the timezone is set to automatic and it's not a new install, don't display
"UTC0:01" as the time zone (that's weird), display "Automatic (UTC[+/-]HH:MM)"
instead.

When changing the system password via this config wizard, the cryptlib.key
and ssl.cert files, if they exist, will be invalid, so delete them.

Rob Swindell authored 2 months ago and Deucе committed 2 months ago

warning C4244: 'return': conversion from 'uint64_t' to 'unsigned int',
possible loss of data

These are either correct and trivial to fix, or false positives,
but fixing is easy enough that it's not a problem.

Rob Swindell authored 2 months ago and Deucе committed 2 months ago

(user_t.misc, User.settings), when enabling auto-terminal detection. This is
similar to what we do in logon.cpp already:

	useron.misc |= (AUTOTERM | autoterm);

We used to have this logic in useredit.cpp, but was removed in commit
8a71ab16, probably due to editing offline users (e.g. in ;uedit sysop
comand). So just do the copy of autoterm flags when editing the *current*
(online) user. This likely addresses the original concern in that commit.

And it fixes issue #853, thanks to Deuce for root-causing

Rob Swindell authored 2 months ago and Deucе committed 2 months ago

... since that puts us back into VGA tall-font mode

Rob Swindell authored 2 months ago and Deucе committed 2 months ago

We're just converting/upgrading this file (to time.ini), so don't log an error
(reading) if/when the file doesn't exist.

Rob Swindell authored 2 months ago and Deucе committed 2 months ago

Check and log the length of the packet now (since fexist() continues to report
that the file exists when fexistcase() said it did not, even when
experimenting with adding a call to access(filanem, F_OK).

This likely affects no system but VERT.

Rob Swindell authored 2 months ago and Deucе committed 2 months ago

No functional change.

Rob Swindell authored 2 months ago and Deucе committed 2 months ago

Many sysops probably don't realize these keys do special stuff.

Rob Swindell authored 2 months ago and Deucе committed 2 months ago

so we can use it in nopen.c without requiring sbbsdefs.h ... smbdefs.h

This should fix the SVDM build.

Rob Swindell authored 2 months ago and Deucе committed 2 months ago

I don't know if these seek failures are actually happening or not, but
reading from or writing to the wrong offset in the node.dab file could
explain some of the node.dab corruption I'm seeing from macOS (over
SMB share).

For the SBBS binaries, set @executable_path and
@executable_path/../${LIBODIR} so they can all be in one dir, or
they can be in the build output dirs and still work.

For utilities, set to @executable_path and
@executable_path/../../${LIBODIR} for the same reason.

With this, we shouldn't need to fiddle with DYLD_LIBRARY_PATH

Remove the -E linker flag.
This should not be needed anymore, and isn't supported on macOS.

Have shared libraries include their full path.
This allows linked dylibs to work from where they were built, so
as long as you don't build the binaries on a CI machine, then try
to run them on a users machine (*cough*), it'll work out.

Use the correct rpath argument format on macOS.
It uses -rpath, not --rpath.

Rob Swindell authored 2 months ago and Deucе committed 2 months ago

Kind of a shot in the dark here: Max (WESTLINE) is reporting HEAP CORRUPTION
debug assertion in websrvr.dll. In the 2 instances reported, a long (336
char) JSON "query value" was logged by apparent spam-bot trying to create a
a new user account ("send-me-free-stuff" is one of the JSON properties).

JS_NewStringCopyZ() can return NULL in a low memory situation, though I don't
know that explains possible heap corruption.