DDMsgReader: When reading messages (including sent email), only mark it read if it's to the current user. Reported by Accession.

See merge request !521

DDMsgReader: When reading messages (including sent email), only mark it read if it's to the current user. Reported by Accession.

The last item was being cut off on my system (uninitialized value)

To be consistent with how sbbs[.exe] works

To be consistent with how sbbsctrl.exe works

Don't save player if player is undefined.

Presumably someone is sitting at the intitial menu until they run
out of time on the BBS.  The error was completely harmless.

C64 doesn't have a backspace key, so treat backspace the same as
DEL.

Closes tick 197.

This should fix issue #893, but it's hard to tell for sure, the docs
for JSON db are a bit sparse.

Throw an error instead.  This should help DigitalMan debug his issue.

Eliminate the unnecessary calls to snprintf() and atoi()/ahtoul() since these
are simple fixed-length parses. No change in behavior, just a minor
optimization.

&time is incremented after maint runs, which allows a newly created
first user to take turns on the first new day.

When viewing messages posted with pipe codes (e.g. coming from Renegade, WWIV,
Mystic BBS), the wordwrap logic would prematurely wrap lines.

This is highly unlikely to solve whatever is happening on DMs system

Since this script isn't normally calling bbs.nodesync() (e.g. to display
any pending inter-node messages/telegrams), we have to check the NODE_INTR
flag manually. Calling bbs.nodesync() directly here to get a more immediate
notice and disconnection message sent to the user.

This check is necessary so that a sysop or the event thread can gracefully
terminate/disconnect a user that's running this script (e.g. when an
exclusive timed event is scheduled to run and thus being prevented to run).
This should help Keyop's reported issue with his weekly msgmaint timed event
having to ungracefully disconnect his user session because he's running this
script.

and abort the execution of the program when the node is interrupted. This
should allow more cases were the node interrupt flag can be used to gracefully
disconnect a user running a DOS or native (stdio) program on *nix.

We have this functionality already in the Windows version of external()

When a timed event is configured to run "exclusively", all nodes need to not be
in in-use. As it was, after waiting 60 minutes for the online user(s) to
notice they'd run out of time and disconnect, we'd just (rather ungracefully)
close the sockets used by such node(s) connections. This results in same logged
errors about trying to send to bad socket descriptors and provides no feedback
to the user about why they were disconnected.

Since we have the node interrupt flag (which hopefully, all scripts are
checking via node_sync) - use that to try to more gracefully terminate the
user's session/connection after 30 minutes of waiting for the user to
disconnect.

If after 60 minutes of waiting, the node is still in-use, we still do the
socket disconnection method.

Just caught during code review

This would've prevented some JS log functions from writing to the node.log file
(which gets concatented onto the daily "system" log files).

This just came up via code review while looking into Keyop's reported error:
term Node 2 !ERROR 9 (Bad file descriptor) in main.cpp line 4606 (node_thread)
     truncating "logfile" access=0

This is likely unrelated since the "logfile" is immediately re-opened after
executing the external program/script.

Not sure this makes any difference, but this matches LORD2 behaviour.

Should make issue #392 go away, but the underlying CNW bug which
will cause the player that runs maint to see all NPCs remains.

For CNW, maintenance should absolutely be ran as a timed event,
with a real name that never gets an account.  Luckily, if there's
no dropfile, real name defaults to SYSOP, which should meet that
criteria.

Maybe something will end up being useful, nobody actaully seems to
notice it happening though.

Reported by Digitalman

Since this doesn't work, we're clearly not relying on it, so remove
it.

Reported by: jrtc27 via IRC

This returns bug-compatibility with attrstr(), at least for Ctrl-A chars,
so that if someone is for example, assigning a Ctrl-A sequence to JS
console.attributes, that'll work (again) as it did in SBBS v3.19.

Any other invalid chars in the string will stop the parsing, still, even
though that's not how attrstr() worked.

For Kirkman's doorgame/script backward compatibility.

For Wildcat (N)ewsletter command and PCBoard "NEWS" command, display
"No news is good news." instead. :-)

DD file & message area choosers: Name collapsing now supports an arbitrary number of levels

See merge request !520

... when using the -mail option, which probably no sysop is.

Just needed to set the 'can_read' property.

As reported via IRC by Accession

Log errors if/when comWriteBuf() fails.

This is to hopefully help to root-cause or even possibly resolve the issue
reported in #synchronet by PyRoDrAkE:
"It all works well until the Dialup connection runs slower than 4800 baud
using SexPots. I connect from my XT at either 1200 baud or 2400 baud and it
would just stop drawing midway."

There shouldn't be any write timeout in comWriteBuf(), so I don't know why
this would help, but it's worth a try. Logging any comWriteBuf() errors is
also a good idea in general.