When a preexisting node.log file is found, a terminal server crash is suspected. Include the timestamp of the node.log in the message appended to the system log (data/logs/*.log) to help identify the likely time of the crash.

fix pre/post_eval_on_exec to work with existing uses

See merge request sbbs/sbbs!33

Kayz authored 4 years ago and Rob Swindell committed 4 years ago

change the program var in xtrn.js to prog to be compatible with any existing uses of eval_before_exec

By default, displays users of the BBS born in the current month.

Remove birthdate.js - not needed or used anywhere (anymore).

Don't pass NULL to strcasestr().

when there is no "template directory" selected/configured.

Don't load() things unnecessarily (use require() instead).
Fix the X-restriction issue (is not supposed to limit the execution of
programs configured to run as logon events).

When posting to "All" or replying to a message that was posted by networked (not local) user, don't attempt to search for that username in the local user base to inform them of the posted message to them.

savemsg() is the underlying C function for saving a new message (mail or post) to a message base from several places, including JS modules. If there was no "charset" specified in the passed message header, check to see if the message body text is non-ASCII but valid UTF-8, and if it is, set the FIDO_CHARSET header field to the appropriate UTF-8 charset identifier string. This would *also* address Issue #177 reported by Michael J. Ryan. It's possible, but unlikely, that a message text would contain valid CP437 that *also* happened to be valid UTF-8. If that does happen to occur (e.g. in posted ANSI art?), we might want to revert this enhancement to savemsg() and leave to the caller's to detect/specify the charset, always.

In Issue #177, the reported problem message header was "Content-Type: text/plain; charset=utf-8; format=flowed"
The fact that the "charset" value was not quoted and not space delimited means the charset would have been parsed as "utf-8;", which would not provide an exact match (against "utf-8") in smb_msg_is_utf8() and thus the message body would not be considered to be utf-8 encoded.

The solution is to terminate the "charset" parameter value at the semicolon, if it exists, and the value was not quoted.

Also, for good measure, only search for " charset" or ";charset" to avoid false-positive parameter matches,  like "notcharset".

Throw exceptions rather than just loggin an "Unable to open" error
(easier tracking fo the soruce of the error). Log the description and
errno value associated with the file open failure.

Create the .ini files if they don't already exist (rather than crashing
out with an error).

Replace the deprecated 'e' file open mode flag with 'x'.

Fix sexpots-linux build issue introduced in previous commit.

Remove archive names (uses build names by default?).
Remove "build-" from build names.

For Windows release (CI) builds.

Caused error:
exec.cpp line 805 (sbbs_t::exec_bin) opening "s:\sbbs\exec\ÿÿÿÿÿÿÿÿ.bin" access=0
As reported by Nelgin via IRC at 3AM Texas-time.

Debugging why textgen is failing during Windows/CI build.

Add Windows build job.

Previously, SyncTERM only supported the more modern XMODEM-1K uploads and XMODEM-CRC downloads. This commit adds support for XMODEM-128 uploads and XMODEM-Checksum downloads.

This should help to root-cause any future msgbase open failures like those
that I suspect were a result of Issue #4.

This should address the issue raised by Michael J. Ryan in issue #4.
The command in question ("GROUP") would attempt to open the message
base associated with the specified newsgroup name without closing
the currently open/selected message base (if there was one). This would
result in multiple simultaneously open message bases and could result
in an exhaustion of open file descriptors leading to a failure to open
any additional files (includign message bases) and thus a subsequent
"GROUP" command would fail with the wrong "!no such group" error.

External Program Pre/Post Loadable Modules

See merge request sbbs/sbbs!24

Kayz authored 4 years ago and Rob Swindell committed 4 years ago

This introduces pre/post execution modules for bbs.exec_xtrn. The logic previously in xtrn_sec.js for those functions is now in prextrn.js and postxtrn.js. These handle screen clear, evals, fonts, etc. Now everywhere that launches an external program will support these features

as part of the 8->40 password length enhancement.

Everything after U_OLDPASS was NaN because of a typo (U_PASS not yet defined).

present external menu option display defaults

See merge request sbbs/sbbs!30

Kayz authored 4 years ago and Rob Swindell committed 4 years ago

make it easy for people to change the look of the external programs menu by presenting them the defaults instead of them having to dig into the code, text.dat, etc. to get the starting values