- Mar 24, 2019
-
-
rswindell authored
-
rswindell authored
-
rswindell authored
character limit imposed by FidoNet message "to" fields, in sbbs_t::netmail(). Use the regarding-message from_net field when a 'to' field is not passed to sbbs_t::netmail()
-
rswindell authored
IPv6 commit of 2015: "OutgoingV4" is now "OutboundInterface" and "OutgoingV6" is now "OutboundV6Interface" (which is not yet used)
-
- Mar 22, 2019
-
-
rswindell authored
Fix age-old bug with Borland/C++Builder built executables (Windows): to achieve compatibility with the default __cdecl symbol naming rules of Visual C++, we were using __stdcall convention for DLL functions when building code with Borland/C++Builder tools and using the default (__cdecl) convention when building with Microsoft (Visual C++) tools. Although this allowed symbols to be located when linking, the calling convention mismatch caused a stack cleanup issue that very rarely manifested itself in a bug (e.g. exception of some kind in sbbsctrl.exe, usually). Mismatching the calling conventions was unintentional (I thought the default for MSVC DLL functions was __stdcall) - but since the calls to MSVC-Built DLL functions worked 99% of the time, I didn't realize there was an underlying issue. So I now work-around the DLL symbol naming mismatch using a command-line option (-a) passed to implib in src/sbbs3/ctrl/makelibs.bat I had previously worked-around exceptions when calling MSVC DLL functions in sbbsctrl.exe by calling the problematic DLL functions from a timer tick handler rather than a user control (e.g. button) event handler. Those work-arounds can now be removed. The erroneous "DLLCALL" definition design pattern was replicated (copy/pasted) to many other projects' header files in cvs.synchro.net. In the future, we may want to just remove all instances of *CALL since they now serve no purpose and appear as useless "Kruft" (but do allow us to more-easily globally change DLL function calling conventions if/when necessary in the future).
-
- Mar 19, 2019
-
-
rswindell authored
-
rswindell authored
-
rswindell authored
Don't store a columns value of 0 (the default). Use SAFEPRINTF in place of sprintf() in parse_control_line().
-
rswindell authored
FidoNet "Kludge line" (control line): "\1COLS: <columns>\r" where <columns> is a value between 0 and 255 and a value of 0 is special, meaning "unknown" and not normally specified (this is the default assumption when there is no "columns"/COLS header field). When a message editor column width is unknown, is is normally assumed to have been 80 columns for word-wrapping/re-wrapping purposes when displaying the message text. This feature has worked well for Synchronet's QWK networking (i.e. there are far fewer instances of word-wrapping/re-wrapping issues when viewing messages on DOVE-Net), so I decided to support this message header field over FTN (SBBSecho) as well. Hopefully other FidoNet software authors will notice and support this header field in the future as there are still numerous examples of word-wrap issues when viewing FidoNet messages. At least Synchronet <-> Synchronet systems over FidoNet should be able to re-wrap and display all message text nicely when both ends support this kludge line. Incremented SBBSecho version number to 3.07.
-
- Mar 16, 2019
-
-
rswindell authored
- filenames must begin with an alpha-numeric char. Might want to relax this in the future if it's a problem, but generally filenames on BBSes do begin with alpha-numeric characters and this will help us to identify an ignore "garbage" filenames in listfiles. - always check if the file actually exists, even when parsing the length of the file from the listfile. This will also help us to ignore garbage filenames. - also removed an inexplicable unpadfname() call. Filenames in file lists should *not* normally be padded (like "this .txt") - so I'm not sure why this was in there. Perhaps for lists generated from filelist.exe (?). Anyway, out of an abundance of caution, removed it. Padded filenames are going away.
-
rswindell authored
or more specifically, if the index (.sid) file is of an unexpected size (too big or too small) handle that situation gracefully.
-
- Mar 13, 2019
-
-
rswindell authored
fail if the current file pointer (offset) was not currently at the beginning of the file. So calling MsgBase.get_all_msg_headers() after previously calling any method that read/seeked the index would cause the reported error: "index read (xxxx) failed"
-
rswindell authored
types twice - first to see if one matches the requirements. If none match, then search again just for an extractor matching the file extension. Modernize the get_file_diz() function a little bit (e.g. return bool).
-
rswindell authored
function. Constify mycmdstr() arguments. Removed trailing whitespaces. No functional changes expected by this commit.
-
- Mar 10, 2019
-
-
rswindell authored
this code is on the chopping block already.
-
- Mar 08, 2019
-
-
rswindell authored
by Deuce. If 'top' is passed in as NULL, assign a blank string constant to it since we dereference top a few places in this function and pass it to putmsg().
-
- Mar 07, 2019
-
-
deuce authored
to a second thread before the first has the session set active. Add calls to lock/unlock the certificate to prevent this. The better options is likely to have a function that adds the key and socket and sets the session active in one call and handles the locking internally. But I'm lazy, so we get the lock functions.
-
- Feb 21, 2019
- Feb 20, 2019
-
-
rswindell authored
(JS bbs.post_msg()): If the WM_QUOTE mode flag is *not* set, then it will auto- create the quote file (quotes.txt) and add the WM_QUOTE mode bit before calling sbbs_t::writemsg(). So if existing JS scripts call bbs.post_msg(..., WM_QUOTE) with a custom-created quote file (e.g. with msg tails), that'll still work as before (e.g. DDMsgReader.js). bbs.email() and bbs.netmail() now support an optional reply_header_object argument which works like bbs.post_msg(). These methods (and the underlying C++ methods: sbbs_t::email(), netmail(), inetmail(), all auto-create the quote file now, when the WM_QUOTE mode flag is *not* set. The auto-created quotes.txt now includes the plain-text version of MIME-encoded messages. the bbs.post_msg(), email(), and netmail() methods now all support reply header objects that came directly from bbs.get_msg_header() *or* copies of such header objects (but the auto-quoting feature won't work when supplied this type of header object). So if passed a header object returned from bbs.get_msg_header(), we can now use the message base (for auto-quoting) and the underlying msg storage directly (no JS parsing necessary). This is what the new js_GetMsgHeaderObjectPrivates() function is used for. js_ParseMsgHeaderObject() (and the underlying parse_header_object() function) now supports either an actual internally-generated msg header object (e.g. returned from bbs.get_msg_header()) or one that is a copy or hand-constructed. quotemsg() no longer tries to get a copy of the msg index/header. It shouldn't have to since we can now get to underlying msg storage in the js_msgbase.c via js_GetMsgHeaderObjectPrivates(). quotemsg() now reads only the plain-text portion of MIME-encoded messages. As part of this effort, I modernized the method prototypes using default argument values (e.g. WM_NONE for wm_mode arguments) and removed some extraneous WM_EMAIL and WM_NETMAIL specifications (these wm_mode flags are automatically added by the sbbs_t::email() and *netmail() functions). savemsg() now *does* support reply-IDs/thread-linkage via the additional 'remsg' argument (when non-NULL). Replaced some use of nulstr with NULL. Replaced more boilerplate SMB open code with calls to smb_open_sub().
-
- Feb 19, 2019
-
-
rswindell authored
used by js_post_msg() (the JS bbs.post_msg() method when used with the reply_header object argument) - the private data attached to a message header object is of type privatemsg_t, not private_t. This caused the dereferences of and assignments to p->smb_result in parse_header_object() to corrupt the privatemsg_t->msg memory causing heap corruption (caught on Windows debug builds in js_get_msg_header_finalize()) and stack faults (caught on Linux-gcc in parse_recipient_object()). This one was hard to find. <whew!>
-
rswindell authored
I noticed that printable ctrl chars (e.g. 0x18 and 0x19) were not causing the current column position to increment, so that got me looking at this code and wondering why the LF/FF checking was outside the if(!outchar_esc) condition and being executed when CON_R_ECHO is off. So now, using a switch statement, it's cleaner and all the printable ctrl chars move the current column position correctly.
-
rswindell authored
When the WM_QUOTE mode flag is set and the 'remsg' is specified, the original message will quoted (excluding message tails, using the proper word-wrapping). If the quote file already exists before calling postmsg()/bbs.post_msg(), it will be over-written. This allows JS script to initiate reply-posts with quoted text without having to create their own quotes file. It also means there's no need to call sbbs_t::quotemsg() before calling sbbs_t::postmsg(). sbbs_t::quotemsg() now takes an smb_t* arg (stop using the sbbs_t 'global' smb) and now returns bool.
-
rswindell authored
Renamed js_postmsg() -> js_post_msg() for good measure.
-
- Feb 18, 2019
-
-
rswindell authored
-
- Feb 17, 2019
-
-
rswindell authored
designator.
-
rswindell authored
Only treat an invalid QWK msg block count (<2) as an error if there is more than one msg header in the packet (stop saving so many worthless data/file/*.rep.*.bad files).
-
rswindell authored
-
rswindell authored
file lists during events.
-
rswindell authored
"read %u message scan cfg/pointers in %lu ms" The message pointer performance problems were resolved a long time ago now and this is just noise in the logs.
-
rswindell authored
reported as "Duplicate index offset", so overlapping headers means the index offset must not be an exact duplicate, so we don't report the same corrupt message parameter (its offset into the header file) 2 different ways.
-
rswindell authored
is 0 (logic moved from sbbs_t::postmsg()).
-
rswindell authored
as it is easy for a sysop to accidentally hit [D]elete and not realize it.
-
rswindell authored
-
rswindell authored
packets.
-
rswindell authored
So I created a single add_msg_ids() function (mostly migrated from postmsg.cpp) to make this incredibly easy so any/everywhere that adds a message to a message base should be able to call it. This function also creates reply-IDs (when relevant) and program ID (Fido-PID) header fields: - FIDOPID (always) - FIDOMSGID (if an echomail post) - FIDOREPLYID (if an echomail reply-post) - RFC822MSGID (always) - RFC822REPLYID (if a reply)
-
rswindell authored
If the user.dat file is already opened in deny-none mode (as is the norm), another process (e.g. useredit.exe) cannot simultaneously open it in exclusive mode.
-
- Feb 16, 2019
-
-
rswindell authored
(blank names or internal codes) from the total saved to xtrn.cnf.
-
rswindell authored
read the entire index file in a single read operation
-
rswindell authored
This has not actually been an observed problem, but I just realized while working on smb optimizations that this condition would not be reported by chksmb.
-