The first argument can now optionally be an array of strings (e.g. as read from File.readAll()), so that multiple searches of the same file (e.g. twitlist.cfg, while importing messages) does not require multiple *reads* of the same file.

Not sure the cause, but this change stops the error-machine:

Jan 23 15:03:43 cvs sbbs: web  0120 Request: GET /?page=001-forum.ssjs+AND+1+%3D+1&sub=mystic+AND+1+%3D+1&thread=4809+AND+1+%3D+1 HTTP/1.1
Jan 23 15:03:43 cvs sbbs: web  0120 HTTP Logon (user #0)
Jan 23 15:03:43 cvs sbbs: web  0120 Internal Redirect to: GET /index.xjs HTTP/1.1
Jan 23 15:03:43 cvs sbbs: web  0120 Handling Internal Redirect to: GET /index.xjs HTTP/1.1
Jan 23 15:03:43 cvs sbbs: web  0120 Adding query value page=001-forum.ssjs AND 1 = 1 at pos 0
Jan 23 15:03:43 cvs sbbs: web  0120 Adding query value sub=mystic AND 1 = 1 at pos 0
Jan 23 15:03:43 cvs sbbs: web  0120 Adding query value thread=4809 AND 1 = 1 at pos 0
Jan 23 15:03:43 cvs sbbs: web  0120 JavaScript: Compiling script: /sbbs/exec/xjs_handler.js
Jan 23 15:03:43 cvs sbbs: web  0120 JavaScript: Executing script: /sbbs/exec/xjs_handler.js
Jan 23 15:03:43 cvs sbbs: web  0120 HTTP Logon (user #4)
Jan 23 15:03:43 cvs sbbs: web  0120 !JavaScript  /share/sbbs/webv4/lib/pages.js line 42: TypeError: _file is undefined, Request: /index.xjs

Install via "jsexec emailfiles -install". See comments for details.
This is the result of the script begun in this tutorial video:
https://youtu.be/1cSnF3Vq9XA

If there was an error opening a file for attachment, the MIME part would be left unterminated.

MSVC detected heap corruption from this function when the attachment was 0-bytes in length. Good catch.

Consume the SMTP lines as fast as possible since the sender may be on the
local network (or even local/loopback interface!) and could get way ahead and
timeout otherwise, resulting in the "premature evacuation" error (and dumping
of the received message) on the receive side. This resolves an observed issue
with sending large attachments to the mail server at very high rates and the
sending client timing and disconnecting waiting for a response from the server
(which was throttling the receive using YIELD).

An unrelated optimization (elimination of an unnecessary use of fprintf) resulted in a new bug that combined all lines from SMTP-received mail messages into a single long line, thus breaking all decoding ability of multi-part MIME messages (where blank lines are significant).

Went ahead and replaced some other unnecessary uses of fprintf(), replaces with fputs() while at it.

Some terminals can send NUL (ASCII 0), e.g. hitting Ctrl-Space in Apple iTerm. Allow users of inkey() (in C++ or JS) to optionally detect the difference by specifying the K_NUL mode flag. In JS, console.inkey() will return null upon timeout (rather than "") when the K_NUL mode flag is used and return an empty string ("") upon receipt of NUL (ASCII 0).

The default is the previous behavior where a timeout and the receipt of a NUL character appear the same to the caller of inkey().

When a file library's "Access to Sub-directories" option was enabled, any auto-created directories would have their data dir initialized as "blank" (empty), so their data files (e.g. <code>.dat, <code>.ixb) would be created in the ctrl directory.

I guess nobody used this feature? It is pretty cool, but not really documented. If you were using it before this commit, you'll need to move your sub-directories data files to data/dirs or re-add the files (recreate the database files). And you can remove the old cruft from the ctrl dir.

This involved the removal of the content-transfer-decoding feature of the SMTP mail server since we need single-part MIME-attached file contents to be stored in their original encoded form (e.g. base64-encoded) and not in binary, for the message body text (where NULs aren't allowed, CR/LF is appended, etc).

I accidentally made this change to smbtxt.c in the new_file_base branch and then copied over here, so there's some unrelated innocuous changes (comment header, removal of SMBCALL) that hopefully won't cause a merge conflict later.

I don't actually receive single-part MIME attached files, so depending on others (e.g. Nelgin and Dream Master) to test for me.

Don't display at all if smb_getplaintext() returns a blank string.
Don't display "(null)" if there's no text sub-type.

door install configs batch 5

See merge request !78

We were just trusting that the error strings would be shorter than 256 (usually), but since we're including paths and strerror() results, we really have no control over the length of the error strings. So enforce some healthy boundaries. This could explain the crashes that Divarin of Mutiny is seeing with SCFG on WinXP or maybe it was the truncsp(strerror()) stuff that was just removed as well. We'll see...

Its a terrible idea to modify the return value of strerror() on any platform. strerror() can (and often does) return immutable string constants - don't try to modify that string even if it does end in trailing white-space (find another solution to that). This change only affects non-*nix builds since we were already doing the right thing for *nix.

Some old/unsupported FidoNet software (NetMgr? Squish?) reportedly parse addresses from MSGID control/kludge lines in NetMail messages to determine the source and/or destination address. This is clearly a bad idea for a lot of reasons, but to improve compatibility, let's not include the message number (or an '@') in the origaddr field for NetMail messages. This does slightly increase the chance of a duplicate MSGID being accidentally generated if the "mail" base is renumbered. No change for EchoMail MSGIDs (where dupe detection and threading still benefit from the additional entropy).
For Watchman.

<@Deuce> Just saying that if someone does the work of exit_code = {thing: function(x) { return secretsauce }); exit(); they should get away with it.

Don't use the "exit_code" property value as the return value of js.exec() unless it's a number. As reported by mlong (thanks).

Also, "exit_code" was being set to null (instead of void/undefined) in js_PrepareToExecute(). I think this was just an oversight or typo by Deuce from his commit of 5 years ago (f3256d81). Since we're comparing exit_code with JSVAL_VOID in other places to determine if it was actually set, this appears to be a long standing bug.

Update install-xtrn.js, make it apparent that debug mode does not install the...

See merge request !76

Update install-xtrn.js, make it apparent that debug mode does not install the door. Also do not recycle in debug mode (nothing was installed). 

This script had some funky work-arounds for the previous behavior, so adjust
them to recognize null input from the user. This fixes issue #201
reported by Ragnarok.