Version 1.17 beta 59: When submitting a vote, the thread_id field is now set to the message/poll's message ID, not the message number.

(e.g. warnings and errors).
Also, stripped trailing white-space from many lines (editor setting).

Terminal Server SSH ERROR 'Bad argument, parameter 1' (-1) ...
from output_thread
Don't set ssh_mode=true until the ssh_session has been created successfully.

Also added some more debug output with regards to Cryptlib session number.

parameter 1' (-1) ... from output_thread

Terminal Server SSH ERROR 'Bad argument, parameter 1' (-1)
 ... from output_thread

The bbs_thread() sets the global/server sbbs ssh_mode to false and ssh_session
to 0 (the "parameter 1" value used in the cryptlib function calls in
output_thread) but was doing this without owning the ssh_mutex, so the
output_thread had a race condition where it would check ssh_mode=true and
then use grab the ssh_mutex and use ssh_session in a few cryptlib function
calls. The fix for the bbs_thread() to grab the ssh_mutex before setting
ssh_mode to false and ssh_session to 0 and have the output_thread() re-check
the ssh_mode after grabbing the ssh_mutex and not call any cryptlib
functions if ssh_mode was set to false while waiting for the mutex.

The cause would have been more obvious if the various cryptlib error/log
messages contained the cryptlib session ID value (which was 0 in this case).

WARNING.
Also fixed a couple of typos in strings.

switch to CP437 before any uifc stuff and everythings going to be happy.

missing, but also now logging when renaming (or failing to rename) bad
received .REP packet files.

packet errors, no need to save such REP packets as .bad files.

This should fix the issue with non-CP437 fonts reported by Kirkman.

error messages (in the POP3 server) as the msg.hdr.number is zeroed by
smb_getmsghdr() and potentially invalid when returning an error.

error log message as the header is zeroed in this function and thus the
message number previously read from the index, lost (zeroed) and useless.

screen of rows.

*nix-builds (for stdio WWIV doors).

Use drive mappings (e.g. D:, F:, G:, H:) rathe than absolute paths to node_dir,
ctrl_dir, data_dir, and exec_dir in drop files.
Also: fixed what appears to have been a copy/paste error in the node_dir
and ctrl_dir mapping to Win32-shortnames for non-native doors on Windows.

- Don't use the deprecated 'e' file open mode
- Use the global file_copy() method rather than roll-your-own

attachment is attempted but unsupported.

- writes outbound netmail to SMB rather than FTS-1 Stored Messages (*.msg)
  this means you must have SBBSecho v2.30 or later in order to export FTN
  netmail (for file attachments, you'll need SBBSecho v3.04 rev 3.78 or later)
- removed support for the now deprecated "default address" feature
  (nowadays, people are much more likely to gate FidoNet over Internet rather
  than the reverse!)

The QWK-to-NetMail function still needs a similar overhaul.

(e.g. "C:"), skip it on *nix and if the path contains backslashes, convert
to forward-slashes (for all OSes). This resolves an issue of sending a
netmail file-attachment that was created on a Windows/MS-DOS type system
and then scanned/exported on a *nix system. The FTN "stored message"
convention is to have the full path of the attached file in the message
subject.

Hopefully nobody wants to use outbound directory names beginning with "x:"
on *nix. :-)

included an "old-style" (not MIME-encoded) file attachment (where the file path
is in the subject and the FILEATTACH aux-attribute flag is set), the
corresponding netmail attribute flag would not be set in the stored msg (*.msg)
file. Also simplified the create_netmail() function prototype/usage, removing
the "file_attached" argument (use the hdr.auxattr instead).

bytes different, so committing out of an abundance of caution. No "known"
changes however.

1: Wrap SSH cryptDestroySession() calls in a wrapper that tracks the number of
    open sessions and logs errors upon failure (and remaining session count).
    This is how I found the SSH session leak in sbbs_t::hangup().
    Also found multiple cals to SSH_END() which were invalid (no session to
    destroy) and removed them.
2: If errors are detected when unpacking a REP packet, save the .rep file
    (in data/file/<filename.rep>.<timestamp>.bad) for later inspection.
    Also added some VOTING.DAT debug output (to be removed later).
    Trying to the get to the bottom of the
    "smb_addvote thread_back field missing" errors.

pause and CLS after.

@DigitalMan | It'd be nice if home/end keys moved to first/last avatars in a collection when viewing a collection

@DigitalMan | JavaScript  s:\sbbs\exec\avatar_chooser.js line 775: TypeError: state.opt_out_item is null

uh, this oughta do away with that, I guess

revisit some of this.

(Not the best fix, but it'll do for now.)

REP unpacking).

'Resource/space exhausted' errors in TLS and SSH:
The wrong ssh_session is being passed to cryptDestroySession() in
sbbs_t::hangup() (introduced in rev 1.615), this call to cryptDestorySession()
fails (returns -1, bad param) thus leaving the actual
ssh_session never destroyed (leaked).

chars for Bill McGarrity @ tequilamockingbirdonline.net :-)
Doesn't seem to break anything (except backwards compatibility with SBL
v3).

you can't print and free it again after calling that macro.

Added destination address of outbound file in "Attempting callout" log msg.

cast from pointer to integer of different size

format not a string literal and no format arguments [-Wformat-security]

emusetup.bat).
It was generating an (easy to fix) GCC 5.4.0 warning:
format not a string literal and no format arguments [-Wformat-security]
But the line was not needed, so just removed it.