Skip to content
Snippets Groups Projects
  1. Apr 14, 2020
    • deuce's avatar
      Only copy up to MAX_PATH characters to each component in _splitpath() · 9ae9a634
      deuce authored
      Fixes coverity warning in SyncTERM... matches the size all callers currently
      use.
      9ae9a634
    • rswindell's avatar
      b9646527
    • rswindell's avatar
      Some very old, yet inconsistent, behavior of smb_hfield_add() could pretty · 717b99ee
      rswindell authored
      easily result in a message body being added to a message base with no
      accompanying message header: if the header data was 0-length, the hfield_dat
      was not actually allocated and the applicable smbmsg_t convenience pointer was
      not set accordingly. This had the side effect that if a message were to be
      imported with a blank recipient ("To" field), the header was not created at
      all (to support mutliple header, single body msgs, i.e. bulkmail).
      The other functions that set the convenience pointers do not treat 0-length
      header field data special, so this was inconsistent behavior.
      Most message types (e.g. networks) don't want 0-length "to" fields, but that
      shoudl be enforced somewhere else, not here.
      717b99ee
    • rswindell's avatar
      On Windows, smb_addmsg() was slow because smb_updatethread() was slow: · 210e6901
      rswindell authored
      So on Windows, calling unlock() on a file region that you don't have locked,
      incurs a delay. Likewise, calling lock() on a file region that already have
      locked incurs a delay. These delays were seriously throttling message imports
      on Windows (e.g. importing echomail or QWK packets). What should take a few
      seconds, was taking minutes with noticeable delays. This code has been
      performing redundant locks/unlocks for over 15 years, so I can only conclude
      that the performance penalty is a new behavior introduced in recent version(s)
      of Windows.
      210e6901
    • rswindell's avatar
      1fe62a57
  2. Apr 13, 2020
Loading