Eric Oulashin authored 1 year ago and Rob Swindell committed 1 year ago

SlyEdit: UTF-8 support in the displayed header and when quoting text and when quoting message text. This also includes a dd_lightbar_menu.js update

than err_len containing garbage.

Handle the error and mention we didn't get the message.
While we're here, check the return value of malloc().

Given how patched up cryptlib is at this point, this is all likely
to go away and just use the static lib in the nearish future.

If call to GetAttributeString() fails, err_len can contain garbage.

that we're setting all the values anymore. :(

wrong, do c_cc the stupid (but POSIXly correct) way with a billion
supporting.

Since the user we're editing here is not a pointer to the current user,
changing the USER_SWAP_DELETE settings before this prompt doesn't prevent
the DEL->BS translation from happening. Raw input mode does.

Without this change, it would appear the user's backspace key would toggle
between sending either ^H or DEL for the backspace key (for terminals that
actually send DEL).

SlyEdit readme: Removed extraneous description about UTF-8 support and left it as a simple blurb

See merge request !401

Monster.

This line has always been there and never done anything.

This bug caused crashes in the Windows build of sbbs when using the ;spy
sysop command with MQTT enabled.

Memory that is allocated in one DLL (e.g. sbbs.dll) must be freed in that same
DLL (e.g. sbbs.dll, not mosquitto.dll).

mosquitto_message_free() here frees the msg pointer, but we didn't allocate
it in mosquitto.dll in the first place, so that's wrong. The proper mosquitto
function to use in this case is mosquitto_message_free_contents().

SlyEdit: UTF-8 support. Also, new feature: Entering a graphic char with Ctrl-G (Ctrl-G was previously the key for general help, which wasn't much)

See merge request !400

Eric Oulashin authored 1 year ago and Rob Swindell committed 1 year ago

SlyEdit: UTF-8 support. Also, new feature: Entering a graphic char with Ctrl-G (Ctrl-G was previously the key for general help, which wasn't much)

console.write() converts CP437->UTF-8, so use write_raw() instead since
we're already doing the CP437->UTF-8 conversion here.

As reported by Keyop.

Debug project was already set this way.

cast all the const buffers before passing them in and rely on
runtime crashes to find bugs rather than compile-time errors.

Thanks Microsoft. :D

The alternative is to explicitly copy/paste the type everywhere
forcing the compiler to do the only thing it could possibly do,
and making it painful to change a type later.

Honestly, in my opinion, these warnings should just be disabled
completely everywhere.

Found by MSVC

Just use the raw value and a comment.

We can't use const protection for the sample buffer because the Win32
API takes non-const buffers.  For standard implicit conversions,
simply disable the warning where it occurs on purpose.  It appears
that MSVC builds use the equivilent of -Wconversion (which isn't even
part of -Wall).