Addresses CID 350318 

But good practice anyway

with lseek() argument types, ftell() return type, etc.

Likely none of these would be actual issues with files < 2GiB in size.

resolved CID 350321

Before the "new filebase" merge of 2021, a user's batch download queue would be cleared when a QWK packet was successfully packed for them via the event thread (i.e. triggered via semaphore file). That was lost in the new filebase change (the batch download queue would not be cleared) - caught by Coverity (CID 350336).

It appears pre-packed QWK packets never cleared the batch download queue (does anyone actually use this feature in this day and age?) - fixed.

Could use more long->off_t conversions, but this is a start.

Reported by Coverity

Caught by Coverity-scan (use of uninitialized variable, 'str') :-)

Weird early failure return on TLS sends.  Most noticible on local
(ie: fast) connections, but clearly stupid all around when you
look at the code.

Fixed, but some day, I should go back and look how we eneded up in
this mess.

Feature request by Ray Quinn (1:214/23)

from NOTICE to INFO, per Nelgin

We only support platforms where slash is a legal path separator.

SpiderMokey is now built with ctypes, but the object is only
being created in jsdoor for now.

Needed for text.dat support in SBBSecho

load_cfg really should be made either a static library or an exported
function from libsbbs.so that everything reuses. Kind of silly to be
recompiling and linking these files with every app now.

Thanks to Dan_C for the head's up that SBBSecho stopped (very recently) successfully sending notices to users about received netmail or echomail.

Inspired by jsdoor's equivalent change.

For DesotoFireflite (VALHALLA)

- InternetMailReceived
- InternetMailForwarded
- FidoNetMailReceived
- WithAttachment
- FidoEchoMailReceived

For The Millionaire, closing issue #254

The first string (suppressed with %.0s) is an optional date/time stamp.

This also deprecates (removes support for) the [mail] NewMailNotice and ForwardNotice keys from sbbs.ini.

Addresses issue #350.

Also fixed up the alignment of the header/columns.

CID 349724

CID 319034

CID 174261

CID 174223
CID 174227
CID 174461
CID 174519
CID 229602
CID 319040
CID 319137
CID 319159

CID 33213

CID 33212

CID 33210
CID 33211

CID 33207
CID 33208
CID 33209

CID 33205

CID 174474

CID 319135

Fix the return value of js_socket_sendfilesocket() while we're here (off_t instead of int).