When there are no chat action sets or an action set has been deleted, bad
things would happen (e.g. segfault) when listing chat channels.

To be more consistent in syntax and include more details (e.g. the command
being invoked).

Address issue reported by Nightfox via DOVE-Net:
Today I was using the Archive class to extract exactly one file from a zip
file, and I'm a little confused on the exception throwing behavior regarding
the max_files parameter.  When calling extract(), I gave it a filename pattern
and expected exactly 1 file to be extracted, so I also gave a max_files
argument as 1.  It extracted the one file, but it threw an exception with the
error "Error: maximum number of files (1) extracted (after extracting 1 item
successfully)".

Should that be an error condition to throw an exception? I expected 1 file to
be extracted, and that file was extracted successfully.  If I specify max_files
as 2, then it doesn't throw an exception.   

Local sysop can always deleted/edit entries (now).
Fixed checking of can_edit() return value (string or true), fixed issue #425
as reported by Craig Hendricks (thank you)

DDMsgReader: Deleted messages can now be un-marked for deletion from the message list with the U key (if the user has delete permissions). Also, the reader now honors the system setting for whether users can view deleted messages.

See merge request !203

DD area choosers: Updated the lightbar help text to be more consistent with DDMsgReader

See merge request !204

DDMsgReader: Deleted messages can now be un-marked for deletion from the message list with the U key (if the user has delete permissions). Also, the reader now honors the system setting for whether users can view deleted messages.

As pointed out via DOVE-Net by DesotoFireflite (VALHALLA):
When xtrn_sec.* display file/menu is used, there's no auto-generated
prompt (with a default section number indicated). So hitting Enter
in this case and having the previous/default program section selected
would be surprising behavior to a user. So, only support a default
section selection when there was no xtrn_sec.* menu/display file.

Some unused/padding bytes are written as 0xff, so don't build strings from
those chars.

1. It's a non-printable char
2. It's the Telnet IAC byte value
3. CNF files use this as an "uninitialized value" indicator

Fixes issue #421

DDMsgReader: Mouse click support for the bottom help lines in scrollable mode (thanks to help from Nelgin)

See merge request !202

Eric Oulashin authored 2 years ago and Rob Swindell committed 2 years ago

DDMsgReader: Mouse click support for the bottom help lines in scrollable mode (thanks to help from Nelgin)

Accomplished by manually removing #define HAVE_BCRYPT_H 1 from config.h and rebuilding using MSVC/Visual Studio IDE. Try as I might I couldn't get the CMakeLists.txt changes (e.g. setting ENABLE_CNG to OFF) to take effect, but this seems to have worked.

Why? Because Windows XP didn't include bcrypt.dll (a Microsoft DLL) and we don't really need it as we don't support password-protected ZIP files anyway. <shrug>

As reported by cadeon on Vertrauen, Synchronet v3.19 hasn't worked on Windows XP due to error:
'The procedure entry point inet_ntop could not be located in the dynamic link library WS2_32.dll'

SlyEdit.cfg: Changed the saveColorsAsANSI value to false. Synchronet does not word-wrap messages with ANSI.

See merge request !200

DDMsgReader: Fixed a few errors (a couple related to "use strct", and a couple new errors related to deleting a message, upvoting, and viewing tallies).

See merge request !201

Fixed a few errors (a couple related to "use strct", and a couple new errors related to deleting a message, upvoting, and viewing tallies).

http://wiki.synchro.net/config:webv4

DDMsgReader: Fix for undeclared variable assignment when saving a message to the BBS machine

See merge request !199

DD file area chooser: Lightbar mode fix for not actually moving to the user's selected directory when directly choosing a directory in their library

See merge request !198

DD file area chooser: Lightbar mode fix for not actually moving to the user's selected directory when directly choosing a directory in their library

I think this is what nelgin/Keyop was asking for via IRC.

If we detect a client disconnection and terminate DOSXTRN.EXE, don't try to open DOSXTRN.RET and log an error when the file doesn't exist (as would be expected).

Broken in commit 082a9fce 3 years ago, the 'H' (highest ranked) message listing was showing the rank of the message (e.g. 1-20) instead of the message number itself.

DDMsgReader: Fix for undefined bottomMsgIndex when going to a message in the lightbar list, and strict mode fixes

See merge request !197

Eric Oulashin authored 2 years ago and Rob Swindell committed 2 years ago

DDMsgReader: Fix for undefined bottomMsgIndex when going to a message in the lightbar list, and strict mode fixes

Note: this centering logic does not know the expanded-size of the @-code, so use a fixed-length @-code (e.g. with padding) or use the 'C' @-code format modifier instead.

Fix issue #418