The recipient net-addr/type was always being over-ridden a bit further down in the code. Don't do that.

Also, log a message (sbbsecho.log) indicating that a message was forwarded ("Forwarding message ...").

For geneb.

If text/menu is a symlink (on *nix), then the path above would actually
point to a filename in the parent of the symlink target, which is not
what we want (we want the filename in the text dir). Fixed by using
FULLPATH.

Revert the previous change to the mailsrvr (don't try to parse the MS Outlook singled-quoted names in to/from header fields).

Instead, use the new matchusername() to perform a liberal name match against the name portion of the destination email address and if it matches, go ahead and use the quoted-name field. Otherwise, use the name portion of the destination address as the TO field for the FTN netmail message.

- Ignore all non-trailing non-alphanumeric characters when comparing a string against a user's name. Previously, spaces and dots and underscores were mostly-treated as equivalent and white-space was sometimes compressed for comparison purposes (if the user name contained both spaces and dots). This updated algo helps to insure that deliberate or accidental name collisions cannot be created but also aids usability (e.g. users can make some minor cosmetic adjustments to their user name and still be considered the "same user" for most comparison purposes).
- Terminate the comparison string at an '@' (ignore everything after). This resolves the FAQ of why users can't login with "username@domain" and aides some other username/address matching algorithms (e.g. in the mailserver). '@'s are illegal characters for usernames already.

Expose the new algorithm via new function matchusername().
Use the algorithm in matchuser() and lookup_user().

Unrelated: don't lower-case the 'localuser' part of email addresses in  usermailaddr() - cosmetic only.

instead of the potentially-alias'd delivery address. The angle-brackets
(now included) appear to be standards-compliant.

This reverts commit d4ceeba3.

is_supported_netmail_addr() actually takes the system configuration and QWK routing table into account. No sense forwarding to a non-deliverable address.

Replace use-of/linking-with wsock32.lib with ws2_32.lib to fix issues such as this one coming-up with the HAProxy feature merge:
unresolved external symbol __imp__inet_pton@12 referenced in function _xpms_accept 

There's no new opt-in option for this new feature - maybe there should be.
For geneb.

This requires anything that includes sbbs.h to have cryptlib and
mozjs already built/isntalled... to track this, I've added the new
extdeps.mk file.

This is pretty terrible though... not sure how important that
dependency really is.

Parse single-quoted "name" portion of email-addr header fields. I don't think this is going to fully solve the issue with FTN netmail gated to SMTP and replied via Outlook, but it's a start. Try that Nelgin.

This is because it includes js_version.h if JAVASCRIPT is defined,
and JAVASCRIPT is defined for everything using CFLAGS.

It may be worth re-working the JAVASCRIPT define, but that's a bunch
of extra work.

This is the first (and easiest) step in getting parallel builds
working.

Then, add JSDOC support to crypto class constant objects.

Also, since crypto stuff is almost half of all the docs, move all
the crypto classes and objects to the end. It would be nice if these
massive lists were hidden by default line the menu tree at the start.

Previously, properties were only supported via the TinyID mechanism
in the JS API.  This limited the properties to have a unique signed
8-bit integer ID, which prevented more than 256 properties from
existing in a built-in object.

The id value can be a name however, a TinyID is not required.  For
property descriptions with an ID outside the range of 8 bits, define
them using just the name.  When this is done, the getter and setter
functions will need to convert the names to an ID themself.

This isn't ideal... ideally, each would have a unique getter and
setter, but doing it this way puts of requiring an internal JS API
refactor and allows the CryptCert class to have all the defined
properties.

As implied... CryptCert now supports all properties, and JS Docs
will be created for them.  This section is yuge!

Copy/paste without the update required a single character to have
seven different values... which is unlikely to actually happen.

Have js.on_exit() throw an exciption with a useful(?) error when the
scope already has private data, and that data is not an on_exit list.

This fixes #182.

This behavior was cut/pasted from xtrn_sec.js but doesn't play well with logon events (e.g. SBBSIMSG list) that should pause before a following CLS. As reported by altere on the I, the R, and the C.

Count the read mail-waiting and compare to the total mail-waiting and if they're the same, then default to "No" for the "Read Your Mail Now" prompt during logon.

Also, pass the difference (the unread mail) to the LiMailWaiting logon-info line.

As requested by altere via I.R.C.

QUERY_STRING is defined (even if blank).

Always define it.

Previously, the console would be left in "raw" mode after invoking
'jsexec -d <module>'.

Added options -A[filename] and -S[filename] to allow more control over which output streams go where (for mlong and his troubles with running ircd via systemd).

-A controls "all messages" either sending all to stdout or the specified filename. This override the automatic suppression of the console output stream when run without a controlling TTY.

-S controls "status message" (includes non-error level log messages), either sending the status messages to stdout or the specified filename. This also overrides the automatic suppression of the console output stream when run without a controlling TTY.

If an .ini file is read by either the iniGetObject() or iniGetAllObjects() methods and contains a key with a blank value, that property would be created with an "undefined" value.

Both the iniGetObject() and iniGetAllObjects() methods now accept an additional Boolean argument (which defaults to false), to specify that "blanks" are acceptable. When the "blanks" argument is true, then keys with empty values in the .ini file are created as properties with empty string values (length of 0).

This is going to be useful for modopts.js to read potentially-blank strings from modopts.ini and differentiate between a blank string key and a missing key.

When a preexisting node.log file is found, a terminal server crash is suspected. Include the timestamp of the node.log in the message appended to the system log (data/logs/*.log) to help identify the likely time of the crash.

when there is no "template directory" selected/configured.

When posting to "All" or replying to a message that was posted by networked (not local) user, don't attempt to search for that username in the local user base to inform them of the posted message to them.

savemsg() is the underlying C function for saving a new message (mail or post) to a message base from several places, including JS modules. If there was no "charset" specified in the passed message header, check to see if the message body text is non-ASCII but valid UTF-8, and if it is, set the FIDO_CHARSET header field to the appropriate UTF-8 charset identifier string. This would *also* address Issue #177 reported by Michael J. Ryan. It's possible, but unlikely, that a message text would contain valid CP437 that *also* happened to be valid UTF-8. If that does happen to occur (e.g. in posted ANSI art?), we might want to revert this enhancement to savemsg() and leave to the caller's to detect/specify the charset, always.

For Windows release (CI) builds.