See sbbs_t::logon() for example

Note: the client.protocol is still "SSH" here (not "SFTP"). Perhaps that
should be changed?

Does any client actually support simultaneous "SSH" and "SFTP" sessions over
the same socket?

Found by Coverity.

The array overrun crashed Win32, the asprintf() usage imacts glibc
and the other warnings are impossible (an exception would have been
thrown).

This includes the "OK" error, and numerous other normal errors,
so most of them are logged as LOG_DEBUG.

Also fail early if parsing underruns root.

This Win32 function behaves differently on Win32 than *nix, and
does not do what we want.

Instead, copy the important bits from xpdev, and resolve a TODO.

Oops, missed this with the cl32.dll commit.

I'm not clear on why MSBuild can build the solution without this but the IDE
cannot (results in sftp.lib not found, unresolved SFTP symbols, etc.).

<Deuce> Ok, Win32 will need a new cryptlib with these latest patches.

Deuceth commandeth, Robeth doeth

If a filename failed to be added for a readdir response, it would
have just skipped that file and continued with the files around it
rather than reporting an error.

DDLightbarMenu: When writing an item with UTF-8 text, check ANSI support before moving the cursor (and this is important if the menu is being used in non-lightbar mode)

See merge request !419

DDLightbarMenu: When writing an item with UTF-8 text, check ANSI support before moving the cursor (and this is important if the menu is being used in non-lightbar mode)

The /vfiles root uses the configured virtual paths as in the FTP
and web servers.  These paths should be shorter than the ones used
in /files, and also have the benefit of translating slashes so
users will not need to type a Big Solidus if they're trying to
type long lib or dir names.

This should speed up directory listings over higher latency links
by approximately 25×.

You're welcome nelgin.

This should fix the sftp hangs...
While FreeBSD will return EDEADLOCK when a mutex would deadlock,
Linux will do what I ask and deadlock.

Since we're not checking the return value of pthread_mutex_lock(),
this would go completely unnoticed on FreeBSD, resulting in the
mutex being unlocked early and all sorts of unprotected accesses
would happen, potentially doing crazy things.  On Linux it just
deadlocks, and taking a peek at the thread backtraces makes the
problem obvious.

So, point to Linux for making life more correct for people who
do incorrect things (locking without checking the return value).

I'd also like to thank nelgin, for sticking with me on this issue
and being my gdb puppet.

And really, this commit should be shared by all the contributors
who... 𝆺𝅥𝅮𝆺𝅥𝅮𝆹𝅥𝅯𝆹𝅥𝅯

This prevents the case where input_thread() accepts the sftp
connection and calls init_sftp(), then answer() does the same thing,
clobbering the previous state.

DDLightbarMenu: Fix for text & text column alighment issues with UTF-8 text

See merge request !417

DD File Lister: Fix for possibly no file description when adding to the batch DL queue. Also, fix for file description screen refresh (off by one column) for extended descriptions.

See merge request !418

DD File Lister: Fix for possibly no file description when adding to the batch DL queue. Also, fix for file description screen refresh (off by one column) for extended descriptions.

but does not yet have a session type.

Also, fix what appears to be a fairly blatant memory leak.

If there's an error setting the channel or getting the channel
type, give up on the session immediately.

In this case, just accept whatever we get info on as the "first" one.

Likely fixes #728

The search seems to be backward by default (at least when listing a
sub-board), so should look into that. But at least now you can find
replies that include a "re:" prefix easily.

Searching by thread should be added too.

If the SSH_ANYAUTH option is set, the server will accept the "none"
authentication method, and not even suggest the client send a
password or public key.

The client must still send a user ID, but we just ignore it
completely and don't even log it.

This blindly accepts whatever authentication the remote offers, but
does not log into the BBS, dropping the user at the login prompt
instead.

Closes #726

You're welcome Keyop.

The other 500 times are implied.