Confirm with user before adding someone to twitlist

See merge request sbbs/sbbs!16

The default terminal columns (still 0/auto) can be overridden with the 'L' command from the user defaults menu. 

Also increased maximum manual terminal rows setting from 99 to 999 - this involved moving the record in user.dat, though the old record value is auto-migrated.

This is useful for detecting blank records.

Putting IP addresses first.

Probably only a problem on Vertrauen, but some QWKnet nodes, for some unknown reason, like to FTP-connect multiple times concurrently and request to download a QWK packet. This creates a race condition where the QWK packet gets created/downloaded/deleted before the second FTP connection can successfully download the same file, thus logging an error "opening file " on the server (VERT). So if the pack*.now file already exists, reject the download request. "What are doing?" is what I really want to ask these nodes, but better just throw them an error response and quietly move on.

Beautification for 40 column terminals.

Log the IP address first in most log messages.
Condense white-space in log messages to a single space.
Log the server IP address of incoming connections.
(more) Intelligent email address enclosure in angle-brackets.
Better duplicate address comparison (just for log message).
Fix wrong order of lprintf arguments in !UNKNOWN USER log message (new bug).

Created a function to condense all white-space in a string to single space-characters (e.g. Yoda).

Fix another typo that crashes the script

See merge request sbbs/sbbs!15

Like the Terminal Server, don't count authenticated connections against the MaxConcurrentConnections limit.

Only authenticated users with passwords (not Guest) count as authenticated connections.

When enforcing the MaxConcurrentConnections limit, don't count connections for user's with blank passwords (i.e. Guest) as authenticated.

This message can be logged when a sysop is prompted for the system password and enters it incorrectly or just disconnects.

So lower the log level to DEBUG. And include the IP address that we searched for too.

This might not be so great for IPv6 connections (let me know).

Also, use macro for the maximum received SMTP bad command magic number.

Fix-up the sender and recipient info included in log messages in the sendmail thread too.

Bumped rev to 1.735.

Weird that no mail server has ever complained; I guess they're all prettty
"liberal in what they accept".

Also, eliminated an unnecessary strcpy() call.

The Linux lock() implementation in xpdev/filewrap.c requires that
_FILE_OFFSET_BITS is set to 64 or else OFD (sane) locks are not
used on Linux, defaulting back to the crazy per-process file region
locking of Linux of old. This was done in this commit:
http://cvs.synchro.net/commitlog.ssjs?99999#39639
because:
https://patchwork.kernel.org/patch/9289177/

but on 64-bit Linux, large file support is assumed and you don't
actually need to define _FILE_OFFFSET_BITS, we're peforming this
check for 32-bit Linuxes. Perhaps a check to see if sizeof(off_t)
== 8 would have been better. However, this change enables OFD
Locks for *all* flavors of Linux (not just 64-bit) - so that's
better.

Why do we care? Because using region locks on the same file in
a multi-threaded program doesn't really work right on Linux without
using OFD Locks. I saw this problem with receiving multiple
simultaneous emails in the mailserver and getting smb_locksmbhdr()
errors/failures when trying to save the message data or headers
of the one or more messages every time GitLab would send email
out to those whoe have opted-in to received email notifications
upon gitlab.synchro.net activity.

Option for bullshit bulletins to have it display only new bulletins at logon,...

See merge request sbbs/sbbs!12

Kayz authored 4 years ago and Rob Swindell committed 4 years ago

Option for bullshit bulletins to have it display only new bulletins at logon, but show all at other times (from external program menu)

And separate the saved/imported message text into body and tail (separate SMB msg data fields) automatically to exclude signatures from quoted text.

As requested by Tracker1.

This allows a .sig file to contain "\n-- \n", the "standard" USENET signature delimiter, as requested by Tracker1.

Fix typo

See merge request sbbs/sbbs!14

Removed the yield line interval (this is a questionable setting anyway).

Also, made the unlimited max-connections display as "N/A" (instead of
"0") in the Terminal Server config dialog.

Cleans both debug and release build dirs.

The mail (SMTP) server is a popular target of bots. Impose a maximum-concurrent-connections limit (optionally). Similar to the terminal server option, except, don't deduct the number of authenticated connections (I can add something like that if desired). The new config option is [mail] MaxConcurrentConnections in the ctrl/sbbs.ini (defaults to 0, no maximum).

Fixed error responses in mail_server accept loop: was always sending POP3 error responses even if the connection was SMTP.

Cleaned-up the service/port checking/logging in the mail_server accept loop: no strcmp() needed, log the protocol name (e.g. "SMTPS") instead of the service name (e.g. "submissions").