As pointed out via DOVE-Net by DesotoFireflite (VALHALLA):
When xtrn_sec.* display file/menu is used, there's no auto-generated
prompt (with a default section number indicated). So hitting Enter
in this case and having the previous/default program section selected
would be surprising behavior to a user. So, only support a default
section selection when there was no xtrn_sec.* menu/display file.

Some unused/padding bytes are written as 0xff, so don't build strings from
those chars.

1. It's a non-printable char
2. It's the Telnet IAC byte value
3. CNF files use this as an "uninitialized value" indicator

Fixes issue #421

DDMsgReader: Mouse click support for the bottom help lines in scrollable mode (thanks to help from Nelgin)

See merge request !202

Eric Oulashin authored 2 years ago and Rob Swindell committed 2 years ago

DDMsgReader: Mouse click support for the bottom help lines in scrollable mode (thanks to help from Nelgin)

Accomplished by manually removing #define HAVE_BCRYPT_H 1 from config.h and rebuilding using MSVC/Visual Studio IDE. Try as I might I couldn't get the CMakeLists.txt changes (e.g. setting ENABLE_CNG to OFF) to take effect, but this seems to have worked.

Why? Because Windows XP didn't include bcrypt.dll (a Microsoft DLL) and we don't really need it as we don't support password-protected ZIP files anyway. <shrug>

As reported by cadeon on Vertrauen, Synchronet v3.19 hasn't worked on Windows XP due to error:
'The procedure entry point inet_ntop could not be located in the dynamic link library WS2_32.dll'

SlyEdit.cfg: Changed the saveColorsAsANSI value to false. Synchronet does not word-wrap messages with ANSI.

See merge request !200

DDMsgReader: Fixed a few errors (a couple related to "use strct", and a couple new errors related to deleting a message, upvoting, and viewing tallies).

See merge request !201

Fixed a few errors (a couple related to "use strct", and a couple new errors related to deleting a message, upvoting, and viewing tallies).

http://wiki.synchro.net/config:webv4

DDMsgReader: Fix for undeclared variable assignment when saving a message to the BBS machine

See merge request !199

DD file area chooser: Lightbar mode fix for not actually moving to the user's selected directory when directly choosing a directory in their library

See merge request !198

DD file area chooser: Lightbar mode fix for not actually moving to the user's selected directory when directly choosing a directory in their library

I think this is what nelgin/Keyop was asking for via IRC.

If we detect a client disconnection and terminate DOSXTRN.EXE, don't try to open DOSXTRN.RET and log an error when the file doesn't exist (as would be expected).

Broken in commit 082a9fce 3 years ago, the 'H' (highest ranked) message listing was showing the rank of the message (e.g. 1-20) instead of the message number itself.

DDMsgReader: Fix for undefined bottomMsgIndex when going to a message in the lightbar list, and strict mode fixes

See merge request !197

Eric Oulashin authored 2 years ago and Rob Swindell committed 2 years ago

DDMsgReader: Fix for undefined bottomMsgIndex when going to a message in the lightbar list, and strict mode fixes

Note: this centering logic does not know the expanded-size of the @-code, so use a fixed-length @-code (e.g. with padding) or use the 'C' @-code format modifier instead.

Fix issue #418

DDMsgReader: Scrolling ANSI and "use strict" improvements

See merge request !195

Also, the logic to check if the user could even view deleted messages (on line 912) was wrong, replace with new method: can_view_deleted_msgs().

As requested by deon (ALTERANT).

Graphic is now only used when using the scrollable interface. Also, when creating the Graphic, now subtracting 1 from the reading area height to avoid making the Graphic one line too tall to avoid unnecessary scrolling.
When saving messages with ANSI codes, Graphic is only used if the message has any ASCII drawing characters. (not sure if this really matters much though).
Also, applied "use strict" and made some changes as necessary.

SlyEidt: Added the ability for the user to choose text color/attribute codes.

See merge request !193

DD file area chooser fix: Listing libraries without first listing directories...

See merge request !194

Synchronet uses "extended normal" mouse reporting for mouse support
(e.g. menu/display file clickable "hot spots"). Many of the JS scripts
that predated Synchronet's own internal mouse support would send their
own mouse-reporting enablement and disablement ANSI sequences and the
terminal could become out of sync with the expectations of the script
(i.e. it would not necessarily disable the mouse modes that had been
set by SBBS before enabling its own preferred mode).

And some scripts (e.g. Synchronet Minesweeper) use a mixture of Synchronet
hotspot support and direct mouse click coordinate reporting, so it was a
mess going between different mouse reporting modes at different times in the
same script.

This all came to light as a result of the fix for issue #412: using mouse
button releases rather than presses to trigger a hotspot.

So mouse_getkey() now has as a separate "release" property it sets in the
return value. Right now its always the opposite of "press", but I can imagine
some mouse tracking modes where movement might be reported with neither a
button press nor release event.

Anyway, Nelgin, give this a try and see if it resolves the issues you were
reporting in IRC with avatar chooser mouse support.

A single source of truth is now used for SBBS's mouse mode (MOUSE_MODE_ON). A JS script doesn't need to know what SBBS's preferred/default mouse-enabled mode flags are, just set to this property to "true". Setting to "false" is the same as setting to MOUSE_MODE_OFF (0).