Default the progress time interval to 500 milliseconds (twice a second).

Don't specify a count/call interval in the call-sites, since we really want to use time-based progress updates now only and the default probably will work fine everywhere.

To send less text over slow (e.g. 4800bps) modems. For Nelgin.

This makes the interval argument unnecessary I think.

system.illegal_filename() - check if contains illegal chars/sequences
system.safest_filename() - check if contains only safest chars
system.allowed_filename() - check if meets criteria from SCFG->File Options
system.check_filename() - check if legal and meets configured criteria and is not in file.can
bbs.check_filename() - ditto, except will display badfile.msg as appropriate

Now scripts can utilize the sysop-controlled filename criteria and security of the BBS.

Also remove "JavaScriptContextStack" (no longer used) and other
wrong or obsolete comments.

to be compliant with FTS-5006 which states "The name must be in 8x3 DOS format".

I'm not converting the filename to ALL CAPS, since that's not explicitly stated
and really should not be a problem.

This also generates an Lfile key if the generated-DOS-compatible filename
does not exactly match the actual filename in any way (not just length).

Only in debug builds.
If this check fails, then we may be producing/using potentially un-terminated strings and need to do something about that. By default, xpdev/genwrap.h redefines snprintf() as safe_snprintf(), so this check *should* always succeed.

The default is 'size' parameter value is 12 characters, not 13.

If an extended description contains nothing but Ctrl-A codes and white-space, don't display it in a file listing (in place of the normal short description).

Based largley on martylake's provided patch set. By default, assumes
all IRC messages are UTF-8 encoded and will translate to CP-437 if
appropriate or send as UTF-8 if the user's terminal supports it.
Set utf8_support=false in the [irc] section of your ctrl/modopts.ini
file if you wish to disable this behavior.

Remove JavaScriptContextStack (no longer used).
Add *Sound keys to the [Global] section.

Apparent copy/paste error in sbbs_set_sound_settings() - I was wondering why the HangupSound key wasn't saving to the sbbs.ini file from SBBSCTRL.

This is an experimental feature that's been in the code for quite a while without any supporting help/docs (there was the original commit message, I'm sure). I'm not sure how much value this feature is without providing automatic access to the *files* within the sub-directories, but there you have it.

"Request for x is outside of the web root" was already logged (with a "NOTICE" log level), but would not sound the hack attempt alarm (on Windows) or log to the hack.log. Now it does.

file_area.web_vpath_prefix
file-metadata-object (return value of FileBase.get()).vpath

These methods also (optionally) accept a file-meta-object as an argument.

Similar to the ctrl/ftpalias.cfg file, the new ctrl/web_alias.ini file (optional) can be used to map a portion (the first portion, only) of a web request path to a different physical or virtual path. For example, I'm using it to map:
/Synchronet/ = /files/main/sbbs/
for filebase access to my main->sbbs directory of Vertrauen's filebase using a /Synchronet/* web request (i.e. for slightly prettier or shorter custom URLs, if desired).

Now supports message sub-board & file directory name collapsing

See merge request !134

By setting SCFG->File Options->Web File Virtual Path Prefix to something (e.g. "/files/"), all HTTP or HTTPS requests to the Synchronet Web Server with request paths beginning with this prefix will be interpreted as filebase access requests (with full access control enforcement). This is configured here (in SCFG) rather than, say, the [web] section of sbbs.ini, because I have plans for the terminal server to use this prefix to generate Web-URLs for files to display or email to users.

Currently, only requests to *files* (for download) are supported (no index generation, file information, etc. and definitely no upload support). Full access control (using HTTP auth, not cookies) is used for libraries and directories with controlled access. Credits are deducted and awarded and uploaders are notified of downloads, as one would expect. Requests to any dynamic-web-content files (e.g. .SSJS, .XJS, etc.) will be treated as static file download requests (no script will be executed).

I'm reusing the same virtual path parsing logic from the FTP server (moved to the userdat lib), so the virtual path to a file for download would be, for example, http://yourdomain/files/lib/dir-code/filename.ext

The main motivation for this feature is: FTP-links in email and web pages are just not useful to many users these days and I don't think that sysops should have to rely on a SSJS web UI (e.g. ecWebv4, cool as it is), to provide web-access to the filebases. Using this feature, you can share simpler/shorter web links to your files that will be more enduring.

file directory and message sub-board lists for ones with common groups, adding a 3rd
tier of options.  For example, if you have the following file directory structure:
BBS files
  DOS: BBS software
  DOS: BBS doors
  DOS: BBS utilities
  Windows: BBS software
  Windows: BBS doors
  Windows: BBS utilities

With directory name collapsing, the selection will be come 3 tiers, as follows:
BBS files
  DOS
    BBS software
    BBS doors
    BBS utilities
  Windows
    BBS software
    BBS doors
    BBS utilities

lord2.js line 3168: ReferenceError: bs is not defined

Added a load for 822header.js.  Whoops.

See merge request !133

Version 1.42: Fixed attachment downloading (most importantly).

See merge request !132

So change the (A)dd command to (C)reate here. Leave 'A' as an alias.

Also, the first attempt at converting HTML entities in HTML-formatted messages (not working 100%).
Also, added the ability to sort the message list by date & time written rather than the import date/time.
This is specified in the configuration file via the msgListSort option.

CID 345291
It's actually a false positive because if an extension (".suffix") exists in filespec, it must also exist in newfilespec since it's a copy, but whatever. It's better form to check.

libarchive apparently cannot be used for in-place modification of (e.g. adding files to) existing archives, so if a bundle already exists, this code would over-write it with a new archive containing just the latest packet. Issue reported by acn (IMZADI) via DOVE-Net.

I could and might create an update_archive() function which extracts and re-creates an archive with additional files, but since I don't have that yet, just disable this for now and always use an external archive utility to create or update bundles (so again, an "Archive" configuration is required in your sbbsecho.ini file, which you most likely already have).

Not sure why, as this utility has been deprecated. :-/

warning: ‘%s’ directive writing up to 4096 bytes into a region of size between 4034 and 4097

When searching descriptions for text, include these new metadata fields in the content to search.

Wouldn't work with the new filebase if you tried to use it anyway. Just noticed while watching the v3.19b new feature video that the [.alt_path] was still listed as a command-line option.

(e.g. type "HELP") to get help on string commands, including sysop
commands. File Transfer related sysop commands *not* available via
this command shell however (there's just the one/main menu, so no
"File menu" context from which to execute string/sysop commands).

For nick (in #synchronet at irc.synchro.net).

Default to 64 characters. Maximum value is 65535 characters, but filenames larger than 64 characters may be problematic (e.g. searching for them, displaying them, security concerns), so only increase with caution. Shorter values are fine, but 0 will just revert back to the default.

Prefixed or trailing white-space characters would be hard to discern without this.

These git diff stats are a bit misleading as a lot of files were removed from the git repo and some 3rd party libraries were added.