Eric Oulashin authored 1 year ago and Rob Swindell committed 1 year ago

DD Upload Processor: Scan failure output is now logged to the system log instead of outputted to the logged-in user

A "prepped" means directory means a relative path from the configuration files
(or default settings) has been converted to a full/absolute path with proper
slashes for the platform (i.e. backslashes instead of forward-slashes on
Windows).

JSexec doesn't require that the new v3.20 ctrl/*.ini files exist to run; this
was necessary to be able to run 'jsexec update -> upgrade_to_v320.js' which
does the ctrl/*.cnf to .ini file conversion (egg not required to build
chicken). When JSexec failed to load ctrl/msgs.ini
(e.g. "!ERROR loading configuration files: 2 (No such file or directory)
opening /sbbs/ctrl\msgs.ini"), it would continue to run, but not "prep" any
of the "path" settings (e.g. exec_dir).

The first run of 'jsexec update.js' would fail to run upgrade_to_v320.exe
(which does the v3.20 user base conversion) and a bunch of other (but not as
important) update steps because Windows couldn't execute "../exec/*".

Multiple errors would be displayed in this case, but the most important (as
reported by Ree in #synchronet of irc.synchro.net) was:
  '..' is not recognized as an internal or external command

right after the status output:
  No v3.20 user base found, running ../exec/upgrade_to_v320

Notice the "../exec/" prefix, which is not support by Windows when specifying
a file path to execute.

A second run of 'jsexec update' would work fine because the new v3.20 .ini
files would be successfully created after the first run (though the user base
was not).

This is likely the same issue that MRO reported recently when upgrading a
Windows SBBS v3.19 install to v3.20 and not having the user base upgraded
the first time.

Fixed a typo in the DD Upload Processor readme.txt

See merge request !306

DD arc viewer & upload processor: Refactor of how the configuration files are read. Arc viewer: Control characters are no longer needed for color settings.

See merge request !305

Eric Oulashin authored 1 year ago and Rob Swindell committed 1 year ago

DD arc viewer & upload processor: Refactor of how the configuration files are read. Arc viewer: Control characters are no longer needed for color settings.

DD Upload Processor: Now supports Synchronet's built-in archive support to extract archive files

See merge request !304

get_ansi_seq() here can return null, don't pass that value to mqtt.publish()
which gets converted to a string.

... for when your terminal and the node client terminal don't use the same
character set. Only CP437 and UTF-8 addressed in this commit, not PETSCII
or plain ASCII.

This was never possible before MQTT.

For read-only spying, the mqtt_spy.js module can be used via jsexec (from an
OS shell command prompt), similar to mosquitto_sub.

For read-write spying, just use the ;SPY sysop command as before and if MQTT
is configured/enabled, it'll use MQTT rather than sockets or shared memory
queues to spy on the target node.

For the first time, you can spy between nodes that are on different servers of
the same BBS using the ;SPY sysop command.

Passes through ctrl characters (except Ctrl-C), unlike the built-in spy
function. This could be revisited later or made optional, but it sems to make
sense to allow Ctrl-Z (e.g. to save a message in fseditor.js) to be passed
through to the target node.

As reported by Deon on DOVE-net, when the call to socket_recvdone() returns
true (socket is disconnected and all data has been recv()ed), dial() would
report "NO CARRIER" but leave the open socket opened, thus preventing any
subsequent dial attempt ("Can't dial: Already connected" and "ERROR").

Also removed the source file path/name from the debug print statements - don't
need that noise.

Incremented the version to 0.4

This allows directly setting bright foreground and background colours
rather than using bold and blink to indirectly modify them.

These do not have an effect if the desired mode is not possible
(ie: no bright background, no bright foreground).

Fixes SF issue 118

DDMsgReader: In the theme configuration file, use a : as the separator for...

See merge request !303

For example, if it was set to 0.4, the initial scaling would be set
to take at most 40% of the screen height or width (whichever is
smaller) with a minimum of 1.0

SlyEdit: Improved quoting (formatting) for the various quote prefixes (using a > character)

See merge request !302

DD File Area Chooser fix for directory collapsing mode when using the lightbar interface.

See merge request !301

There's a few ASCII control codes that need to be translated, so
add a new mapping function that tries the map first, then returns
ASCII on failure to map.

Fixes inability to use ATASCII in curses mode.

Previously, both the shift key, and the "implied shift" from CAPS
were treated as a higher priority than the CTRL modifier.  With
this change, only the explicit shift key has priority, and the
implicit one is only checked after CTRL is checked.

Fixes SourceForge bug 117

Requires hex literals for control chars instead of octal
(e.g. \x01 instead of \1)

All stock scripts should be using strict mode, so this was a miss.

I keep reverting/un-reverting the merge that includes an unrelated logon.cpp
change. So just manually remove this new code that was added to attempt to
fix issue #402 since I incorrectly concluded that sockopts.ini wasn't being
applied to new sockets created with ListeningSocket().

This reverts commit 110326c7.

We're already passing a sock_init callback (ls_cb) which is supposed to set
the socket options (call set_socket_options), so this change shouldn't be
necessary and reportedly caused more issues binding ircd sockets when running
ircd.js via jsexec (though I didn't see this myself).

This reverts commit 5f1ab933.

Wrong commit reverted. Oops.

This reverts commit ce1946fa.

This reverts commit 4a83f908.

We're already passing a sock_init callback (ls_cb) which is supposed to set
the socket options (call set_socket_options), so this change shouldn't be
necessary and reportedly caused more issues binding ircd sockets when running
ircd.js via jsexec (though I didn't see this myself).

I saw my logon.jsonl file getting cycled multiple times a day recently on Vert
and suspect this function call may have been failing.

This socket constructor did not get the global socket options treatment when
created (years ago).

This should fix issue #402 as reported by Nelgin and more recently by Keyop.

DD Archive Viewer now supports the built-in Archive class in Synchronet 3.19

See merge request !299

If the search up the scope tree for js.exec_dir fails, the script 'path' would
be left blank leading to a weird error message.
e.g. !JavaScript default.js line 249: Error: Script file () does not exist