While SBBSecho would notify local users of imported messages addressed to
them (both EchoMail and NetMail) and QWK-imported messages recently gained
the ability to notify local recipients of messages addressed to them, other
methods of posting messages (e.g. just using the normal terminal server
method, e.g. the 'P' command) or using any JavaScript (e.g. web) methods of
posting messages lacked recipient notifications. So that's now fixed.
And for JavaScript-saved local email messages too. I don't *think* this will
result in any duplicate notifications of received messages, but let me know
if you see excess/duplicate notifications.
Anonymously posted messages are excluded.
Messages posted to yourself are excluded (who does that?).

The webv4 directory is now part of the repo, so install it to the
install target directory too.

When SYMLINK=1 is used, symlink the following directories (rather
than copying): docs, exec, text, web, webv4, and xtrn. This will
hopefully make subsequenit updating (via git) easier for most sysops that use
this installation method. Let the merge conflicts insue.

Added section headers to the main directory listing; the
meaning of each directory entry was unclear. (These use
the non-standard but commonly-used item type 'i'.)
Should satisfy issue #67.
https://gitlab.synchro.net/sbbs/sbbs/-/issues/67
This one's for all you folks who have QWK bulletins on your
systems and want people to be able to read them via Gopher.

for Mortifis

e.g. FILL:\x20 to fill with space (for Michael Long via USENET)

NETMAIL: user's personal netmail or email address - for WitNik
FWD: "On" if the user has opted for forwarding their mail to netmail or "Off"
TMP: user's chosen temporay file type (e.g. "ZIP")
NOTE: user's note (same as MEMO1)
LASTIP: user's most recent IP address at time of logoff

Users that have put their terminal node into anonymous state (e.g.
by using the ;anon command) should not have their identity exposed
to non-sysops. This flaw was reported by altere in #synchronet.

I'm not supporting translation of "Anonymous" here. We're not doing
that for anonymously-posted messages either (yet), so I figured that
was okay for now. There is a text.dat string for the word "Anonymous",
it'd be nice if we just reused that, maybe.

I also changed the node.status value magic number (3) to NODE_INUSE
since we're loading nodedefs.js anyway, might as well.

I'm not sure if it matters, but root/api/system.ssjs does not have
this anonymous check either. I'm not sure where that code is used.

If you can't open the *.web file, don't attempt to add that session data
to the returned users array.

The return value of getlastmsg() is displayed as the total messages in a
sub-board when scanning subs. For sub-boards that allow voting, use the new
smb_msg_count() function to determine the number of displayable messages.

If you have a stored errno value (or Socket.error), these are how you convert
that number to an error description.

Socket error descriptions on Windows can be quite long (e.g. > 128 chars) and
include punctuation, so include at the end of logged socket error messages.

If FormatMessage() fails on Windows (in socket_strerror()) return the
GetLastError() value in the error description.

Socket error descriptions on Windows can be quite long (e.g. > 128 chars) and
include punctuation, so include at the end of logged socket error messages.

Also, don't include "error" in the Error message.
Also, socket error strings can be quite long on Windows (e.g. >128 chars)
so place at the end of the Error message.

This enables much easier debugging of logged exceptions/errors.

Vote messages and poll closures are not displayed to users as messages, so
exclude them from the total "posts" returned from getposts(). This uses
the new smb_msg_count() function which is slower than simply checking the
size of the index file (*.sid) and dividing by the index record size. So
for sub-boards that don't support voting, use the old/faster scheme.

The inferred message type should match the stored message type. Confirm that.

Don't exclude polls form the message count used for max_msgs enforcement
during maintenance.

In support of message bases with vote-messages and poll-closures:

smb_msg_type() returns an enum smb_msg_type inferred from the combination
of attribute flags specified (should match msghdr_t.type).

smb_msg_count() calculates the number of message index records of the
specified type(s) (a bit-field) by reading the message base index file. This
value should only used for info/display purposes, so no locking is performed
to return the result as fast as possible.

This allows an accurate number of "posts" (posted *messages*) to be queried
and displayed to a user when appropriate (e.g. instead of
smb.status.total_msgs or just the size of the index file divided by the size
of an index record). In that case, since vote messages and poll closures
aren't displayed as messages to users, exclude those from the count to reduce
confusion. For message bases that don't support voting, this scheme is not
necessary.

only if there's not already a daily event already configured.

Also, I put this in my login.js:
if(client.ip_address == "::1")
     js.exec("jsdocs.js", {});

Altere reported that listing users with access to a sub-board with an Access
Requirement String (ARS) set to "SYSOP" would list all users as having access.
The problem was the use of the "SYSOP" macro which checks the *current* user
online (not the subject of the ARS check). Fixed by not using the SYSOP macro.

Apparently, some versions or configurations of Mystic BBS will include an
Origin Line in FTN NetMail messages. That would've been okay for SBBSecho,
except these origin lines do not contain an FTN address (in parenthesis).

So, firstly: when importing NetMail messages (subnum=INVALID_SUB), don't
attempt to parse any Origin Lines. Secondly, fix up the Origin Line parse
code a bit better detect the case when no FTN address is actually present.

Don't set the object's private data with freed data pointers.

Wow. This is another one of those "forever bugs".

Left it there, but commented out, just in case anyone needs it later.
But it was reported that the setcap line failed anyway:
Sep 24 09:20:15 bbs setcap[21466]: Failed to set capabilities on file
`/sbbs/repo/src/sbbs3/gcc.linux.*.exe.*/sbbs' (No such file or directory)
Sep 24 09:20:15 bbs setcap[21466]: The value of the capability argument is not
permitted for a file. Or the file is not a regular (non-symlink) file

At the request of alterego (ALTERANT), if a sub-board has a "post semaphore"
configured, signal (touch) it whenever a message is imported via SBBSecho into
that sub-board.

I changed the name from "Cyber-Net" to "CyberNet" because this value is used
as the 5D domain name which is limited to 8 characters. Everything else is
as Chad provided it.

Don't re-read the configuration - we already have it in memory, just pass it
by reference to createdefaults(), so we don't need the SBBSCTRL environment
variable (again). As reported by Michael Long via alt.bbs.synchronet.

Also addressed the truncation of the new user chat handle as reported by GCC.