My /etc/resolv.conf was wiped by Network Manager (gee, thanks), so
ircd.js was throwing the following unhelpful exceptions when starting
up:
Feb 25 13:47:51 git jsexec[19108]: !JavaScript : uncaught exception: Unable to create any sockets
Feb 25 13:47:51 git jsexec[19108]: !JavaScript : uncaught exception: Unable to create any sockets

First, instead of throwing a string, throw an Error object so we can
actually know where the exception ocurred. Please, everyone, throw Errors
not Strings.

Second, throw a different more helpful exception if there are no nameservers
specified in the DNS constructor or configured on the system.

DDMsgReader: Ctrl-C can now cancel message scans, and message scan status text is word-wrapped for the terminal width

Closes #522 and #523

See merge request !259

Eric Oulashin authored 2 years ago and Rob Swindell committed 2 years ago

DDMsgReader: Ctrl-C can now cancel message scans, and message scan status text is word-wrapped for the terminal width

They were too hard for me to read before, being all high intensity.

Remove the (now) unnecessary explicit initializations (e.g. to zero, blank, etc.) from the sbbs_t constructor.

Fixes issue #311

Also clarify "Internet e-mail" address (unrelated)

Apparently Paul made some changes (nobody reports these things).

... and use as reply-to address for any Internet-mailed node number
applications.

This fixes issue #456 reported by Nick Andre.

Configured in SCFG->System->Loadable Modules:
Scan Dirs:      User scans one or more directories for (e.g. new) files
List Files:     User lists files within a file directory
View File Info: User views detailed information on files in a directory

This addresses/fixes feature request #521 for Nightfox

Will need to document the mode argument bit values on the wiki, but
it's the usual suspects: FL_* for scandirs and listfiles and FI_* for
fileinfo. The scandirs_mod will be passed an extra bool (0/1) arg that
indicates whether or not the user is scanning *all* directories.

Test results would be welcome

Parameter names are -- prefixed, with a space between name and
value. Quotes etc. around values are not handled; use escapes.
We can get fancier with this later if it's necessary.

Example:

?wttr.js --fallback_location Toronto --cache_ttl 0

See readme.txt for details on modopts.d/wttr.ini.

Changed scope of ipFile variable so we can access it in the
finally{} block. Should prevent stale files hanging around if
the service encounters an error.

Ditch TTYLOC method; no longer needed. (Note: websocketservice's
UTF-8 handling rendered this unusable anyway.)

Remove rlogin/webv4 specific lookup method; no longer needed.

Scripts running on upstream (terminal) server can find actual
client IP in:

system.temp_path + 'sbbs-ws-' + client.socket.remote_port + '.ip'

Therefore, be it resolved:
Whereas more information is required,
Whereas such information cometh from log files,
Whereas this script should spew many messages into the logs,
The script shalt not cache any data for the time being, nor load
any cached data,
The script shall barf much data into the logs for purposes of
troubleshooting.

- King James III on the eve of his coronation, hand on bibble

from sysop input, automatically.

e.g. this a way to set the K_TRIM mode globally for all keyboard input

K_TRIM causes leading and trailing whitespace to be trimmed.
K_NOSPACE disallows any whitespace characters to be added to the string.

Previously, trailing whitespace was always trimmed. Now, only do that
if/when K_TRIM is specified.

The details (dates, author, revision numbers) are often stale and
misleading, so start removing them. Where the Revision tag was used
for a version/revision, just bump it by one and use a string constant
instead (Git doesn't provide any similar facility for auto-incrementing
revision numbers).

More remains. Perhaps a commit hook to alert me when committing that I should
clean up as I go rather than try to do this in bulk. <shrug>

When sending an SMB message header via SMTP or POP3, some header fields (lines) could potentially be longer than 1024 and yet sockprintf() was limited to sending 1024 bytes (actually 1022 plus CRLF). This could result in some messages not being sent correctly: header field truncated, not CRLR-terminated, and notably resulting in MIME message contents not being decoded properly in a message viewer/reader. Example (Content-Type is part of the previous header field/line):
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?cm9T1Q9G65VC/lKTTqhODKhy5lHT2y6WWMb/WyvJ+EeGEwYmY7ILhzE3yfNM?=
 =?us-ascii?Q?KeFWN9T/PqHBya1plKf/sHgaw0iRmI7Hq+u9Dp4bG8OqdniKQlK+Aa27oXMd?=
 =?us-ascii?Q?Hly6OEYaSu7jbhGGY89LF0gyRVqquqxkaMfpKvG+h4cQnnu4Tl8YAKeE39a2?=
 =?us-ascii?Q?lHW3372ulmb9jvvZU72J2RtZYkuoIr+Wsqhfyuj39wTZ/+C4qKCsYrmTxrki?=
 =?us-ascii?Q?fBZ4gMPzWkrcWAr7zPcXBg8bphJJB8VJFUjQyksA3EG4dtH8+TZeEcNNBmHf?=
 =?us-ascii?Q?oCGnV9wHr9HszzrSkkZ2GGyh3QZLHAVDNe7wDXSy7HJttZugf9kNqKGeaYQL?=
 =?us-ascii?Q?TpljH1aHPe7MiSP9Dmp/xHQ/DWQOZDx5guNS+iMciMt5p5ad+SkQye0hWRhd?=
 =?us-ascii?Q?usHvpllclzIee6lxJ0VSPAzHGlAOhtOolrHdDB2ODjvkEzU7L2Fj2f5x7p9q?=
 =?us-ascii?Q?9d6sUgSz7vZVx8yyR3KPq3jIX0QUnl0xr2Mix9xcmMNcg0yFLPcznqBdLVa8?=
 =?us-ascii?Q?IC7j0+8oy4BjYxr8Z3elxMC2JKq13gPYgR95cwm6hMDiZbMB4EW/J1uJhD/I?=
 =?us-ascii?Q?RIIqTZ+Ywt8nKOfXj6/a9Aauf0wN71QKKA+in7KY9oksIhkUGvWOrtJwkVDL?=
 =?us-ascii?Q?Q2UFrBBJyQHJgumj5Y+bG8FDk/55IfyV9XYEcsdLL4bCF+HX4QPHZCw4P+li?=
 =?us-ascii?Q?bRvN+UxOO8hgXVkgB1q8mNJ62yQuaj0AContent-Type: multipart/alternative;
	boundary="_000_SN6PR07MB454477F4C32C66D48BA0B02187A09SN6PR07MB4544namp_"

Solved by using asprintf() instead of snprintf() for dynamic string formatting and allocation in one go. Using realloc() to expand the buffer for the appended/required CRLF.

This allows for greater flexibility with the options, and the
possibility of querying your own (or some other) wttr server.

wttr.in weather forecast viewer

See merge request !258