Most are simple memory leaks, but some would cause crashes, and
others would cause unexpected behaviour.

Options were added to arrays without increasing the size of arrays.
This caused the menu generated from them to depend on uninitialized
memory and potentially crash or emit garbage.

Let's try just caching the 3rd party stuff.

Try capitalizing Linux tag.

As pointed out by mlong.

allows more flexibility in formatting xtrn program menus by allowing one to...

See merge request sbbs/sbbs!32

Kayz authored 4 years ago and Rob Swindell committed 4 years ago

allows more flexibility in formatting xtrn program menus by allowing one to remove the titles or underline headings by setting them to 'none' in the ini file

As reported by mlong

Previously, the console would be left in "raw" mode after invoking
'jsexec -d <module>'.

Added options -A[filename] and -S[filename] to allow more control over which output streams go where (for mlong and his troubles with running ircd via systemd).

-A controls "all messages" either sending all to stdout or the specified filename. This override the automatic suppression of the console output stream when run without a controlling TTY.

-S controls "status message" (includes non-error level log messages), either sending the status messages to stdout or the specified filename. This also overrides the automatic suppression of the console output stream when run without a controlling TTY.

Add ability to format the main external section menu like you can with the programs menus

See merge request sbbs/sbbs!31

Use the new "blanks" option with File.iniGetAllObjects().
This means that keys specified in the modopts.ini with no value
will now be represented as blank strings ("") instead of undefined values,
in JS modules.

If an .ini file is read by either the iniGetObject() or iniGetAllObjects() methods and contains a key with a blank value, that property would be created with an "undefined" value.

Both the iniGetObject() and iniGetAllObjects() methods now accept an additional Boolean argument (which defaults to false), to specify that "blanks" are acceptable. When the "blanks" argument is true, then keys with empty values in the .ini file are created as properties with empty string values (length of 0).

This is going to be useful for modopts.js to read potentially-blank strings from modopts.ini and differentiate between a blank string key and a missing key.

When a preexisting node.log file is found, a terminal server crash is suspected. Include the timestamp of the node.log in the message appended to the system log (data/logs/*.log) to help identify the likely time of the crash.

fix pre/post_eval_on_exec to work with existing uses

See merge request sbbs/sbbs!33

Kayz authored 4 years ago and Rob Swindell committed 4 years ago

change the program var in xtrn.js to prog to be compatible with any existing uses of eval_before_exec

By default, displays users of the BBS born in the current month.

Remove birthdate.js - not needed or used anywhere (anymore).

Don't pass NULL to strcasestr().

when there is no "template directory" selected/configured.

Don't load() things unnecessarily (use require() instead).
Fix the X-restriction issue (is not supposed to limit the execution of
programs configured to run as logon events).

When posting to "All" or replying to a message that was posted by networked (not local) user, don't attempt to search for that username in the local user base to inform them of the posted message to them.

savemsg() is the underlying C function for saving a new message (mail or post) to a message base from several places, including JS modules. If there was no "charset" specified in the passed message header, check to see if the message body text is non-ASCII but valid UTF-8, and if it is, set the FIDO_CHARSET header field to the appropriate UTF-8 charset identifier string. This would *also* address Issue #177 reported by Michael J. Ryan. It's possible, but unlikely, that a message text would contain valid CP437 that *also* happened to be valid UTF-8. If that does happen to occur (e.g. in posted ANSI art?), we might want to revert this enhancement to savemsg() and leave to the caller's to detect/specify the charset, always.

In Issue #177, the reported problem message header was "Content-Type: text/plain; charset=utf-8; format=flowed"
The fact that the "charset" value was not quoted and not space delimited means the charset would have been parsed as "utf-8;", which would not provide an exact match (against "utf-8") in smb_msg_is_utf8() and thus the message body would not be considered to be utf-8 encoded.

The solution is to terminate the "charset" parameter value at the semicolon, if it exists, and the value was not quoted.

Also, for good measure, only search for " charset" or ";charset" to avoid false-positive parameter matches,  like "notcharset".

Throw exceptions rather than just loggin an "Unable to open" error
(easier tracking fo the soruce of the error). Log the description and
errno value associated with the file open failure.

Create the .ini files if they don't already exist (rather than crashing
out with an error).

Replace the deprecated 'e' file open mode flag with 'x'.