- Apr 02, 2023
-
-
Rob Swindell authored
smtp_netmail_addr() - not currently used anywhere else, but may be someday. load/mailutil.js's fidoaddr_to_emailaddr() has this same logic (for FTN addrs at least and is now used by nntpservice.js). Also, always pass a buffer to smb_faddrtoa() from the mail server since it's multi-threaded and its unsafe to pass NULL (using a static local buffer).
-
Rob Swindell authored
smb_faddrtoa() uses a static local buffer if passed NULL and we shouldn't be doing that from multi-threaded callers.
-
Rob Swindell authored
Use the terminal server sem file check interval instead of node_sem_check (it was only used in the event thread) and node_stat_check was only used in the control panel, so just support a registry over-ride, but default to 5 sec. These settings were artifacts from SBBS v2 (WFC mode), and not really relevant or in the proper configuration place.
-
- Apr 01, 2023
-
-
Rob Swindell authored
-
Rob Swindell authored
CID 451182
-
Rob Swindell authored
This is an easily overlooked setting, let's make it easier
-
- Mar 31, 2023
-
-
Rob Swindell authored
Modem result codes. Oh, the memories...
-
- Mar 29, 2023
-
-
Rob Swindell authored
... rather than just return false. This will make debugging this type of issue much easier in the future. sendmail.js was allowing empty recipient_list array arguments and the MsgBase .status was 0 and .error just an emtpy string - unhelpful.
-
Rob Swindell authored
(like we do for Message Groups and File Libraries already)
-
Rob Swindell authored
-
Rob Swindell authored
-
Rob Swindell authored
-
- Mar 28, 2023
-
-
Rob Swindell authored
Move the Mail Server->SendMail* settings to their own sub-menu. Added popups while reading sbbs.ini
-
Rob Swindell authored
Fixed reversal of logic for FTP Server->Sysop File System Access option
-
Rob Swindell authored
And display an error message upon failure.
-
Rob Swindell authored
-
Rob Swindell authored
-
- Mar 27, 2023
-
-
Rob Swindell authored
-
Rob Swindell authored
-
Rob Swindell authored
-
Rob Swindell authored
-
- Mar 26, 2023
-
-
Rob Swindell authored
-
Rob Swindell authored
Still needs online help text.
-
Rob Swindell authored
This allows the [Global] section to be applied to each server section correctly Before this change, changing BindRetry in the global settings would result in the original global BindRetry value being added to each server/section of the sbbs.ini file.
-
Rob Swindell authored
Remove values, not keys, when setting a key with a global default. Use UInt16 functions for getting/setting TCP ports (this fixes an issue with the FTP PasvHigh port being set to -1 (instead of 65535). Use iniGetUInteger instead of iniGetShortInt for most other key values. First sbbs.ini save support in SCFG, still experimental.
-
- Mar 25, 2023
-
-
Rob Swindell authored
Allows SCFG to more easily display the most relevant .ini file using the UIFC timedisplay() callback.
-
Rob Swindell authored
-
Rob Swindell authored
I'm surprised more people haven't wondered aloud: why are all the Synchronet server settings in this huge sbbs.ini file? Well... this kind of answers that question: it's a hell of a lot of settings! And this isn't even everything (several advanced/rarely-used/borderline-deprecated settings aren't included)! As part of this change, I've replaced the old date/time display with the current config file path/name that's being edited (more or less). This will help when a sysop has multiple sbbs.*.ini files and makes it clear if you have multiple sbbs installs (like me), which one you're editing at any given time. I have not implemented any of the server setting edits (other than a couple simple toggles) or help text yet and this does not detect changes or save them to the sbbs.ini file, but I wanted to get this committed at this stage anyway. If you're running sbbsctrl.exe (or maybe even gtkmonitor), then maybe this is completely redundant and unnecessary, but I figured it was good to have these settings in one edit find/edit platform-agnostic location anyway. Hoepfully this will (when its done) make SBBS for *nix just that much easier for a newbie sysop/sysadmin.
-
- Mar 24, 2023
-
-
Rob Swindell authored
Since commit fd90eec6 (2 months ago), the Synchronet Web Server on my Windows systems has occasionally gone into a state where every HTTP session thread was causing 100% CPU utilization and each new HTTP session thread would just exacerbate the problem eventually leading to complete system instability/unresponsiveness until the sbbs instance was terminated. This was more readily reproducible on a Win7-32 VM, but would occasionally, though much less frequently, happen in a native instance on Win10-64 as well. Using the VisualStudio debugger, I was able to narrow it down to this: Each new HTTP thread (eventually, hundreds of such threads) would get stuck in this loop in http_output_thread(): while(session->socket!=INVALID_SOCKET) { /* Wait for something to output in the RingBuffer */ if((avail=RingBufFull(obuf))==0) { /* empty */ if(WaitForEvent(obuf->data_event, 1000) != WAIT_OBJECT_0) continue; /* Check for spurious sem post... */ if((avail=RingBufFull(obuf))==0) continue; // <--- data_event signaled, but never cleared } There appears to be a race condition where this logic could be executed immediately after the output ringbuf was created, but before writebuf() was ever called (which would have actually placed data in the output buffer), causing a potential high-utilization infinite loop: the data_event is signaled but there is no data and the event is never reset and nothing can ever add data to the ringbuf due to starvation of CPU cycles. Uses of ringbuf's data_event elsewhere in Synchronet don't seem to be subject to this issue since they always call RingBufRead after, which will clear the data_event when the ringbuf is actually empty (no similar loops to this one). The root cause just appears to be a simple copy/paste issue in the code added to RingBufInit(): the preexisting 'empty_event' was initialized with a correct initiate state of 'signaled' (because by default a ringbuf is empty) but the newly added events (data_event and highwater_event) should *not* be initially-signaled because... the ringbuf is empty. So I added some parameter comments to these calls to CreateEvent() to hopefully make that more clear and prevent similar mistakes in the future. Relieved to have this one resolved finally.
-
Rob Swindell authored
-
- Mar 21, 2023
-
-
Rob Swindell authored
Fixes CID 451020
-
Rob Swindell authored
This was needed back in the v2 days to be sure the escape sequence was sent *after* an output buffer before might've been cleared by a user's abort/Ctrl-C action. SYNC/ASYNC called riosync() which called rioctl(TXSYNC) and we have no equivalent in Synchronet for TCP/IP (modern sbbs). A user's Ctrl-C will clear all pending I/O, but won't prevent subsequent output from being sent (until the abort condition is cleared) as used to be the case with serial I/O.
-
Rob Swindell authored
... possible loss of data (yeah, yeah, we know)
-
Rob Swindell authored
This code will do nothing if there's no user logged-in or their terminal is not ANSI or their terminal dimensions (rows and cols) are set to specific values (not auto-detected). This code does the same thing as calling JS console.getdimensions(). Since it waits (up to 5 seconds) for a CPR response from the terminal, this does potentially slow down output, so caveat emptor. This could be used by a sysop to address issue #529.
-
- Mar 20, 2023
-
-
Rob Swindell authored
The recently updated ctrl/sbbs.ini had MaxLoginInactivity = 10M in the [BBS] section, which was parsed as 10 seconds rather than the intended 10 minutes. This fixes that issue and also will now store all of these inactivity values in duration notation. Existing values stored in seconds will work fine since that is always the assumed/fallback unit of time in duration keys. Thanks for the report!
-
- Mar 19, 2023
-
-
Rob Swindell authored
The lower of the configured maximum file size (for the FTP server) and the available disk space minus the configured minimum free disk space is used as the maximum file size to allow upload. Appended files are accounted for too.
-
Rob Swindell authored
Disallow uploads when free disk space falls below minimum configured minimum free disk space. This fixes issue #535
-
- Mar 18, 2023
-
-
Rob Swindell authored
-
Rob Swindell authored
- New keys in [BBS] section of sbbs.ini: MaxLoginInactivity (default: 10 minutes) MaxNewUserInactivity (default: 60 minutes) MaxSessionInactivity (default: none/unlimited) - Each configured external program/door in SCFG can have its own maximum inactivity setting (or else the session max inactivity is applied) - moved node-specific sec_hangup to system-wide/shared max_getkey_inactivity (configured in SCFG->System->Advanced) - moved node-specific sec_warn (seconds of inactivity before sending warning) to inactivity_warn (a percentage of elapsed max inactivity before sending warning), also configured in SCFG->System->Advanced and used for both socket and getkey inactivity detection - Renamed JS console.inactivity_hangup to console.max_getkey_inactivity (old name remains as alias) - Renamed JS console.timeout to console.last_getkey_activity (old name remains as alias) - Removed JS console.inactivity_warning - Added JS console.max_socket_inactivity (current input_thread inactivity threshold) - New text.dat string: InactivityAlert (just contains 3 ^G/BELLs by default) used for non-visual inactive-user warning The MaxLoginInactivity setting in particular solves the problem of custom scripts (e.g. animated pause prompts) that just poll indefinitely for user input and never time-out - these will no longer cause nodes to be tied-up with inactive/bot users at login. You may ask yourself, how did I get here? No, you may ask yourself: why configure these socket inactivity max values in sbbs.ini? The reason is consistency: sbbs.ini is where the MaxInactivity is configured for all the other TCP servers and services. This fixes issue #534 for Krueger in #synchronet
-
- Mar 16, 2023
-
-
Rob Swindell authored
... to make property names more consistent (e.g. with bbs.last_node). The old names (without the underscores) are still usable but won't appear in JSDOCS (i.e. jsobjs.html).
-