Bwa ha ha!

Make js_socket_sendfilesocket() suck a lot less.
This commit brought to you with limited rants by Synchronet 3.20b

"Warning: Your BBS may become habit forming."

You could run Synchronet or you could settle for mediocrity.

Once in a great while, there comes BBS software that really makes waves.
Get out your surfboard.

The best BBS software is the most expensive BBS software.
NOT!

If you had three wishes, you could toss the other two.

They couldn't top Synchronet.  So we did.

Accept the inevitable, switch to Synchronet

This code is fine.

Try untainting it in recv_hex... if that doesn't work, I'll just
have to ignore it I guess.

Rob Swindell authored 2 months ago and Deucе committed 2 months ago

You have "call" a batch file to not terminate.

Fix the fail check after building chat.exe

It has a 4k window, we need to fill it multiple times.

Rob Swindell authored 2 months ago and Deucе committed 2 months ago

launches 'jsexec fileman.js' (not in GDI mode)

Rob Swindell authored 3 months ago and Deucе committed 2 months ago

Fix off-by-one error in checking TimeZoneComboBox->ItemIndex again tz_val
array. When choosing the last (Other/Automatic) item, no change to the
sys_timezone should be made (was setting it to 0/UTC).

Rob Swindell authored 3 months ago and Deucе committed 2 months ago

This was evident by logging in with PETSCII/64col mode and the last ']' of the
"Loading message pointers..." progress indicator was left in the first right
column of the screen.

Rob Swindell authored 3 months ago and Deucе committed 2 months ago

Increase the minmimum free disk space to 1G by default (most modern computer
sysops will probably want to increase this even more).

Rob Swindell authored 3 months ago and Deucе committed 2 months ago

This means that when writing user.birthdate (in JS) for example, we will
always save the field in the proper (YYYYMMDD) format. This fixes issue #855.

Remove use of SM_EURODATE from userdat.c.

This commit includes new @-code MINSPACE (minimum diskspace required to allow
uploads) too (unrelated change).

Rob Swindell authored 3 months ago and Deucе committed 2 months ago

... that includes GJ's (now well known/seen) "SYNCH" splash ANSI.

Rob Swindell authored 3 months ago and Deucе committed 2 months ago

To hopefully address:
!ERROR 2 (No such file or directory) renaming s:\sbbs\data\file/somenum.rep
 (-1 bytes) to s:\sbbs\data\file/somenum.rep.6777ed7c.bad

Clearly flength() is returning -1 (file doesn't exist) at this point, so
perhaps the call to fremove() just above updated a cached directory?

Rob Swindell authored 3 months ago and Deucе committed 2 months ago

Fix some newly introduced MSVC warnings:
  conversion from 'time_t' to 'uint32_t', possible loss of data

Should these local vars be time32_t instead of uint32_t?

I'm not clear why the 2 step conversions now (?):
	time_t -> uint32_t
	uint32_t -> time32_t

So I can poke it and break things.

0 is a valid value, results are undefined.

Validate the size of the message at each step and throw an error if
something goes wrong.

Should fix the issue where an IRC spammers DNS was detected as local,
so the anti-spammer bot banned my server address intead of the
spammers address.

I'm not sure if I can do this with events, or just issues, and I
don't want to directly annotate this issue because that could lead
to missing an issue after a future code change.

The return value of getch() will never be const though.

Since Coverity treates the return value of write() as tainted
(valid for negative values, not so valid for positive ones), do an
upper bound check on the result as well as lower bound to clear
the tainted flag.

Have zmodem_recv_nibble() explicitly range-check all values, and
handle negative values.  If this remains an issue, it can be
untainted with range checks on each nibble, but let's not go there
to start with.

This is purely to shut up Coverity since there's no way the value
could be outside the range.