Skip to content
Snippets Groups Projects
  1. Jun 04, 2018
    • rswindell's avatar
      eb4e59fe
    • rswindell's avatar
      Increment SBBSecho version to 3.05: · 6790c325
      rswindell authored
      more control over SBBS-initiated netmail source/origin addresses.
      6790c325
    • rswindell's avatar
      When the system has multiple configured FidoNet addressess (AKAs), let the · 1d41500e
      rswindell authored
      user choose which address to use as the source address when composing a netmail
      message (the default being the most appropriate for the dest zone/net). This
      change only works with SBBSecho v3.05 or later.
      Some other incremental and safety improvements to sbbs_t::netmail() too.
      FTN netmail file attachments needs some more work however (the "FA:" subject
      prefix trick) - just remove it?
      1d41500e
    • rswindell's avatar
      Another improvement to create_netmail(): · 576c68b5
      rswindell authored
      If the SMB header contains a source FTN address, use that as the origin address
      of the netmail and do not look-up a local AKA match for the destination address.
      Also, fix what appears to have been a (currently harmless) bug in
      smsg_to_echostat_msg(): the msg.from_net.addr is not an ASCIIZ string when
      net.type == NET_FIDO. Currently, source FTN addresses aren't set in echomail
      message headers, where the echostats come from. Could just remove
      these 2 lines.
      576c68b5
    • rswindell's avatar
      Address RMH's issue: · d5affff4
      rswindell authored
      When the local system has multiple AKAs for the same zone and we are picking a
      origin/source address suitable for the destination address, pick the AKA that
      matches both the zone and net of the destination address first (if there is
      such a local AKA). It's the same logic used in sbbs_t::netmail() to display
      the originating address, so the AKA picking logic now matches what is shown
      to the netmail author and what SBBSecho will actually use.
      d5affff4
  2. May 23, 2018
  3. May 22, 2018
  4. May 15, 2018
    • rswindell's avatar
      Fix get_msg_header() problem reported by Bill McGarrity: · 4f279cb2
      rswindell authored
      "expand fields" could be misinterpretted (e.g. as 'false') if less than 3
      args were passed to the function. Apparently you can NOT assume that argv[argc]
      is undefined and would fail a JSVAL_IS_BOOLEAN test. In the reported problem,
      MsgBase.get_msg_header() was being called with 2 arguments (from newslink.js)
      and the if(JSVAL_IS_BOOLEAN(argv[n])) test, when n was 2, would eval to true
      and then argv[n] evalulated as false, which would cause a message with no
      message ID to not have one dynamically created, which would then cause the
      message to fail to post to an NNTP server due to malformed Message-ID (a
      missing message "id" property would end up being included in the newsgropu
      article header as "Message-ID: undefined").
      
      get_msg_index() had a similar potential issue, also fixed.
      4f279cb2
  5. May 14, 2018
  6. May 10, 2018
  7. May 09, 2018
  8. May 04, 2018
  9. May 02, 2018
  10. May 01, 2018
  11. Apr 30, 2018
  12. Apr 24, 2018
  13. Apr 20, 2018
    • rswindell's avatar
      Fix race-condition causing SSH errors: · 64ce7cb9
      rswindell authored
      Terminal Server SSH ERROR 'Bad argument, parameter 1' (-1)
       ... from output_thread
      
      The bbs_thread() sets the global/server sbbs ssh_mode to false and ssh_session
      to 0 (the "parameter 1" value used in the cryptlib function calls in
      output_thread) but was doing this without owning the ssh_mutex, so the
      output_thread had a race condition where it would check ssh_mode=true and
      then use grab the ssh_mutex and use ssh_session in a few cryptlib function
      calls. The fix for the bbs_thread() to grab the ssh_mutex before setting
      ssh_mode to false and ssh_session to 0 and have the output_thread() re-check
      the ssh_mode after grabbing the ssh_mutex and not call any cryptlib
      functions if ssh_mode was set to false while waiting for the mutex.
      
      The cause would have been more obvious if the various cryptlib error/log
      messages contained the cryptlib session ID value (which was 0 in this case).
      64ce7cb9
  14. Apr 19, 2018
  15. Apr 18, 2018
Loading