this code is on the chopping block already.

latest logon.js.

by Deuce. If 'top' is passed in as NULL, assign a blank string constant to it
since we dereference top a few places in this function and pass it to putmsg().

to a second thread before the first has the session set active.  Add calls
to lock/unlock the certificate to prevent this.

The better options is likely to have a function that adds the key and socket
and sets the session active in one call and handles the locking internally.

But I'm lazy, so we get the lock functions.

when using features that support avatars (e.g. reading msgs, listing files,
listing BBSes in the BBS list).
When used in the terminal server, the cache is located in bbs.mods.avatar_cache
otherwise it's located in the scope of the load()'d library. Applications must
use the lib's read() method to take advantage of the cache. The other lower
level functions (e.g. read_localuser, read_netuser) by-pass the cache on read
but do update the cache with the result. So, generally, avatars should be only
loaded from disk one time during a session/logon.

network hub call-outs and timed-events.

none already keeps these events from running on an automated schedule).

(JS bbs.post_msg()): If the WM_QUOTE mode flag is *not* set, then it will auto-
create the quote file (quotes.txt) and add the WM_QUOTE mode bit before calling
sbbs_t::writemsg(). So if existing JS scripts call bbs.post_msg(..., WM_QUOTE)
with a custom-created quote file (e.g. with msg tails), that'll still work as
before (e.g. DDMsgReader.js).

bbs.email() and bbs.netmail() now support an optional reply_header_object
argument which works like bbs.post_msg(). These methods (and the underlying
C++ methods: sbbs_t::email(), netmail(), inetmail(), all auto-create the
quote file now, when the WM_QUOTE mode flag is *not* set.

The auto-created quotes.txt now includes the plain-text version of MIME-encoded
messages.

the bbs.post_msg(), email(), and netmail() methods now all support reply
header objects that came directly from bbs.get_msg_header() *or* copies of
such header objects (but the auto-quoting feature won't work when supplied
this type of header object). So if passed a header object returned from
bbs.get_msg_header(), we can now use the message base (for auto-quoting) and
the underlying msg storage directly (no JS parsing necessary). This is what
the new js_GetMsgHeaderObjectPrivates() function is used for.

js_ParseMsgHeaderObject() (and the underlying parse_header_object() function)
now supports either an actual internally-generated msg header object (e.g.
returned from bbs.get_msg_header()) or one that is a copy or hand-constructed.

quotemsg() no longer tries to get a copy of the msg index/header. It shouldn't
have to since we can now get to underlying msg storage in the js_msgbase.c
via js_GetMsgHeaderObjectPrivates().

quotemsg() now reads only the plain-text portion of MIME-encoded messages.

As part of this effort, I modernized the method prototypes using default
argument values (e.g. WM_NONE for wm_mode arguments) and removed some
extraneous WM_EMAIL and WM_NETMAIL specifications (these wm_mode flags are
automatically added by the sbbs_t::email() and *netmail() functions).

savemsg() now *does* support reply-IDs/thread-linkage via the additional
'remsg' argument (when non-NULL).

Replaced some use of nulstr with NULL.

Replaced more boilerplate SMB open code with calls to smb_open_sub().

used by js_post_msg() (the JS bbs.post_msg() method when used with the
reply_header object argument) - the private data attached to a message
header object is of type privatemsg_t, not private_t. This caused the
dereferences of and assignments to p->smb_result in parse_header_object()
to corrupt the privatemsg_t->msg memory causing heap corruption (caught
on Windows debug builds in js_get_msg_header_finalize()) and stack faults
(caught on Linux-gcc in parse_recipient_object()). This one was hard to
find. <whew!>

I noticed that printable ctrl chars (e.g. 0x18 and 0x19) were not causing the
current column position to increment, so that got me looking at this code and
wondering why the LF/FF checking was outside the if(!outchar_esc) condition
and being executed when CON_R_ECHO is off. So now, using a switch statement,
it's cleaner and all the printable ctrl chars move the current column position
correctly.

When the WM_QUOTE mode flag is set and the 'remsg' is specified, the original
message will quoted (excluding message tails, using the proper word-wrapping).
If the quote file already exists before calling postmsg()/bbs.post_msg(), it
will be over-written. This allows JS script to initiate reply-posts with quoted
text without having to create their own quotes file. It also means there's no
need to call sbbs_t::quotemsg() before calling sbbs_t::postmsg().
sbbs_t::quotemsg() now takes an smb_t* arg (stop using the sbbs_t 'global'
smb) and now returns bool.

Renamed js_postmsg() -> js_post_msg() for good measure.

     TypeError: settings is undefined
Presumably, when settings.ini doesn't exist.

set avatar_show = false to disable the avatar display completely (during logon)
set avatar_draw_right = false to display the avatar in left screen columns
set avatar_draw_above = true to display the avatar above the current screen row

!JavaScript  /sbbs/xtrn/ansiview/ansiview.js line 313: TypeError: settings is null

error: 'O_NONBLOCK' undeclared
... on Alpine Linux.

- SMB_EMAIL
- SMB_HYPERALLOC
- SMB_NOHASH

error: 'PTHREAD_MUTEX_RECURSIVE_NP' undeclared
as ported by GeoKM

(name/version of text editor used, if known).

- SUB_TEMPLATE
- SUB_MSGTAGS

designator.

Only treat an invalid QWK msg block count (<2) as an error if there is
more than one msg header in the packet (stop saving so many worthless
data/file/*.rep.*.bad files).

file lists during events.

	"read %u message scan cfg/pointers in %lu ms"
The message pointer performance problems were resolved a long time ago now
and this is just noise in the logs.

reported as "Duplicate index offset", so overlapping headers means the
index offset must not be an exact duplicate, so we don't report the same
corrupt message parameter (its offset into the header file) 2 different
ways.

is 0 (logic moved from sbbs_t::postmsg()).

as it is easy for a sysop to accidentally hit [D]elete and not realize it.

packets.

So I created a single add_msg_ids() function (mostly migrated from postmsg.cpp)
to make this incredibly easy so any/everywhere that adds a message to a message
base should be able to call it. This function also creates reply-IDs (when
relevant) and program ID (Fido-PID) header fields:
- FIDOPID (always)
- FIDOMSGID (if an echomail post)
- FIDOREPLYID (if an echomail reply-post)
- RFC822MSGID (always)
- RFC822REPLYID (if a reply)

If confirm_email_address = false in the [login] section of modopts.ini, do not
ask the user to confirm their email address before sending password.
Do not display the email address back to the user (in case they did not already
know it).
Send the user a telegram for each failed login attempt (using user alias, not
number).
Send the user a telegram when their account info (password) was requested.

If the user.dat file is already opened in deny-none mode (as is the norm),
another process (e.g. useredit.exe) cannot simultaneously open it in exclusive
mode.

the read buffer may be utilized more efficiently if you do *not* perform an
(unnecessary) seek operation just before the read. By eliminating unnecessary
seeks in smb_getmsgidx() and smb_getmsghdr(), I was able to reduce the time
required to load 9000+ index and header records over a network (Samba/CIFS)
share from 15+ seconds to less than 5.