DDMsgReader: Changed rescan hotkey for the indexed menu to Ctrl-R, since Ctrl-S won't work for Wyse terminals (Ctrl-S is for xon/xoff toggling and can't be changed)

See merge request !389

Eric Oulashin authored 1 year ago and Rob Swindell committed 1 year ago

DDMsgReader: Changed rescan hotkey for the indexed menu to Ctrl-R, since Ctrl-S won't work for Wyse terminals (Ctrl-S is for xon/xoff toggling and can't be changed)

TLS 1.2.  For static services and JS sockets, add a new tls_minver
socket property which can be set to use a lower minver (down to the
wildly insecure TLS 1.0).

TLS 1.0 and 1.1 have been not reccomended since 2015, and deprecated
since 2021.

Update cryptlib to 3.4.7

See merge request !388

Even on filesystems where you can do it, you shouldn't.  Stop it.

The server is a lot thinner, with callbacks for each operation.

The client_socket_dup is overwritten after with the return value of accept(),
so this was likely a socket/handle leak (since commit 74470573, 17 years ago).

Noticed this only after logging a new error in an SSH connection when this
call to DuplicateHandle() failed for some reason (WinError 6), but it seems
like it's been redundant code for a long time now. So just ace it and possibly
fix a resource leak.

Merge branch 'ddmr_indexed_mode_mark_all_read_updates_and_newscan_force_indexed_menu_opts' into 'master'

DDMsgReader: Updated behavior for indexed menu R (mark all read) when doing a newscan. Ctrl-S does scan refresh in indexed menu. New R "snap-to" option for the indexed menu. Also, command-line options for forcing use of the indexed mode menu when doing a

See merge request !387

Eric Oulashin authored 1 year ago and Rob Swindell committed 1 year ago

DDMsgReader: Updated behavior for indexed menu R (mark all read) when doing a newscan. Ctrl-S does scan refresh in indexed menu. New R "snap-to" option for the indexed menu. Also, command-line options for forcing use of the indexed mode menu when doing a

Broken 11 months ago with commit d815379b: the unit argument was ignored (e.g. converting to kibibytes) and the free/total disk size/space checks were reversed.

Reported by Max (WESTLINE) via usage of JS properties: system.freediskspace and system.freediskspacek.

The JS global functions dir_freespace() and disk_size() were also broken due to this bug.

This fixes ssl.c build for Windows

scfgnet.c:1463:25: warning: result of comparison of constant 100000 with expression of type 'uint16_t' (aka 'unsigned short') is always true

really no useful way to recover from failure.

This should fix the Clang warning that Deuce reported:
str.cpp:131:18: warning: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior

Still using BOOL where we need Win32 API compatibility.
Using JSBool instead of BOOL or bool where it matters.
Changed most relevant TRUE/FALSE to true/false too (though it's not as critical).

You shouldn't need to #include <stdbool.h> anywhere now - gen_defs.h should do that automatically/correctly based on the language/version/tool. In C23, stdbool.h isn't even needed for bool/true/false definitions (they're keywords), so we don't bother including stdbool.h in that case.
Microsoft didn't define __STDC_VERSION__ in their older tool chains (even though they were C99 compatible and had stdbool.h), so we use a _MSC_VER check to know that there's a stdbool.h we should use in that case.

For other/old compilers (e.g. Borland C) we #define bool/true/false following the pattern of stdbool.h (doesn't use a typedef).

I didn't convert UIFC yet.

This addresses issue #698

TLS clients don't (currently) add a certificate, so there's no need
to delete it.

Use cryptDestroySession() instead.

With this, it's not strictly necessary to clear cert_list in ssl_sync()
when the certificate changes, but it's still a good idea to prevent
unusable memory from being held onto.

warning: value computed is not used

Now each lock has an easily understandable purpose, and covers the
lowest possible amount of code.

Use new rwlock for ssl certificate.

See merge request !386

Instead of tight loops with 1ms Sleep()s in them, add events for
zero readers and zero writers that we can wait for instead.

Unfortunately, since Events aren't interlocked with a critical section
like condition variables are with mutexes in pthreads, we can't
rely on this for race-free code, so for read locks, we still may
spin under write pressure.

Various bits of broken no longer broken.