DDMsgReader bug fix: For the indexed-mode newscan, when showing only sub-boards that have new messages, ensure the selected item index is correct when re-populating the menu so that it doesn't skip a sub-board. Reported by Amessyroom.

See merge request !476

Eric Oulashin authored 3 months ago and Rob Swindell committed 3 months ago

DDMsgReader bug fix: For the indexed-mode newscan, when showing only sub-boards that have new messages, ensure the selected item index is correct when re-populating the menu so that it doesn't skip a sub-board. Reported by Amessyroom.

DDFileLister: When editing file information, check whether cost and times_downloaded exist in the metadata before accessing them. Reported by Ragnarok

See merge request !475

Eric Oulashin authored 3 months ago and Rob Swindell committed 3 months ago

DDFileLister: When editing file information, check whether cost and times_downloaded exist in the metadata before accessing them. Reported by Ragnarok

1) Initialize saverobot.name since this is checked unconditionally.
   This has a side effect of initializing everything else, but name
   is the only thing that actually matters.
2) Add a bar to the global settings menu.
   Previously, if you scrolled near the bottom and selected an option,
   after changing the option, you would jump up to the last item on
   the initial screen.
3) Fix the AreaMgr Support default value to be the current, not the
   opposite of current.
4) Use the correct variable for EchoMail Relay Filtered Messages
   setting default.

We're carefully counting the errors, but never looking at the count.

For retina lies.

Upon any node.dab lock or read failure, this code would cause errormsg() which
would often/usually end up claling getnodedat() which would block forever trying
to acquire the ndoefile_mutex (introduced in commit b9633069, I'm not clear why).

Unlock/release the mutex *before* calling errormsg().

Don't deref that null pointer

It was always displayed (sent to stderr) when running scfg, echocfg, uedit,
etc. in auto-curses mode, so suppress that noise.

Some USB modems (reportedly, USRobotics USB modem) don't strip the parity bit
of data received from modem connections operating in < 8 bit modes
(e.g. 7-E-1), as is normally don't with a modem connected to a UART, so we'll
do that stripping (forcing to 0) here, as recommended by Deuce.

Nelgin, if you're doing some manually stripping of the 7th bit bytes received
from 7-E-1 connected modems and then sent to your server/BBS over TCP, you
shouldn't need to do that now.

I dislike this particular code a little less now:
- no more redundant string compares
- less deeply nested if() and for() blocks
- remove added areas from the add list, rather than zeroing out the tag
- a little more common code between areas.bbs and areas.ini handling

No functional change (I hope).

To quickly free and remove all list entries (without realloc).

Easier to match up than numbers.

Split generating help into separate function
- Regenerated when the connection type changes
Split generation the opt list into separate function
- Regenerated after handling any selection

If someone wants to know the differences between 1.2rc1 and 1.2rc3,
the can check git.

We just need to strip the high bit on RX because the mode leaves
it on received bytes.

to unblock the pipes

"AreaFix" is a proper product name. Though it's been defunct and unsupported
for decades, we still should not confuse sysops and historians: the general
term for what AreaFix did/does is Area Management, aka Conference Management.

The sbbsecho.ini key names are unchanged and the destination netmail address
for AreaManager requests can still be "AreaFix" (though "SBBSecho" is still
supported as well).

and vice versa - so area manager requests were broken since I introduced the
areas.ini support. Oops.

I noticed through code review that these kinds of messages would be rejected
as "No commands to process.". We just needed to increment the 'cmd' counter
when parsing these options to be sure we don't think that no commands were
in fact request. -R (rescan) is not by itself a command since it requires
listed area-tags to have any effect.

... like how we do for areas.bbs files.

For use cases were we don't want to silenty ignore duplicate (secondary)
section definitions.

This is just in case the modem actually stays in 8N1 mode when
7E1 or 7O1 is set.  This is what the USR 5637 appears to do.

There's a small performance penalty for anything in 7-bit mode with
this, but it shouldn't be enough to actually impact anything.

Possibly setting CTS/RTS after raising DTR drops DTR which causes
DCD to be lost.