Thanks to TRMB for being the guinea pig, I see now that REP packets can't be opened in append mode because we write and then seek back and write some more in msgtoqwk(). Oops.

length... for WitNik.

18 years, 10 months ago I introduced a bug whereby .MSG files in outgoing REP packets were *always* truncated before newly-exported messages were added. Even though the log message would say "Updating /path/to/HUBID.REP" (rather than the usual "Creating ...") it was actually truncating the .MSG file, thus discarding any existing messages that were not previously successfully sent (!). I'm not sure what the problem was I was trying to solve at the time (some "Unix .rep creation bug") - but the change I made at the time was most definitely was not the correct fix. :-(

How I noticed this problem was the HEADERS.DAT Conference Number check I added to qwk_parse_header_list() back in August of 2019. I've been catching/logging those errors here on Vertrauen and collecting *.rep.bad files from occasional QWKnet node-submitted REP packets, but I didn't look into the cause until today: the HEADERS.DAT and VOTING.DAT files were being correctly appended even though the .MSG file was being truncated, so the files would be out-of-sync and this was the root-cause of the crossed-up message bodies/headers seen on DOVE-Net a year or more ago and apparently also the cause of occasionally lost messages from QWKnet (e.g. DOVE-Net) nodes.

To trigger this bug from the node side, you'd have to create a REP packet with one or more message in it and then fail to send it to your hub (e.g. VERT), for any reason. And then when you attempt another pack/call-out, the previously packed messages would be lost and the HEADERS.DAT file would contain stale/out-of-sync information. 

To simplify things, I'm now just using fopen(..., "ab") (append, binary) - fnopen() should not be needed when opening files in the temp_dir. In append mode, no subsequent fseek(..., SEEK_END) should be needed, so don't do that. And use fprintf() for its intended purpose.

The errno (global error number) information is not relevant for any sbbs "checking" type errors.
Also, use safe_strerror() for thread-safe errno descriptions.

of ncurses.

Defaults to K_EDIT.

Technically, forward_msg() can work on any message base but really should only be used in the 'mail' base.

have contributed *something*." -- Cyan

backup the original.  Specify -b to make that happen.

I wanted to get this accomplished with a change to conio.props but couldn't figure out how to make that work (the .rc file has to be compiled first, so it can't be just linked).

Apparently ebuilds don't work properly with backticks.

Fixes issue reported by Ragnarok (DOCKSUD) where by data/binkstats.ini
could contain:
     failed_sent_files = [object Object],[object Object],[object
Object],[object Object],[object Object],[object Object],[object
Object],[object Object

Update dosemu.ini documentation of string substitutions

See merge request !65

We can always reference the old revisions if needed for something,
but for now, it just serves to confuse and distract others.

Improvements to linux dosemu support

See merge request !56

Kayz authored 4 years ago and Rob Swindell committed 4 years ago

The hardcoded external.bat file has been moved to a templated
/exec/external.bat which can be modified by the sysop. ENV
vars are in there to be able to customize as needed. emusetup.bat
is no longer needed, but still supported. The actual dosemu command line
is now stored in /exec/dosemulaunch.ini and can be customized for
fossil or i/o command lines. the keystroke is now only sent for i/o, and
only sent as \n instead of \r which would trigger undesired behavior in
certain programs. The above 2 files can also be placed in door dirs
to override. ansi.com has been removed as it was not needed. default
external.bat includes cmd lines for share, x00, etc. (user will still
need to provide these in xtrn/dosutils).

Use failed auto-verification server/service address info if/when
the 'imsg_capable' flag is set.

Uses the git_branch and git_hash files created in sbbs3 (first).

On Local and DOVE-Net subs.

Message Markup seems to be working well, so just enable by default on newly created subs (existing sub-boards aren't impacted). A sysop can always disable this option on a per sub-board basis if its a problem.

Previously, it "succeeded" if no checksum was returned.

Mlong/ilink

See merge request !64

This reduces the number of unnecessary recompiles of ver.cpp -> ver.o.

Gave up on trying to isolate socket-enabled (networked) and non-socket apps. Just link everything that uses xpdev (which is everything, I think) with the WinSock import library. Fixes the current master branch build issue on Windows. I'll get around to removing the old NO_SOCKET_SUPPORT macro eventually.

Might as well, could be useful to display in something like umonitor in the future.

when selecting a node (data comes from node#/client.ini). For Nelgin.