Skip to content
Snippets Groups Projects
  1. May 09, 2018
  2. May 04, 2018
  3. May 02, 2018
  4. May 01, 2018
  5. Apr 30, 2018
  6. Apr 24, 2018
  7. Apr 20, 2018
    • rswindell's avatar
      Fix race-condition causing SSH errors: · 64ce7cb9
      rswindell authored
      Terminal Server SSH ERROR 'Bad argument, parameter 1' (-1)
       ... from output_thread
      
      The bbs_thread() sets the global/server sbbs ssh_mode to false and ssh_session
      to 0 (the "parameter 1" value used in the cryptlib function calls in
      output_thread) but was doing this without owning the ssh_mutex, so the
      output_thread had a race condition where it would check ssh_mode=true and
      then use grab the ssh_mutex and use ssh_session in a few cryptlib function
      calls. The fix for the bbs_thread() to grab the ssh_mutex before setting
      ssh_mode to false and ssh_session to 0 and have the output_thread() re-check
      the ssh_mode after grabbing the ssh_mutex and not call any cryptlib
      functions if ssh_mode was set to false while waiting for the mutex.
      
      The cause would have been more obvious if the various cryptlib error/log
      messages contained the cryptlib session ID value (which was 0 in this case).
      64ce7cb9
  8. Apr 19, 2018
  9. Apr 18, 2018
  10. Apr 17, 2018
    • rswindell's avatar
      Extend USE_DOSEMU patch to drop file creation for non-native doors: · cef8a16e
      rswindell authored
      Use drive mappings (e.g. D:, F:, G:, H:) rathe than absolute paths to node_dir,
      ctrl_dir, data_dir, and exec_dir in drop files.
      Also: fixed what appears to have been a copy/paste error in the node_dir
      and ctrl_dir mapping to Win32-shortnames for non-native doors on Windows.
      cef8a16e
    • rswindell's avatar
      Simplified the rename_or_move() function: · e5d93aeb
      rswindell authored
      - Don't use the deprecated 'e' file open mode
      - Use the global file_copy() method rather than roll-your-own
      e5d93aeb
    • rswindell's avatar
      Display the (previously unused) EmailFilesNotAllowed text.dat entry if a file · e874431e
      rswindell authored
      attachment is attempted but unsupported.
      e874431e
    • rswindell's avatar
      Overhaul sbbs_t::netmail() for FidoNet netmail: · b6a4d4cd
      rswindell authored
      - writes outbound netmail to SMB rather than FTS-1 Stored Messages (*.msg)
        this means you must have SBBSecho v2.30 or later in order to export FTN
        netmail (for file attachments, you'll need SBBSecho v3.04 rev 3.78 or later)
      - removed support for the now deprecated "default address" feature
        (nowadays, people are much more likely to gate FidoNet over Internet rather
        than the reverse!)
      
      The QWK-to-NetMail function still needs a similar overhaul.
      b6a4d4cd
    • rswindell's avatar
      write_flofile(): if the 'infile' path contains a drive letter prefix · 4b55d180
      rswindell authored
      (e.g. "C:"), skip it on *nix and if the path contains backslashes, convert
      to forward-slashes (for all OSes). This resolves an issue of sending a
      netmail file-attachment that was created on a Windows/MS-DOS type system
      and then scanned/exported on a *nix system. The FTN "stored message"
      convention is to have the full path of the attached file in the message
      subject.
      
      Hopefully nobody wants to use outbound directory names beginning with "x:"
      on *nix. :-)
      4b55d180
    • rswindell's avatar
      Bug-fix: when exporting FTN netmail from SMB "mail" base, if the netmail · 5d1e28b5
      rswindell authored
      included an "old-style" (not MIME-encoded) file attachment (where the file path
      is in the subject and the FILEATTACH aux-attribute flag is set), the
      corresponding netmail attribute flag would not be set in the stored msg (*.msg)
      file. Also simplified the create_netmail() function prototype/usage, removing
      the "file_attached" argument (use the hdr.auxattr instead).
      5d1e28b5
  11. Apr 16, 2018
    • rswindell's avatar
      This is a clean rebuild of 3.4.4 with all our patches and there are several · 3da88fc6
      rswindell authored
      bytes different, so committing out of an abundance of caution. No "known"
      changes however.
      3da88fc6
    • rswindell's avatar
      Fix typo in previous commit. · a91d43ff
      rswindell authored
      a91d43ff
    • rswindell's avatar
      2 unrelated changes: · 61dd1bf0
      rswindell authored
      1: Wrap SSH cryptDestroySession() calls in a wrapper that tracks the number of
          open sessions and logs errors upon failure (and remaining session count).
          This is how I found the SSH session leak in sbbs_t::hangup().
          Also found multiple cals to SSH_END() which were invalid (no session to
          destroy) and removed them.
      2: If errors are detected when unpacking a REP packet, save the .rep file
          (in data/file/<filename.rep>.<timestamp>.bad) for later inspection.
          Also added some VOTING.DAT debug output (to be removed later).
          Trying to the get to the bottom of the
          "smb_addvote thread_back field missing" errors.
      61dd1bf0
Loading