GitLab

Used js.on_exit() to set console.ctrlkey_passthru back on exit properly (SlyEdit, DDMsgReader) and bbs.sys_status (SlyEdit)

Local sysop can always deleted/edit entries (now).
Fixed checking of can_edit() return value (string or true), fixed issue #425
as reported by Craig Hendricks (thank you)

As pointed out via DOVE-Net by DesotoFireflite (VALHALLA):
When xtrn_sec.* display file/menu is used, there's no auto-generated
prompt (with a default section number indicated). So hitting Enter
in this case and having the previous/default program section selected
would be surprising behavior to a user. So, only support a default
section selection when there was no xtrn_sec.* menu/display file.

Some unused/padding bytes are written as 0xff, so don't build strings from
those chars.

Synchronet uses "extended normal" mouse reporting for mouse support
(e.g. menu/display file clickable "hot spots"). Many of the JS scripts
that predated Synchronet's own internal mouse support would send their
own mouse-reporting enablement and disablement ANSI sequences and the
terminal could become out of sync with the expectations of the script
(i.e. it would not necessarily disable the mouse modes that had been
set by SBBS before enabling its own preferred mode).

And some scripts (e.g. Synchronet Minesweeper) use a mixture of Synchronet
hotspot support and direct mouse click coordinate reporting, so it was a
mess going between different mouse reporting modes at different times in the
same script.

This all came to light as a result of the fix for issue #412: using mouse
button releases rather than presses to trigger a hotspot.

So mouse_getkey() now has as a separate "release" property it sets in the
return value. Right now its always the opposite of "press", but I can imagine
some mouse tracking modes where movement might be reported with neither a
button press nor release event.

Anyway, Nelgin, give this a try and see if it resolves the issues you were
reporting in IRC with avatar chooser mouse support.

For program listings, if the program number is fewer digits than the total
program list count (number of digits), then a carriage return is required
to launch that program. Automate this for the mouse hotspot value, so clicking
Program #1 in a list of 10+ will just run that program and not require the
user to hit the Enter key.

1. Don't enable mouse support if the user's terminal is configured to not
   support it.

2. After calling bbs.receive_file() which displays a menu and uses sbbs's
   internal mouse support, which enables a different mouse reporting mode,
   disable the console.mouse_mode (sbbs's internal mouse support) before
   re-enabling the mouse support for the avatar_chooser's own custom mouse
   mode. Fix fixes issue #414 reported by Nelgin.

3. Fixed a typo in a message displayed to user if avatar upload failed.

With one of the new fields being 64-bit, this lib now requires the updated
File object that supports read/writing 64-bit binary integers too.

Fixes issue #413, at least the non-mouse related part. I was only
able to reproduce it by trying to use the "Edit your avatar" menu item
after choose "I don't want an avatar".

This "I don't want" menu item is weird however and reappears when
the user exits and reruns the chooser, so there's probably still
some improvements needed with this menu item.

The "Upload an avatar" menu item issue is likely totally unrelated.
Please don't combine unrelated issues in the same bug report.

Also, changed "new Object();" and related syntax to literal object definitions, and similar for arrays.

HTTP Directory requests without a trailing slash would "work" (the directory
listing would be sent), but the links to files, since they're relative to the
current request location, would be incorrect (missing the directory's virtual
subdir). So send a 301 response if a client requets a directory without a
trailing slash.

DDMsgReader Version 1.49 - Refactor: Simplified saving a message to BBS machine for sysop (as-is, less processing); removed attachment stuff for pre-Synchronet 3.17; moved hasSyncAttrCodes() to attr_conv.js because that's where it needs to be.

SlyEdit Version 1.78: Removed high-ascii characters from the SlyEdit JS files; used ascii() with their numeric ASCII values instead. This should avoid issues with text editors converting characters incorrectly.

Fixed a weird character issue from the last commit, that may have been due
to using a different text editor that changed some characters, possibly due to
character encoding

SlyEdit 1.77: Fix for aborting when trying to access sub-board information when there are no sub-boards

When looping to highest user number, use system.lastuser, not
system.stats.total_users.

This explains why not all userbases would be affected by the just-fixed
issue in js_user.c. If the total_users happens to equal lastuser, then
you would have hit the issue in js_user.c. If you had at least one
deleted or inactive user account, then system.stats.total_users would
be less than system.lastuser and your system would *not* have triggered
that bug.

If a sysop wants to prevent new users from using an email address of an existing user, they can set SCFG->System->New User Values->Question Toggles->Force Unique E-mail/NetMail to "Yes".

This partially addresses issue #127, at least for the terminal server.

On *nix, log() output can go to syslog() and on Windows, it can go to the
event log.

This addresses issue #360.

Especially for Guest (G-Exempt) accounts which support multiple
concurrent logons - the 'curxtrn' value stored in the user's record
may not match the external program that was actually last executed
on the node in question, so use the .aux property value (from
node.dab) as is done in the C++ code (e.g. printnodedat()). This insures
that the node_status() output here matches the C/C++ code output
(e.g. when logging on the terminal server).

Still support the 'code-based' external program name look-up since
that usage is relied upon by other modules, but when a number is
passed, use the number to find the right external progarm name
(and we need to subtract one, since aux is a 1-based number).

I've looked at this problem a couple of times before and not sure why
I didn't see the solution. <shrug>

Issue #389 reported by Keyop:
srvc 0324 IMAPS <Keyop> !JavaScript  /sbbs/exec/imapservice.js line 653:
TypeError: args[1].toUpperCase is not a function

I'm not sure how you reproduce this error or what type args[1] is
(apparently, not a string), but this fix it regardless. Please let me
know.

Broken in commit ce01d8a7.
F*ck the English language.

Since this script can be reloaded in the same scope.

Fixes issue #387.

Also changed output to reflect slog.c more closely. I suppose only one of
of these 2 "utilities" to read csts.tab should exist at some point. :-)

Also added suport for "-r" and "-t" to be more modern and *nixy.

To match behavior of changed xpdev->byte_estimated_to_str().

If the caller wants a 'B' suffix, they can add it.

Configured in sbbs.ini [web] by setting:

 FileVpathPrefix = /files/
 FileIndexScript = webfileindex.ssjs

And optionally (if you want your vhosts to get filebase access):

 FileVPathForVHosts = true

You can use an .xjs file if you prefer.