DDMsgReader refactor for sysop save to BBS machine & attachments. (!187) · Merge requests · Main / Synchronet · GitLab

Snippets Groups Projects

Merged Eric Oulashin requested to merge dd_msg_reader_attachents_and_save_refactor into master 2 years ago

1 unresolved thread

DDMsgReader Version 1.49 - Refactor: Simplified saving a message to BBS machine for sysop (as-is, less processing); removed attachment stuff for pre-Synchronet 3.17; moved hasSyncAttrCodes() to attr_conv.js because that's where it needs to be. Now requires Synchronet 3.17 or newer.

Edited 2 years ago by Eric Oulashin

Approval is optional

Activity

Eric Oulashin changed the description 2 years ago

changed the description
Rob Swindell enabled an automatic merge when the pipeline for dfd1e302 succeeds 2 years ago

enabled an automatic merge when the pipeline for dfd1e302 succeeds
Eric Oulashin @nightfox · 2 years ago

Author Developer

Looks like svdm failed to build in the pipeline

Edited 2 years ago by Eric Oulashin
Rob Swindell merged 2 years ago

merged
Rob Swindell mentioned in commit 5ab79049 2 years ago

mentioned in commit 5ab79049
Rob Swindell @rswindell started a thread on the diff 2 years ago

exec/load/attr_conv.js

16	16
17	17
18	18	// JS strict mode says octal literals (such as "\1") are deprecated, but
19	19	// it seems better to use \1 than using an actual control character in
Rob Swindell @rswindell · 2 years ago Owner The solution is to use \x01 (hexadecimal) instead. Please register or sign in to reply

Please register or sign in to reply