DDMsgReader: Refactored how email replies are done (passing the header to the appropriate functions, not using ungetstr() when prompting for the message subject
2 unresolved threads
DDMsgReader v1.55: Refactored how email replies are done (passing the header to the appropriate functions, not using ungetstr() when prompting for the message subject
Merge request reports
Activity
assigned to @rswindell
9894 if (pMsgHdr.from_net_type == NET_INTERNET) 9895 emailAddr = pMsgHdr.from_net_addr; 9896 else 9897 emailAddr = pMsgHdr.from + "@" + pMsgHdr.from_net_addr; 9897 if (typeof(pMsgHdr.from_net_addr) === "string" && pMsgHdr.from_net_addr.length > 0) 9898 { 9899 if (pMsgHdr.from_net_type == NET_INTERNET) 9900 emailAddr = pMsgHdr.from_net_addr; 9901 else 9902 emailAddr = pMsgHdr.from + "@" + pMsgHdr.from_net_addr; 9903 } 9898 9904 // Prompt the user to verify the receiver's email address 9899 9905 console.putmsg(bbs.text(Email), P_SAVEATR); 9900 console.ungetstr(emailAddr); 9906 if (emailAddr.length > 0) 9907 console.ungetstr(emailAddr); -
I see you're still using ungetstr() here still, for the address. If you want to allow a user to enter a string, but provide them with a default value that they can edit, you can do that with the K_EDIT mode flag and console.getstr(). ungetstr() should really only be used when there's not a more appropriate solution to the problem.
changed this line in version 2 of the diff
9916 9922 } 9917 9923 if (replyLocally) 9918 9924 { 9925 //console.print("\x01n\r\nHere!\x01p"); // Temporary changed this line in version 2 of the diff
mentioned in commit bf125f60
mentioned in commit 2baca58c
Please register or sign in to reply