ciolib_movetext: Do not leak fill buffer

This fixes a memory leak in ciolib_movetext() which accumulates memory very quickly in scroll heavy ncurses environments. The problem was originally noticed while running syncterm, and confirmed with valgrind.

valgrind confirmation:

17,310,720 bytes in 368 blocks are definitely lost in loss record 128 of 128 at 0x8C82899: malloc by 0x16E273: ciolib_movetext (ciolib.c:563) <>

assigned to @Deuce

added 1 commit

• b1cbde10 - ciolib_puttext: free() is not reachable

Compare with previous version

The second commit was added after I followed the call chain a bit further and noticed this free() that looked out of place in ciolib_puttext. I may not have enough perspective on the code base to understand its purpose, but it doesn't look quite right.

mentioned in commit 113300b8

Thanks for the report. The free() in ciolib_puttext is from when the internal API used a void **.

closed