Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Synchronet Synchronet
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 224
    • Issues 224
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

This GitLab instance has migrated as of Nov-5-2022 to a new server: hardware, OS, SSH key

The v3.20a development branch has now been merged to the master branch. Sysops upgrading from earlier versions must run 'jsexec update'

  • MainMain
  • SynchronetSynchronet
  • Merge requests
  • !213

checkStamp: prevent array size promotion/truncation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed anonymouspage requested to merge anonymouspage/sbbs:checkstamp-array-parameter into master Oct 19, 2022
  • Overview 1
  • Commits 1
  • Pipelines 2
  • Changes 1

Calls to checkStamp are passing literals that are not 20 bytes in size. This causes a "promotion" of the size in the context of checkStamp. We can quiet these warnings by just marking the parameter as a pointer.

Note: a safer approach would be to pass a pointer and length.

This was detected by gcc 11.2.0:

ooii.c:1018:9: error: 'checkStamp' accessing 20 bytes in a region of size 11 [-Werror=stringop-overflow=] ...

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: checkstamp-array-parameter