Skip to content
Snippets Groups Projects

DDMsgReader: Ctrl-C is now supported for message searches to abort the search.

Merged DDMsgReader: Ctrl-C is now supported for message searches to abort the search.
dd_msg_reader_ctrl_c_message_search into master
1 unresolved thread
Merged Eric Oulashin requested to merge dd_msg_reader_ctrl_c_message_search into master
1 unresolved thread

DDMsgReader: Ctrl-C is now supported for message searches to abort the search. A new configurable string was added for this situation: msgSearchAbortedText

Merge request reports

Pipeline #4048 passed

Stage: build

Pipeline passed for 18fc2c3c on dd_msg_reader_ctrl_c_message_search

Approval is optional

Merged by Rob SwindellRob Swindell 2 years ago (Apr 7, 2023 11:49pm UTC)

Merge details

  • Changes merged into master with 53d7c053 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
xtrn/DDMsgReader/DDMsgReader.js
1934 1938 // Now using the can_read property.
1935 1939 for (var subCodeIdx = 0; (subCodeIdx < subBoardsToScan.length) && continueScan; ++subCodeIdx)
1936 1940 {
1941 // Briefly see if there's any input from the console to be received, and
  • Rob Swindell
    Rob Swindell @rswindell ·
    Owner

    The proper way to check for user aborting about (e.g. hitting Ctrl-C) is to check the console.aborted property.

    The only reason this wouldn't work for your script is because you're putting 'C' (CTRL-C) in the ctrl-key passthrough list. Do you have another use for the Ctrl-C key? If not, then I would recommend letting Synchronet handle Ctrl-C input and use console.aborted to see if/when a user has aborted.

  • Please register or sign in to reply
Please register or sign in to reply